removed code for gitops repo migration in devtron apps (#4838)

Co-authored-by: Vikram <[email protected]>

Author: prakash100198

pkg/app/ManifestPushService.go

@@ -106,7 +106,7 @@ func (impl *GitOpsManifestPushServiceImpl) PushChart(manifestPushTemplate *bean.
 		return manifestPushResponse
 	}
 	// 3. Create Git Repo if required
-	if gitOps.IsGitOpsRepoNotConfigured(manifestPushTemplate.RepoUrl) || manifestPushTemplate.GitOpsRepoMigrationRequired {
+	if gitOps.IsGitOpsRepoNotConfigured(manifestPushTemplate.RepoUrl) {
 		overRiddenGitRepoUrl, errMsg := impl.migrateRepoForGitOperation(*manifestPushTemplate, ctx)
 		if errMsg != nil {
 			manifestPushResponse.Error = errMsg

pkg/app/bean/ManifestPushTemplate.go

@@ -6,25 +6,24 @@ const WORKFLOW_EXIST_ERROR = "workflow with this name already exist in this app"
 const Workflows = "workflows"
 
 type ManifestPushTemplate struct {
-	WorkflowRunnerId            int
-	AppId                       int
-	ChartRefId                  int
-	EnvironmentId               int
-	EnvironmentName             string
-	UserId                      int32
-	PipelineOverrideId          int
-	AppName                     string
-	TargetEnvironmentName       int
-	ChartReferenceTemplate      string
-	ChartName                   string
-	ChartVersion                string
-	ChartLocation               string
-	RepoUrl                     string
-	IsCustomGitRepository       bool
-	GitOpsRepoMigrationRequired bool
-	BuiltChartPath              string
-	BuiltChartBytes             *[]byte
-	MergedValues                string
+	WorkflowRunnerId       int
+	AppId                  int
+	ChartRefId             int
+	EnvironmentId          int
+	EnvironmentName        string
+	UserId                 int32
+	PipelineOverrideId     int
+	AppName                string
+	TargetEnvironmentName  int
+	ChartReferenceTemplate string
+	ChartName              string
+	ChartVersion           string
+	ChartLocation          string
+	RepoUrl                string
+	IsCustomGitRepository  bool
+	BuiltChartPath         string
+	BuiltChartBytes        *[]byte
+	MergedValues           string
 }
 
 type ManifestPushResponse struct {

pkg/deployment/trigger/devtronApps/TriggerService.go

@@ -839,34 +839,10 @@ func (impl *TriggerServiceImpl) buildManifestPushTemplate(overrideRequest *bean3
 		manifestPushTemplate.ChartLocation = valuesOverrideResponse.EnvOverride.Chart.ChartLocation
 		manifestPushTemplate.RepoUrl = valuesOverrideResponse.EnvOverride.Chart.GitRepoUrl
 		manifestPushTemplate.IsCustomGitRepository = valuesOverrideResponse.EnvOverride.Chart.IsCustomGitRepository
-		manifestPushTemplate.GitOpsRepoMigrationRequired = impl.checkIfRepoMigrationRequired(manifestPushTemplate)
 	}
 	return manifestPushTemplate, err
 }
 
-// checkIfRepoMigrationRequired checks if gitOps repo name is changed
-func (impl *TriggerServiceImpl) checkIfRepoMigrationRequired(manifestPushTemplate *bean4.ManifestPushTemplate) bool {
-	monoRepoMigrationRequired := false
-	if gitOps.IsGitOpsRepoNotConfigured(manifestPushTemplate.RepoUrl) || manifestPushTemplate.IsCustomGitRepository {
-		return false
-	}
-	var err error
-	gitOpsRepoName := impl.gitOpsConfigReadService.GetGitOpsRepoNameFromUrl(manifestPushTemplate.RepoUrl)
-	if len(gitOpsRepoName) == 0 {
-		gitOpsRepoName, err = impl.getAcdAppGitOpsRepoName(manifestPushTemplate.AppName, manifestPushTemplate.EnvironmentName)
-		if err != nil || gitOpsRepoName == "" {
-			return false
-		}
-	}
-	//here will set new git repo name if required to migrate
-	newGitOpsRepoName := impl.gitOpsConfigReadService.GetGitOpsRepoName(manifestPushTemplate.AppName)
-	//checking weather git repo migration needed or not, if existing git repo and new independent git repo is not same than go ahead with migration
-	if newGitOpsRepoName != gitOpsRepoName {
-		monoRepoMigrationRequired = true
-	}
-	return monoRepoMigrationRequired
-}
-
 // getAcdAppGitOpsRepoName returns the GitOps repository name, configured for the argoCd app
 func (impl *TriggerServiceImpl) getAcdAppGitOpsRepoName(appName string, environmentName string) (string, error) {
 	//this method should only call in case of argo-integration and gitops configured