Skip to content

Commit 2d379b3

Browse files
Remove outlier consistency check, fix #2432
1 parent 8838ed4 commit 2d379b3

File tree

1 file changed

+0
-14
lines changed

1 file changed

+0
-14
lines changed

src/BenchmarkDotNet/Analysers/OutliersAnalyser.cs

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -22,25 +22,11 @@ protected override IEnumerable<Conclusion> AnalyseReport(BenchmarkReport report,
2222
var workloadActual = report.AllMeasurements.Where(m => m.Is(IterationMode.Workload, IterationStage.Actual)).ToArray();
2323
if (workloadActual.IsEmpty())
2424
yield break;
25-
var result = report.AllMeasurements.Where(m => m.Is(IterationMode.Workload, IterationStage.Result)).ToArray();
2625
var outlierMode = report.BenchmarkCase.Job.ResolveValue(AccuracyMode.OutlierModeCharacteristic, EngineResolver.Instance); // TODO: improve
2726
var statistics = workloadActual.GetStatistics();
2827
var allOutliers = statistics.AllOutliers;
2928
var actualOutliers = statistics.GetActualOutliers(outlierMode);
3029

31-
if (result.Length + actualOutliers.Length != workloadActual.Length)
32-
{
33-
// This should never happen
34-
yield return CreateHint(
35-
"Something went wrong with outliers: " +
36-
$"Size(WorkloadActual) = {workloadActual.Length}, " +
37-
$"Size(WorkloadActual/Outliers) = {actualOutliers.Length}, " +
38-
$"Size(Result) = {result.Length}), " +
39-
$"OutlierMode = {outlierMode}",
40-
report);
41-
yield break;
42-
}
43-
4430
var cultureInfo = summary.GetCultureInfo();
4531
if (allOutliers.Any())
4632
yield return CreateHint(GetMessage(actualOutliers, allOutliers, statistics.LowerOutliers, statistics.UpperOutliers, cultureInfo), report);

0 commit comments

Comments
 (0)