Fixed nullability warnings in methods signatures

Author: alinasmirnova

samples/BenchmarkDotNet.Samples/IntroOrderManual.cs

@@ -22,7 +22,7 @@ private class Config : ManualConfig
             private class FastestToSlowestOrderer : IOrderer
             {
                 public IEnumerable<BenchmarkCase> GetExecutionOrder(ImmutableArray<BenchmarkCase> benchmarksCase,
-                    IEnumerable<BenchmarkLogicalGroupRule> order = null) =>
+                    IEnumerable<BenchmarkLogicalGroupRule>? order = null) =>
                     from benchmark in benchmarksCase
                     orderby benchmark.Parameters["X"] descending,
                         benchmark.Descriptor.WorkloadMethodDisplayInfo
@@ -39,7 +39,7 @@ public string GetLogicalGroupKey(ImmutableArray<BenchmarkCase> allBenchmarksCase
                     benchmarkCase.Job.DisplayInfo + "_" + benchmarkCase.Parameters.DisplayInfo;
 
                 public IEnumerable<IGrouping<string, BenchmarkCase>> GetLogicalGroupOrder(IEnumerable<IGrouping<string, BenchmarkCase>> logicalGroups,
-                    IEnumerable<BenchmarkLogicalGroupRule> order = null) =>
+                    IEnumerable<BenchmarkLogicalGroupRule>? order = null) =>
                     logicalGroups.OrderBy(it => it.Key);
 
                 public bool SeparateLogicalGroups => true;

src/BenchmarkDotNet.Diagnostics.Windows/Configs/InliningDiagnoserAttribute.cs

@@ -13,7 +13,7 @@ public InliningDiagnoserAttribute(bool logFailuresOnly = true, bool filterByName
             Config = ManualConfig.CreateEmpty().AddDiagnoser(new InliningDiagnoser(logFailuresOnly, filterByNamespace));
         }
 
-        public InliningDiagnoserAttribute(bool logFailuresOnly = true, string[] allowedNamespaces = null)
+        public InliningDiagnoserAttribute(bool logFailuresOnly = true, string[]? allowedNamespaces = null)
         {
             Config = ManualConfig.CreateEmpty().AddDiagnoser(new InliningDiagnoser(logFailuresOnly, allowedNamespaces));
         }

src/BenchmarkDotNet.Diagnostics.Windows/EtwDiagnoser.cs

@@ -97,7 +97,7 @@ private void Clear()
 
         private void OnProcessExit(object sender, EventArgs e) => Session?.Dispose();
 
-        private static string GetSessionName(string prefix, BenchmarkCase benchmarkCase, ParameterInstances parameters = null)
+        private static string GetSessionName(string prefix, BenchmarkCase benchmarkCase, ParameterInstances? parameters = null)
         {
             if (parameters != null && parameters.Items.Count > 0)
                 return $"{prefix}-{benchmarkCase.FolderInfo}-{parameters.FolderInfo}";

src/BenchmarkDotNet.Diagnostics.Windows/EtwProfilerConfig.cs

@@ -41,8 +41,8 @@ public EtwProfilerConfig(
             float cpuSampleIntervalInMilliseconds = 1.0f,
             KernelTraceEventParser.Keywords kernelKeywords = KernelTraceEventParser.Keywords.ImageLoad | KernelTraceEventParser.Keywords.Profile,
             KernelTraceEventParser.Keywords kernelStackKeywords = KernelTraceEventParser.Keywords.Profile,
-            IReadOnlyDictionary<HardwareCounter, Func<ProfileSourceInfo, int>> intervalSelectors = null,
-            IReadOnlyCollection<(Guid providerGuid, TraceEventLevel providerLevel, ulong keywords, TraceEventProviderOptions options)> providers = null,
+            IReadOnlyDictionary<HardwareCounter, Func<ProfileSourceInfo, int>>? intervalSelectors = null,
+            IReadOnlyCollection<(Guid providerGuid, TraceEventLevel providerLevel, ulong keywords, TraceEventProviderOptions options)>? providers = null,
             bool createHeapSession = false)
         {
             CreateHeapSession = createHeapSession;

src/BenchmarkDotNet.Diagnostics.Windows/InliningDiagnoser.cs

@@ -35,7 +35,7 @@ public InliningDiagnoser(bool logFailuresOnly = true, bool filterByNamespace = t
         /// </summary>
         /// <param name="logFailuresOnly">only the methods that failed to get inlined. True by default.</param>
         /// <param name="allowedNamespaces">list of namespaces from which inlining message should be print.</param>
-        public InliningDiagnoser(bool logFailuresOnly = true, string[] allowedNamespaces = null)
+        public InliningDiagnoser(bool logFailuresOnly = true, string[]? allowedNamespaces = null)
         {
             this.logFailuresOnly = logFailuresOnly;
             this.allowedNamespaces = allowedNamespaces;

src/BenchmarkDotNet/Code/EnumParam.cs

@@ -24,7 +24,7 @@ private EnumParam(object value, Type type)
         public string ToSourceCode() =>
             $"({type.GetCorrectCSharpTypeName()})({ToInvariantCultureString()})";
 
-        internal static IParam FromObject(object value, Type type = null)
+        internal static IParam FromObject(object value, Type? type = null)
         {
             type = type ?? value.GetType();
             if (!type.IsEnum)

src/BenchmarkDotNet/Columns/StatisticColumn.cs

@@ -107,7 +107,7 @@ private enum Priority
         private readonly IStatisticColumn parentColumn;
 
         private StatisticColumn(string columnName, string legend, Func<Statistics, double> calc, Priority priority, UnitType type = UnitType.Time,
-            IStatisticColumn parentColumn = null)
+            IStatisticColumn? parentColumn = null)
         {
             this.calc = calc;
             this.priority = priority;

src/BenchmarkDotNet/ConsoleArguments/ConfigParser.cs

@@ -72,7 +72,7 @@ public static class ConfigParser
                 { "fullxml", new[] { XmlExporter.Full } }
             };
 
-        public static (bool isSuccess, IConfig config, CommandLineOptions options) Parse(string[] args, ILogger logger, IConfig globalConfig = null)
+        public static (bool isSuccess, IConfig config, CommandLineOptions options) Parse(string[] args, ILogger logger, IConfig? globalConfig = null)
         {
             (bool isSuccess, IConfig config, CommandLineOptions options) result = default;
 

src/BenchmarkDotNet/Diagnosers/EventPipeProfiler.cs

@@ -40,7 +40,7 @@ public EventPipeProfiler() :this(profile: EventPipeProfile.CpuSampling, performE
         /// <param name="profile">A named pre-defined set of provider configurations that allows common tracing scenarios to be specified succinctly.</param>
         /// <param name="providers">A list of EventPipe providers to be enabled.</param>
         /// <param name="performExtraBenchmarksRun">if set to true, benchmarks will be executed one more time with the profiler attached. If set to false, there will be no extra run but the results will contain overhead. True by default.</param>
-        public EventPipeProfiler(EventPipeProfile profile = EventPipeProfile.CpuSampling, IReadOnlyCollection<EventPipeProvider> providers = null, bool performExtraBenchmarksRun = true)
+        public EventPipeProfiler(EventPipeProfile profile = EventPipeProfile.CpuSampling, IReadOnlyCollection<EventPipeProvider>? providers = null, bool performExtraBenchmarksRun = true)
         {
             this.performExtraBenchmarksRun = performExtraBenchmarksRun;
             eventPipeProviders = MapToProviders(profile, providers);

src/BenchmarkDotNet/Disassemblers/DisassemblyDiagnoserConfig.cs

@@ -22,8 +22,8 @@ public class DisassemblyDiagnoserConfig
         public DisassemblyDiagnoserConfig(
             int maxDepth = 1,
             DisassemblySyntax syntax = DisassemblySyntax.Masm,
-            string[] filters = null,
-            FormatterOptions formatterOptions = null,
+            string[]? filters = null,
+            FormatterOptions? formatterOptions = null,
             bool printSource = false,
             bool printInstructionAddresses = false,
             bool exportGithubMarkdown = true,