Address review comments

Author: mdaigle

src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnectionFactory.cs

@@ -11,8 +11,8 @@
 using System.Runtime.Versioning;
 using Microsoft.Data.Common;
 using Microsoft.Data.ProviderBase;
-using Microsoft.Data.SqlClient.Server;
 using Microsoft.Data.SqlClient.ConnectionPool;
+using Microsoft.Data.SqlClient.Server;
 
 namespace Microsoft.Data.SqlClient
 {

src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnectionHelper.cs

@@ -10,10 +10,10 @@ namespace Microsoft.Data.SqlClient
     using System.Diagnostics;
     using System.Runtime.ConstrainedExecution;
     using System.Threading;
+    using System.Transactions;
     using Microsoft.Data.Common;
     using Microsoft.Data.ProviderBase;
     using Microsoft.Data.SqlClient.ConnectionPool;
-    using System.Transactions;
 
     public sealed partial class SqlConnection : DbConnection
     {

src/Microsoft.Data.SqlClient/src/Microsoft/Data/ProviderBase/DbConnectionFactory.cs

@@ -578,7 +578,7 @@ private void PruneConnectionPoolGroups(object state)
                             if (0 == pool.Count)
                             {
                                 _poolsToRelease.Remove(pool);
-                                SqlClientEventSource.Log.TryAdvancedTraceEvent("<prov.DbConnectionFactory.PruneConnectionPoolGroups|RES|INFO|CPOOL> {0}, ReleasePool={1}", ObjectID, pool.ObjectID);
+                                SqlClientEventSource.Log.TryAdvancedTraceEvent("<prov.DbConnectionFactory.PruneConnectionPoolGroups|RES|INFO|CPOOL> {0}, ReleasePool={1}", ObjectID, pool.ObjectId);
 #if NETFRAMEWORK
                                 PerformanceCounters.NumberOfInactiveConnectionPools.Decrement();
 #else

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/DbConnectionPool.cs

@@ -14,85 +14,37 @@ namespace Microsoft.Data.SqlClient.ConnectionPool
 {
     internal abstract class DbConnectionPool
     {
-        private static int _objectTypeCount; // EventSource counter
-        internal readonly int _objectID = System.Threading.Interlocked.Increment(ref _objectTypeCount);
-
-        internal int ObjectID
-        {
-            get
-            {
-                return _objectID;
-            }
-        }
-
-        private DbConnectionPoolState _state;
-        internal DbConnectionPoolState State
-        {
-            get => _state;
-            set => _state = value;
-        }
+        private static int _objectTypeCount;
+
+        internal int ObjectId { get; } = System.Threading.Interlocked.Increment(ref _objectTypeCount);
+
+        internal DbConnectionPoolState State { get; set; }
 
         #region Abstract Properties
-        internal abstract int Count
-        {
-            get;
-        }
-
-        internal abstract DbConnectionFactory ConnectionFactory
-        {
-            get;
-        }
-
-        internal abstract bool ErrorOccurred
-        {
-            get;
-        }
-
-        internal abstract TimeSpan LoadBalanceTimeout
-        {
-            get;
-        }
-
-        internal abstract DbConnectionPoolIdentity Identity
-        {
-            get;
-        }
-
-        internal abstract bool IsRunning
-        {
-            get;
-        }
+        internal abstract int Count { get; }
+
+        internal abstract DbConnectionFactory ConnectionFactory { get; }
+
+        internal abstract bool ErrorOccurred { get; }
+
+        internal abstract TimeSpan LoadBalanceTimeout { get; }
+
+        internal abstract DbConnectionPoolIdentity Identity { get; }
+
+        internal abstract bool IsRunning { get; }
 
 #if NETFRAMEWORK
-        internal abstract DbConnectionPoolCounters PerformanceCounters
-        {
-            get;
-        }
+        internal abstract DbConnectionPoolCounters PerformanceCounters { get; }
 #endif
-        internal abstract DbConnectionPoolGroup PoolGroup
-        {
-            get;
-        }
-
-        internal abstract DbConnectionPoolGroupOptions PoolGroupOptions
-        {
-            get;
-        }
-
-        internal abstract DbConnectionPoolProviderInfo ProviderInfo
-        {
-            get;
-        }
-
-        internal abstract ConcurrentDictionary<DbConnectionPoolAuthenticationContextKey, DbConnectionPoolAuthenticationContext> AuthenticationContexts
-        {
-            get;
-        }
-
-        internal abstract bool UseLoadBalancing
-        {
-            get;
-        }
+        internal abstract DbConnectionPoolGroup PoolGroup { get; }
+
+        internal abstract DbConnectionPoolGroupOptions PoolGroupOptions { get; }
+
+        internal abstract DbConnectionPoolProviderInfo ProviderInfo { get; }
+
+        internal abstract ConcurrentDictionary<DbConnectionPoolAuthenticationContextKey, DbConnectionPoolAuthenticationContext> AuthenticationContexts { get; }
+
+        internal abstract bool UseLoadBalancing { get; }
         #endregion
 
         #region Abstract Methods