[tests] Workaround sqlserver 2022-latest latest image failing

radical · radical · commit 928883361c76 · 2024-07-24T17:23:19.000-04:00
.. with testcontainers because the path `/opt/mssql-tools/bin/sqlcmd` changed to `/opt/mssql-tools18/bin/sqlcmd`. But this hardcoded path is being used in testcontainers, causing it to fail. testcontainers/testcontainers-dotnet#1220 microsoft/mssql-docker#892
diff --git a/tests/Aspire.Microsoft.Data.SqlClient.Tests/SqlServerContainerFixture.cs b/tests/Aspire.Microsoft.Data.SqlClient.Tests/SqlServerContainerFixture.cs
@@ -3,6 +3,7 @@
 
 using Aspire.Components.Common.Tests;
 using Aspire.Hosting;
+using DotNet.Testcontainers.Builders;
 using Testcontainers.MsSql;
 using Xunit;
 
@@ -21,6 +22,7 @@ public async Task InitializeAsync()
         {
             Container = new MsSqlBuilder()
                             .WithImage($"{SqlServerContainerImageTags.Registry}/{SqlServerContainerImageTags.Image}:{SqlServerContainerImageTags.Tag}")
+                            .WithWaitStrategy(Wait.ForUnixContainer().UntilCommandIsCompleted("/opt/mssql-tools18/bin/sqlcmd", "-C", "-Q", "SELECT 1;"))
                             .Build();
             await Container.StartAsync();
         }

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@`
`3`	`3`
`4`	`4`	`using Aspire.Components.Common.Tests;`
`5`	`5`	`using Aspire.Hosting;`
	`6`	`+using DotNet.Testcontainers.Builders;`
`6`	`7`	`using Testcontainers.MsSql;`
`7`	`8`	`using Xunit;`
`8`	`9`
`@@ -21,6 +22,7 @@ public async Task InitializeAsync()`
`21`	`22`	`{`
`22`	`23`	`Container = new MsSqlBuilder()`
`23`	`24`	`.WithImage($"{SqlServerContainerImageTags.Registry}/{SqlServerContainerImageTags.Image}:{SqlServerContainerImageTags.Tag}")`
	`25`	`+ .WithWaitStrategy(Wait.ForUnixContainer().UntilCommandIsCompleted("/opt/mssql-tools18/bin/sqlcmd", "-C", "-Q", "SELECT 1;"))`
`24`	`26`	`.Build();`
`25`	`27`	`await Container.StartAsync();`
`26`	`28`	`}`