Skip to content

Commit fbf7f87

Browse files
committed
Tests
1 parent c4ccd0d commit fbf7f87

File tree

1 file changed

+14
-7
lines changed

1 file changed

+14
-7
lines changed

tests/Aspire.Hosting.Tests/Dashboard/DashboardResourceTests.cs

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -263,8 +263,10 @@ public async Task DashboardResourceServiceUriIsSet()
263263
Assert.Equal("http://localhost:5000", config.Single(e => e.Key == DashboardConfigNames.ResourceServiceUrlName.EnvVarName).Value);
264264
}
265265

266-
[Fact]
267-
public async Task DashboardResource_OtlpHttpEndpoint_CorsEnvVarSet()
266+
[Theory]
267+
[InlineData("*")]
268+
[InlineData(null)]
269+
public async Task DashboardResource_OtlpHttpEndpoint_CorsEnvVarSet(string? explicitCorsAllowedOrigins)
268270
{
269271
// Arrange
270272
using var builder = TestDistributedApplicationBuilder.Create(options => options.DisableDashboard = false);
@@ -277,7 +279,8 @@ public async Task DashboardResource_OtlpHttpEndpoint_CorsEnvVarSet()
277279
builder.Configuration.AddInMemoryCollection(new Dictionary<string, string?>
278280
{
279281
["ASPNETCORE_URLS"] = "http://localhost",
280-
["DOTNET_DASHBOARD_OTLP_HTTP_ENDPOINT_URL"] = "http://localhost"
282+
["DOTNET_DASHBOARD_OTLP_HTTP_ENDPOINT_URL"] = "http://localhost",
283+
["DOTNET_DASHBOARD_CORS_ALLOWED_ORIGINS"] = explicitCorsAllowedOrigins
281284
});
282285

283286
using var app = builder.Build();
@@ -295,12 +298,15 @@ public async Task DashboardResource_OtlpHttpEndpoint_CorsEnvVarSet()
295298

296299
var config = await EnvironmentVariableEvaluator.GetEnvironmentVariablesAsync(dashboard, DistributedApplicationOperation.Run, app.Services);
297300

298-
Assert.Equal("http://localhost:8081,http://localhost:58080", config.Single(e => e.Key == DashboardConfigNames.DashboardOtlpCorsAllowedOriginsKeyName.EnvVarName).Value);
301+
var expectedAllowedOrigins = !string.IsNullOrEmpty(explicitCorsAllowedOrigins) ? explicitCorsAllowedOrigins : "http://localhost:8081,http://localhost:58080";
302+
Assert.Equal(expectedAllowedOrigins, config.Single(e => e.Key == DashboardConfigNames.DashboardOtlpCorsAllowedOriginsKeyName.EnvVarName).Value);
299303
Assert.Equal("*", config.Single(e => e.Key == DashboardConfigNames.DashboardOtlpCorsAllowedHeadersKeyName.EnvVarName).Value);
300304
}
301305

302-
[Fact]
303-
public async Task DashboardResource_OtlpGrpcEndpoint_CorsEnvVarNotSet()
306+
[Theory]
307+
[InlineData("*")]
308+
[InlineData(null)]
309+
public async Task DashboardResource_OtlpGrpcEndpoint_CorsEnvVarNotSet(string? explicitCorsAllowedOrigins)
304310
{
305311
// Arrange
306312
using var builder = TestDistributedApplicationBuilder.Create(options => options.DisableDashboard = false);
@@ -313,7 +319,8 @@ public async Task DashboardResource_OtlpGrpcEndpoint_CorsEnvVarNotSet()
313319
builder.Configuration.AddInMemoryCollection(new Dictionary<string, string?>
314320
{
315321
["ASPNETCORE_URLS"] = "http://localhost",
316-
["DOTNET_DASHBOARD_OTLP_ENDPOINT_URL"] = "http://localhost"
322+
["DOTNET_DASHBOARD_OTLP_ENDPOINT_URL"] = "http://localhost",
323+
["DOTNET_DASHBOARD_CORS_ALLOWED_ORIGINS"] = explicitCorsAllowedOrigins
317324
});
318325

319326
using var app = builder.Build();

0 commit comments

Comments
 (0)