Address API review notes

Author: roji

src/EFCore.Cosmos/Extensions/CosmosDbFunctionsExtensions.cs

@@ -94,9 +94,9 @@ public static double FullTextScore(this DbFunctions _, string property, params s
     ///     Combines scores provided by two or more specified functions.
     /// </summary>
     /// <param name="_">The <see cref="DbFunctions" /> instance.</param>
-    /// <param name="functions">The functions to compute the score for.</param>
+    /// <param name="scores">Scoring function calls to be combined.</param>
     /// <returns>The combined score.</returns>
-    public static double Rrf(this DbFunctions _, params double[] functions)
+    public static double Rrf(this DbFunctions _, params double[] scores)
         => throw new InvalidOperationException(CoreStrings.FunctionOnClient(nameof(Rrf)));
 
     /// <summary>

src/EFCore.Cosmos/Query/Internal/CosmosSqlTranslatingExpressionVisitor.cs

@@ -5,7 +5,7 @@
 using System.Diagnostics.CodeAnalysis;
 using Microsoft.EntityFrameworkCore.Cosmos.Internal;
 using Microsoft.EntityFrameworkCore.Internal;
-using static Microsoft.EntityFrameworkCore.Query.QueryHelpers;
+using static Microsoft.EntityFrameworkCore.Infrastructure.ExpressionExtensions;
 
 namespace Microsoft.EntityFrameworkCore.Cosmos.Query.Internal;
 

src/EFCore.Relational/Query/RelationalQueryableMethodTranslatingExpressionVisitor.ExecuteDelete.cs

@@ -1,6 +1,7 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+using System.Diagnostics.CodeAnalysis;
 using Microsoft.EntityFrameworkCore.Query.SqlExpressions;
 
 namespace Microsoft.EntityFrameworkCore.Query;
@@ -189,4 +190,14 @@ protected virtual bool IsValidSelectExpressionForExecuteDelete(SelectExpression
             GroupBy: [],
             Having: null
         };
+
+    /// <summary>
+    ///     This method has been obsoleted, use the method accepting a single SelectExpression parameter instead.
+    /// </summary>
+    [Obsolete("This method has been obsoleted, use the method accepting a single SelectExpression parameter instead.", error: true)]
+    protected virtual bool IsValidSelectExpressionForExecuteDelete(
+        SelectExpression selectExpression,
+        StructuralTypeShaperExpression shaper,
+        [NotNullWhen(true)] out TableExpression? tableExpression)
+        => throw new UnreachableException();
 }

src/EFCore.Relational/Query/RelationalQueryableMethodTranslatingExpressionVisitor.ExecuteUpdate.cs

@@ -4,7 +4,7 @@
 using System.Diagnostics.CodeAnalysis;
 using Microsoft.EntityFrameworkCore.Query.Internal;
 using Microsoft.EntityFrameworkCore.Query.SqlExpressions;
-using static Microsoft.EntityFrameworkCore.Query.QueryHelpers;
+using static Microsoft.EntityFrameworkCore.Infrastructure.ExpressionExtensions;
 
 namespace Microsoft.EntityFrameworkCore.Query;
 

src/EFCore/Infrastructure/ExpressionExtensions.cs

@@ -438,4 +438,55 @@ static Expression AddConvertToObject(Expression expression)
                 ? Expression.Convert(expression, typeof(object))
                 : expression;
     }
+
+    /// <summary>
+    ///     Returns whether the given expression represents a member access and if so, returns the decomposed base expression and the member
+    ///     identity.
+    /// </summary>
+    /// <param name="expression">The expression to check.</param>
+    /// <param name="model">The model being used.</param>
+    /// <param name="baseExpression">The given expression, with the top-level member access node removed.</param>
+    /// <returns>
+    ///     <see langword="true" /> if <paramref name="expression"/> represents a member access, <see langword="false" /> otherwise.
+    /// </returns>
+    public static bool IsMemberAccess(
+        Expression expression,
+        IModel model,
+        [NotNullWhen(true)] out Expression? baseExpression)
+        => IsMemberAccess(expression, model, out baseExpression, out _);
+
+    /// <summary>
+    ///     Returns whether the given expression represents a member access and if so, returns the decomposed base expression and the member
+    ///     identity.
+    /// </summary>
+    /// <param name="expression">The expression to check.</param>
+    /// <param name="model">The model being used.</param>
+    /// <param name="baseExpression">The given expression, with the top-level member access node removed.</param>
+    /// <param name="memberIdentity">A <see cref="MemberIdentity" /> representing the member being accessed.</param>
+    /// <returns>
+    ///     <see langword="true" /> if <paramref name="expression"/> represents a member access, <see langword="false" /> otherwise.
+    /// </returns>
+    public static bool IsMemberAccess(
+        Expression expression,
+        IModel model,
+        [NotNullWhen(true)] out Expression? baseExpression,
+        out MemberIdentity memberIdentity)
+    {
+        switch (expression)
+        {
+            case MemberExpression { Expression: not null } member:
+                baseExpression = member.Expression;
+                memberIdentity = MemberIdentity.Create(member.Member);
+                return true;
+            case MethodCallExpression methodCall
+                when methodCall.TryGetEFPropertyArguments(out baseExpression, out var propertyName)
+                || methodCall.TryGetIndexerArguments(model, out baseExpression, out propertyName):
+                memberIdentity = MemberIdentity.Create(propertyName);
+                return true;
+            default:
+                memberIdentity = MemberIdentity.None;
+                baseExpression = null;
+                return false;
+        }
+    }
 }

src/EFCore/Query/ParameterQueryRootExpression.cs

@@ -58,4 +58,40 @@ protected override Expression VisitChildren(ExpressionVisitor visitor)
     /// <inheritdoc />
     protected override void Print(ExpressionPrinter expressionPrinter)
         => expressionPrinter.Visit(QueryParameterExpression);
+
+    /// <summary>
+    ///     This constructor has been obsoleted, use the constructor accepting QueryParameterExpression instead.
+    /// </summary>
+    [Obsolete("Use the constructor accepting QueryParameterExpression instead.")]
+    public ParameterQueryRootExpression(
+        IAsyncQueryProvider asyncQueryProvider,
+        Type elementType,
+        ParameterExpression parameterExpression)
+        : this(
+            asyncQueryProvider,
+            elementType,
+            new QueryParameterExpression(
+                parameterExpression.Name ?? throw new ArgumentException($"{parameterExpression} must have a name"),
+                parameterExpression.Type))
+    {
+    }
+
+    /// <summary>
+    ///     This constructor has been obsoleted, use the constructor accepting QueryParameterExpression instead.
+    /// </summary>
+    [Obsolete("Use the constructor accepting QueryParameterExpression instead.")]
+    public ParameterQueryRootExpression(Type elementType, ParameterExpression parameterExpression)
+        : this(
+            elementType,
+            new QueryParameterExpression(
+                parameterExpression.Name ?? throw new ArgumentException($"{parameterExpression} must have a name"),
+                parameterExpression.Type))
+    {
+    }
+
+    /// <summary>
+    ///     This constructor has been obsoleted, use QueryParameterExpression instead.
+    /// </summary>
+    [Obsolete("Use QueryParameterExpression instead.")]
+    public virtual ParameterExpression ParameterExpression => Parameter(QueryParameterExpression.Type, QueryParameterExpression.Name);
 }

src/EFCore/Query/QueryHelpers.cs

@@ -1,7 +1,7 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-using static Microsoft.EntityFrameworkCore.Query.QueryHelpers;
+using static Microsoft.EntityFrameworkCore.Infrastructure.ExpressionExtensions;
 
 namespace Microsoft.EntityFrameworkCore.Query;