Skip to content

Commit dce8368

Browse files
committed
Remove sync from primitive collection tests
1 parent bd1e532 commit dce8368

File tree

9 files changed

+2420
-3019
lines changed

9 files changed

+2420
-3019
lines changed

test/EFCore.Cosmos.FunctionalTests/Query/PrimitiveCollectionsQueryCosmosTest.cs

Lines changed: 770 additions & 1071 deletions
Large diffs are not rendered by default.

test/EFCore.Relational.Specification.Tests/Query/PrimitiveCollectionsQueryRelationalTestBase.cs

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,19 @@ namespace Microsoft.EntityFrameworkCore.Query;
88
public class PrimitiveCollectionsQueryRelationalTestBase<TFixture>(TFixture fixture) : PrimitiveCollectionsQueryTestBase<TFixture>(fixture)
99
where TFixture : PrimitiveCollectionsQueryTestBase<TFixture>.PrimitiveCollectionsQueryFixtureBase, new()
1010
{
11-
[ConditionalTheory]
12-
[MemberData(nameof(IsAsyncData))]
13-
public override async Task Inline_collection_Count_with_zero_values(bool async)
11+
[ConditionalFact]
12+
public override async Task Inline_collection_Count_with_zero_values()
1413
{
15-
var exception = await Assert.ThrowsAsync<InvalidOperationException>(() => base.Inline_collection_Count_with_zero_values(async));
14+
var exception = await Assert.ThrowsAsync<InvalidOperationException>(() => base.Inline_collection_Count_with_zero_values());
1615

1716
Assert.Equal(RelationalStrings.EmptyCollectionNotSupportedAsInlineQueryRoot, exception.Message);
1817
}
1918

20-
public override Task Column_collection_Concat_parameter_collection_equality_inline_collection(bool async)
21-
=> AssertTranslationFailed(() => base.Column_collection_Concat_parameter_collection_equality_inline_collection(async));
19+
public override Task Column_collection_Concat_parameter_collection_equality_inline_collection()
20+
=> AssertTranslationFailed(base.Column_collection_Concat_parameter_collection_equality_inline_collection);
2221

23-
public override Task Column_collection_equality_inline_collection_with_parameters(bool async)
24-
=> AssertTranslationFailed(() => base.Column_collection_equality_inline_collection_with_parameters(async));
22+
public override Task Column_collection_equality_inline_collection_with_parameters()
23+
=> AssertTranslationFailed(base.Column_collection_equality_inline_collection_with_parameters);
2524

2625
[ConditionalFact]
2726
public override void Parameter_collection_in_subquery_and_Convert_as_compiled_query()
@@ -36,24 +35,23 @@ public override void Parameter_collection_in_subquery_and_Convert_as_compiled_qu
3635
Assert.Contains("in the SQL tree does not have a type mapping assigned", exception.Message);
3736
}
3837

39-
public override async Task Parameter_collection_in_subquery_Union_another_parameter_collection_as_compiled_query(bool async)
38+
public override async Task Parameter_collection_in_subquery_Union_another_parameter_collection_as_compiled_query()
4039
{
4140
var message = (await Assert.ThrowsAsync<InvalidOperationException>(
42-
() => base.Parameter_collection_in_subquery_Union_another_parameter_collection_as_compiled_query(async))).Message;
41+
base.Parameter_collection_in_subquery_Union_another_parameter_collection_as_compiled_query)).Message;
4342

4443
Assert.Equal(RelationalStrings.SetOperationsRequireAtLeastOneSideWithValidTypeMapping("Union"), message);
4544
}
4645

47-
public override async Task Project_inline_collection_with_Concat(bool async)
46+
public override async Task Project_inline_collection_with_Concat()
4847
{
49-
var message = (await Assert.ThrowsAsync<InvalidOperationException>(
50-
() => base.Project_inline_collection_with_Concat(async))).Message;
48+
var message = (await Assert.ThrowsAsync<InvalidOperationException>(base.Project_inline_collection_with_Concat)).Message;
5149

5250
Assert.Equal(RelationalStrings.InsufficientInformationToIdentifyElementOfCollectionJoin, message);
5351
}
5452

5553
// TODO: Requires converting the results of a subquery (relational rowset) to a primitive collection for comparison,
5654
// not yet supported (#33792)
57-
public override async Task Column_collection_Where_equality_inline_collection(bool async)
58-
=> await AssertTranslationFailed(() => base.Column_collection_Where_equality_inline_collection(async));
55+
public override async Task Column_collection_Where_equality_inline_collection()
56+
=> await AssertTranslationFailed(base.Column_collection_Where_equality_inline_collection);
5957
}

0 commit comments

Comments
 (0)