From 38b45e56dae3277d9e87bd4db960701d4dda18aa Mon Sep 17 00:00:00 2001
From: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Date: Tue, 28 Jan 2025 14:30:21 -0800
Subject: [PATCH 1/4] add some crefs to inheritdoc

---
 .../AdditionalPropertiesDictionary{TValue}.cs                 | 4 ++--
 .../ChatCompletion/CachingChatClient.cs                       | 4 ++--
 .../ChatCompletion/ConfigureOptionsChatClient.cs              | 4 ++--
 .../Embeddings/CachingEmbeddingGenerator.cs                   | 2 +-
 .../Embeddings/ConfigureOptionsEmbeddingGenerator.cs          | 2 +-
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/Libraries/Microsoft.Extensions.AI.Abstractions/AdditionalPropertiesDictionary{TValue}.cs b/src/Libraries/Microsoft.Extensions.AI.Abstractions/AdditionalPropertiesDictionary{TValue}.cs
index 0c8afb3ce06..1e503d13889 100644
--- a/src/Libraries/Microsoft.Extensions.AI.Abstractions/AdditionalPropertiesDictionary{TValue}.cs
+++ b/src/Libraries/Microsoft.Extensions.AI.Abstractions/AdditionalPropertiesDictionary{TValue}.cs
@@ -143,10 +143,10 @@ void ICollection<KeyValuePair<string, TValue>>.CopyTo(KeyValuePair<string, TValu
     bool ICollection<KeyValuePair<string, TValue>>.Remove(KeyValuePair<string, TValue> item) => ((ICollection<KeyValuePair<string, TValue>>)_dictionary).Remove(item);
 
     /// <summary>Attempts to extract a typed value from the dictionary.</summary>
-    /// <typeparam name="T">Specifies the type of the value to be retrieved.</typeparam>
+    /// <typeparam name="T">The type of the value to be retrieved.</typeparam>
     /// <param name="key">The key to locate.</param>
     /// <param name="value">
-    /// The value retrieved from the dictionary, if found and successfully converted to the requested type;
+    /// When this method returns, contains he value retrieved from the dictionary, if found and successfully converted to the requested type;
     /// otherwise, the default value of <typeparamref name="T"/>.
     /// </param>
     /// <returns>
diff --git a/src/Libraries/Microsoft.Extensions.AI/ChatCompletion/CachingChatClient.cs b/src/Libraries/Microsoft.Extensions.AI/ChatCompletion/CachingChatClient.cs
index f2de7f92fc8..72f1028afa5 100644
--- a/src/Libraries/Microsoft.Extensions.AI/ChatCompletion/CachingChatClient.cs
+++ b/src/Libraries/Microsoft.Extensions.AI/ChatCompletion/CachingChatClient.cs
@@ -44,7 +44,7 @@ protected CachingChatClient(IChatClient innerClient)
     /// </remarks>
     public bool CoalesceStreamingUpdates { get; set; } = true;
 
-    /// <inheritdoc />
+    /// <inheritdoc cref="IChatClient"/>
     public override async Task<ChatCompletion> CompleteAsync(IList<ChatMessage> chatMessages, ChatOptions? options = null, CancellationToken cancellationToken = default)
     {
         _ = Throw.IfNull(chatMessages);
@@ -63,7 +63,7 @@ public override async Task<ChatCompletion> CompleteAsync(IList<ChatMessage> chat
         return result;
     }
 
-    /// <inheritdoc />
+    /// <inheritdoc cref="IChatClient"/>
     public override async IAsyncEnumerable<StreamingChatCompletionUpdate> CompleteStreamingAsync(
         IList<ChatMessage> chatMessages, ChatOptions? options = null, [EnumeratorCancellation] CancellationToken cancellationToken = default)
     {
diff --git a/src/Libraries/Microsoft.Extensions.AI/ChatCompletion/ConfigureOptionsChatClient.cs b/src/Libraries/Microsoft.Extensions.AI/ChatCompletion/ConfigureOptionsChatClient.cs
index ce2fe3ca29d..5f84226d846 100644
--- a/src/Libraries/Microsoft.Extensions.AI/ChatCompletion/ConfigureOptionsChatClient.cs
+++ b/src/Libraries/Microsoft.Extensions.AI/ChatCompletion/ConfigureOptionsChatClient.cs
@@ -33,13 +33,13 @@ public ConfigureOptionsChatClient(IChatClient innerClient, Action<ChatOptions> c
         _configureOptions = Throw.IfNull(configure);
     }
 
-    /// <inheritdoc/>
+    /// <inheritdoc cref="IChatClient"/>
     public override async Task<ChatCompletion> CompleteAsync(IList<ChatMessage> chatMessages, ChatOptions? options = null, CancellationToken cancellationToken = default)
     {
         return await base.CompleteAsync(chatMessages, Configure(options), cancellationToken).ConfigureAwait(false);
     }
 
-    /// <inheritdoc/>
+    /// <inheritdoc cref="IChatClient"/>
     public override async IAsyncEnumerable<StreamingChatCompletionUpdate> CompleteStreamingAsync(
         IList<ChatMessage> chatMessages, ChatOptions? options = null, [EnumeratorCancellation] CancellationToken cancellationToken = default)
     {
diff --git a/src/Libraries/Microsoft.Extensions.AI/Embeddings/CachingEmbeddingGenerator.cs b/src/Libraries/Microsoft.Extensions.AI/Embeddings/CachingEmbeddingGenerator.cs
index 688e4b2353d..44fa7384a9d 100644
--- a/src/Libraries/Microsoft.Extensions.AI/Embeddings/CachingEmbeddingGenerator.cs
+++ b/src/Libraries/Microsoft.Extensions.AI/Embeddings/CachingEmbeddingGenerator.cs
@@ -24,7 +24,7 @@ protected CachingEmbeddingGenerator(IEmbeddingGenerator<TInput, TEmbedding> inne
     {
     }
 
-    /// <inheritdoc />
+    /// <inheritdoc cref="IEmbeddingGenerator{TInput, TEmbedding}"/>
     public override async Task<GeneratedEmbeddings<TEmbedding>> GenerateAsync(
         IEnumerable<TInput> values, EmbeddingGenerationOptions? options = null, CancellationToken cancellationToken = default)
     {
diff --git a/src/Libraries/Microsoft.Extensions.AI/Embeddings/ConfigureOptionsEmbeddingGenerator.cs b/src/Libraries/Microsoft.Extensions.AI/Embeddings/ConfigureOptionsEmbeddingGenerator.cs
index 8332064f22a..f3da95d00f7 100644
--- a/src/Libraries/Microsoft.Extensions.AI/Embeddings/ConfigureOptionsEmbeddingGenerator.cs
+++ b/src/Libraries/Microsoft.Extensions.AI/Embeddings/ConfigureOptionsEmbeddingGenerator.cs
@@ -40,7 +40,7 @@ public ConfigureOptionsEmbeddingGenerator(
         _configureOptions = Throw.IfNull(configure);
     }
 
-    /// <inheritdoc/>
+    /// <inheritdoc cref="IEmbeddingGenerator{TInput, TEmbedding}"/>
     public override async Task<GeneratedEmbeddings<TEmbedding>> GenerateAsync(
         IEnumerable<TInput> values,
         EmbeddingGenerationOptions? options = null,

From 758903d46bc87fcdf3634aac4f742782e87a09f5 Mon Sep 17 00:00:00 2001
From: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Date: Tue, 28 Jan 2025 14:45:40 -0800
Subject: [PATCH 2/4] be more specific

---
 .../ChatCompletion/CachingChatClient.cs                       | 4 ++--
 .../ChatCompletion/ConfigureOptionsChatClient.cs              | 4 ++--
 .../Embeddings/CachingEmbeddingGenerator.cs                   | 2 +-
 .../Embeddings/ConfigureOptionsEmbeddingGenerator.cs          | 2 +-
 .../Microsoft.Extensions.Hosting.Testing/FakeHostOptions.cs   | 4 ++--
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/Libraries/Microsoft.Extensions.AI/ChatCompletion/CachingChatClient.cs b/src/Libraries/Microsoft.Extensions.AI/ChatCompletion/CachingChatClient.cs
index 72f1028afa5..81718480505 100644
--- a/src/Libraries/Microsoft.Extensions.AI/ChatCompletion/CachingChatClient.cs
+++ b/src/Libraries/Microsoft.Extensions.AI/ChatCompletion/CachingChatClient.cs
@@ -44,7 +44,7 @@ protected CachingChatClient(IChatClient innerClient)
     /// </remarks>
     public bool CoalesceStreamingUpdates { get; set; } = true;
 
-    /// <inheritdoc cref="IChatClient"/>
+    /// <inheritdoc cref="IChatClient.CompleteAsync(IList{ChatMessage}, ChatOptions?, CancellationToken)"/>
     public override async Task<ChatCompletion> CompleteAsync(IList<ChatMessage> chatMessages, ChatOptions? options = null, CancellationToken cancellationToken = default)
     {
         _ = Throw.IfNull(chatMessages);
@@ -63,7 +63,7 @@ public override async Task<ChatCompletion> CompleteAsync(IList<ChatMessage> chat
         return result;
     }
 
-    /// <inheritdoc cref="IChatClient"/>
+    /// <inheritdoc cref="IChatClient.CompleteStreamingAsync(IList{ChatMessage}, ChatOptions?, CancellationToken)"/>
     public override async IAsyncEnumerable<StreamingChatCompletionUpdate> CompleteStreamingAsync(
         IList<ChatMessage> chatMessages, ChatOptions? options = null, [EnumeratorCancellation] CancellationToken cancellationToken = default)
     {
diff --git a/src/Libraries/Microsoft.Extensions.AI/ChatCompletion/ConfigureOptionsChatClient.cs b/src/Libraries/Microsoft.Extensions.AI/ChatCompletion/ConfigureOptionsChatClient.cs
index 5f84226d846..2761f303fb1 100644
--- a/src/Libraries/Microsoft.Extensions.AI/ChatCompletion/ConfigureOptionsChatClient.cs
+++ b/src/Libraries/Microsoft.Extensions.AI/ChatCompletion/ConfigureOptionsChatClient.cs
@@ -33,13 +33,13 @@ public ConfigureOptionsChatClient(IChatClient innerClient, Action<ChatOptions> c
         _configureOptions = Throw.IfNull(configure);
     }
 
-    /// <inheritdoc cref="IChatClient"/>
+    /// <inheritdoc cref="IChatClient.CompleteAsync(IList{ChatMessage}, ChatOptions?, CancellationToken)"/>
     public override async Task<ChatCompletion> CompleteAsync(IList<ChatMessage> chatMessages, ChatOptions? options = null, CancellationToken cancellationToken = default)
     {
         return await base.CompleteAsync(chatMessages, Configure(options), cancellationToken).ConfigureAwait(false);
     }
 
-    /// <inheritdoc cref="IChatClient"/>
+    /// <inheritdoc cref="IChatClient.CompleteStreamingAsync(IList{ChatMessage}, ChatOptions?, CancellationToken)"/>
     public override async IAsyncEnumerable<StreamingChatCompletionUpdate> CompleteStreamingAsync(
         IList<ChatMessage> chatMessages, ChatOptions? options = null, [EnumeratorCancellation] CancellationToken cancellationToken = default)
     {
diff --git a/src/Libraries/Microsoft.Extensions.AI/Embeddings/CachingEmbeddingGenerator.cs b/src/Libraries/Microsoft.Extensions.AI/Embeddings/CachingEmbeddingGenerator.cs
index 44fa7384a9d..c4437a06c36 100644
--- a/src/Libraries/Microsoft.Extensions.AI/Embeddings/CachingEmbeddingGenerator.cs
+++ b/src/Libraries/Microsoft.Extensions.AI/Embeddings/CachingEmbeddingGenerator.cs
@@ -24,7 +24,7 @@ protected CachingEmbeddingGenerator(IEmbeddingGenerator<TInput, TEmbedding> inne
     {
     }
 
-    /// <inheritdoc cref="IEmbeddingGenerator{TInput, TEmbedding}"/>
+    /// <inheritdoc cref="IEmbeddingGenerator{TInput, TEmbedding}.GenerateAsync(IEnumerable{TInput}, EmbeddingGenerationOptions?, CancellationToken)"/>
     public override async Task<GeneratedEmbeddings<TEmbedding>> GenerateAsync(
         IEnumerable<TInput> values, EmbeddingGenerationOptions? options = null, CancellationToken cancellationToken = default)
     {
diff --git a/src/Libraries/Microsoft.Extensions.AI/Embeddings/ConfigureOptionsEmbeddingGenerator.cs b/src/Libraries/Microsoft.Extensions.AI/Embeddings/ConfigureOptionsEmbeddingGenerator.cs
index f3da95d00f7..693ae3c8b12 100644
--- a/src/Libraries/Microsoft.Extensions.AI/Embeddings/ConfigureOptionsEmbeddingGenerator.cs
+++ b/src/Libraries/Microsoft.Extensions.AI/Embeddings/ConfigureOptionsEmbeddingGenerator.cs
@@ -40,7 +40,7 @@ public ConfigureOptionsEmbeddingGenerator(
         _configureOptions = Throw.IfNull(configure);
     }
 
-    /// <inheritdoc cref="IEmbeddingGenerator{TInput, TEmbedding}"/>
+    /// <inheritdoc cref="IEmbeddingGenerator{TInput, TEmbedding}.GenerateAsync(IEnumerable{TInput}, EmbeddingGenerationOptions?, CancellationToken)"/>
     public override async Task<GeneratedEmbeddings<TEmbedding>> GenerateAsync(
         IEnumerable<TInput> values,
         EmbeddingGenerationOptions? options = null,
diff --git a/src/Libraries/Microsoft.Extensions.Hosting.Testing/FakeHostOptions.cs b/src/Libraries/Microsoft.Extensions.Hosting.Testing/FakeHostOptions.cs
index 345d604f5cd..7080cae5bea 100644
--- a/src/Libraries/Microsoft.Extensions.Hosting.Testing/FakeHostOptions.cs
+++ b/src/Libraries/Microsoft.Extensions.Hosting.Testing/FakeHostOptions.cs
@@ -43,10 +43,10 @@ public class FakeHostOptions
     /// </value>
     public bool FakeLogging { get; set; } = true;
 
-    /// <inheritdoc cref="ServiceProviderOptions"/>
+    /// <inheritdoc cref="ServiceProviderOptions.ValidateScopes"/>
     public bool ValidateScopes { get; set; } = true;
 
-    /// <inheritdoc cref="ServiceProviderOptions"/>
+    /// <inheritdoc cref="ServiceProviderOptions.ValidateOnBuild"/>
     public bool ValidateOnBuild { get; set; } = true;
 
     /// <summary>

From 935127a11909d5ea434e26012b2b8d9949aa70a2 Mon Sep 17 00:00:00 2001
From: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Date: Tue, 28 Jan 2025 14:49:36 -0800
Subject: [PATCH 3/4] typo

---
 .../AdditionalPropertiesDictionary{TValue}.cs                   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Libraries/Microsoft.Extensions.AI.Abstractions/AdditionalPropertiesDictionary{TValue}.cs b/src/Libraries/Microsoft.Extensions.AI.Abstractions/AdditionalPropertiesDictionary{TValue}.cs
index 1e503d13889..21d1daf2820 100644
--- a/src/Libraries/Microsoft.Extensions.AI.Abstractions/AdditionalPropertiesDictionary{TValue}.cs
+++ b/src/Libraries/Microsoft.Extensions.AI.Abstractions/AdditionalPropertiesDictionary{TValue}.cs
@@ -146,7 +146,7 @@ void ICollection<KeyValuePair<string, TValue>>.CopyTo(KeyValuePair<string, TValu
     /// <typeparam name="T">The type of the value to be retrieved.</typeparam>
     /// <param name="key">The key to locate.</param>
     /// <param name="value">
-    /// When this method returns, contains he value retrieved from the dictionary, if found and successfully converted to the requested type;
+    /// When this method returns, contains the value retrieved from the dictionary, if found and successfully converted to the requested type;
     /// otherwise, the default value of <typeparamref name="T"/>.
     /// </param>
     /// <returns>

From 5dcf864c6e188564e5bed6ccf01d8d4535696276 Mon Sep 17 00:00:00 2001
From: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Date: Tue, 28 Jan 2025 19:13:38 -0800
Subject: [PATCH 4/4] reset some files; fix platform bug instead

---
 .../ChatCompletion/CachingChatClient.cs                       | 4 ++--
 .../ChatCompletion/ConfigureOptionsChatClient.cs              | 4 ++--
 .../Embeddings/CachingEmbeddingGenerator.cs                   | 2 +-
 .../Embeddings/ConfigureOptionsEmbeddingGenerator.cs          | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/Libraries/Microsoft.Extensions.AI/ChatCompletion/CachingChatClient.cs b/src/Libraries/Microsoft.Extensions.AI/ChatCompletion/CachingChatClient.cs
index 81718480505..f2de7f92fc8 100644
--- a/src/Libraries/Microsoft.Extensions.AI/ChatCompletion/CachingChatClient.cs
+++ b/src/Libraries/Microsoft.Extensions.AI/ChatCompletion/CachingChatClient.cs
@@ -44,7 +44,7 @@ protected CachingChatClient(IChatClient innerClient)
     /// </remarks>
     public bool CoalesceStreamingUpdates { get; set; } = true;
 
-    /// <inheritdoc cref="IChatClient.CompleteAsync(IList{ChatMessage}, ChatOptions?, CancellationToken)"/>
+    /// <inheritdoc />
     public override async Task<ChatCompletion> CompleteAsync(IList<ChatMessage> chatMessages, ChatOptions? options = null, CancellationToken cancellationToken = default)
     {
         _ = Throw.IfNull(chatMessages);
@@ -63,7 +63,7 @@ public override async Task<ChatCompletion> CompleteAsync(IList<ChatMessage> chat
         return result;
     }
 
-    /// <inheritdoc cref="IChatClient.CompleteStreamingAsync(IList{ChatMessage}, ChatOptions?, CancellationToken)"/>
+    /// <inheritdoc />
     public override async IAsyncEnumerable<StreamingChatCompletionUpdate> CompleteStreamingAsync(
         IList<ChatMessage> chatMessages, ChatOptions? options = null, [EnumeratorCancellation] CancellationToken cancellationToken = default)
     {
diff --git a/src/Libraries/Microsoft.Extensions.AI/ChatCompletion/ConfigureOptionsChatClient.cs b/src/Libraries/Microsoft.Extensions.AI/ChatCompletion/ConfigureOptionsChatClient.cs
index 2761f303fb1..ce2fe3ca29d 100644
--- a/src/Libraries/Microsoft.Extensions.AI/ChatCompletion/ConfigureOptionsChatClient.cs
+++ b/src/Libraries/Microsoft.Extensions.AI/ChatCompletion/ConfigureOptionsChatClient.cs
@@ -33,13 +33,13 @@ public ConfigureOptionsChatClient(IChatClient innerClient, Action<ChatOptions> c
         _configureOptions = Throw.IfNull(configure);
     }
 
-    /// <inheritdoc cref="IChatClient.CompleteAsync(IList{ChatMessage}, ChatOptions?, CancellationToken)"/>
+    /// <inheritdoc/>
     public override async Task<ChatCompletion> CompleteAsync(IList<ChatMessage> chatMessages, ChatOptions? options = null, CancellationToken cancellationToken = default)
     {
         return await base.CompleteAsync(chatMessages, Configure(options), cancellationToken).ConfigureAwait(false);
     }
 
-    /// <inheritdoc cref="IChatClient.CompleteStreamingAsync(IList{ChatMessage}, ChatOptions?, CancellationToken)"/>
+    /// <inheritdoc/>
     public override async IAsyncEnumerable<StreamingChatCompletionUpdate> CompleteStreamingAsync(
         IList<ChatMessage> chatMessages, ChatOptions? options = null, [EnumeratorCancellation] CancellationToken cancellationToken = default)
     {
diff --git a/src/Libraries/Microsoft.Extensions.AI/Embeddings/CachingEmbeddingGenerator.cs b/src/Libraries/Microsoft.Extensions.AI/Embeddings/CachingEmbeddingGenerator.cs
index c4437a06c36..688e4b2353d 100644
--- a/src/Libraries/Microsoft.Extensions.AI/Embeddings/CachingEmbeddingGenerator.cs
+++ b/src/Libraries/Microsoft.Extensions.AI/Embeddings/CachingEmbeddingGenerator.cs
@@ -24,7 +24,7 @@ protected CachingEmbeddingGenerator(IEmbeddingGenerator<TInput, TEmbedding> inne
     {
     }
 
-    /// <inheritdoc cref="IEmbeddingGenerator{TInput, TEmbedding}.GenerateAsync(IEnumerable{TInput}, EmbeddingGenerationOptions?, CancellationToken)"/>
+    /// <inheritdoc />
     public override async Task<GeneratedEmbeddings<TEmbedding>> GenerateAsync(
         IEnumerable<TInput> values, EmbeddingGenerationOptions? options = null, CancellationToken cancellationToken = default)
     {
diff --git a/src/Libraries/Microsoft.Extensions.AI/Embeddings/ConfigureOptionsEmbeddingGenerator.cs b/src/Libraries/Microsoft.Extensions.AI/Embeddings/ConfigureOptionsEmbeddingGenerator.cs
index 693ae3c8b12..8332064f22a 100644
--- a/src/Libraries/Microsoft.Extensions.AI/Embeddings/ConfigureOptionsEmbeddingGenerator.cs
+++ b/src/Libraries/Microsoft.Extensions.AI/Embeddings/ConfigureOptionsEmbeddingGenerator.cs
@@ -40,7 +40,7 @@ public ConfigureOptionsEmbeddingGenerator(
         _configureOptions = Throw.IfNull(configure);
     }
 
-    /// <inheritdoc cref="IEmbeddingGenerator{TInput, TEmbedding}.GenerateAsync(IEnumerable{TInput}, EmbeddingGenerationOptions?, CancellationToken)"/>
+    /// <inheritdoc/>
     public override async Task<GeneratedEmbeddings<TEmbedding>> GenerateAsync(
         IEnumerable<TInput> values,
         EmbeddingGenerationOptions? options = null,