Skip to content

Commit 12a296a

Browse files
committed
Fix code review findings
1 parent dea8cb8 commit 12a296a

File tree

6 files changed

+16
-16
lines changed

6 files changed

+16
-16
lines changed

src/Microsoft.Data.Analysis/ArrowStringDataFrameColumn.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ private int GetBufferIndexContainingRowIndex(long rowIndex, out int indexInBuffe
226226
{
227227
if (rowIndex >= Length)
228228
{
229-
throw new ArgumentOutOfRangeException(Strings.RowIndexOutOfRange, nameof(rowIndex));
229+
throw new ArgumentOutOfRangeException(Strings.IndexIsGreaterThanColumnLength, nameof(rowIndex));
230230
}
231231

232232
// Since the strings here could be of variable length, scan linearly

src/Microsoft.Data.Analysis/PrimitiveColumnContainer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@ public int GetIndexOfBufferContainingRowIndex(long rowIndex)
313313
{
314314
if (rowIndex >= Length)
315315
{
316-
throw new ArgumentOutOfRangeException(Strings.RowIndexOutOfRange, nameof(rowIndex));
316+
throw new ArgumentOutOfRangeException(Strings.IndexIsGreaterThanColumnLength, nameof(rowIndex));
317317
}
318318
return (int)(rowIndex / ReadOnlyDataFrameBuffer<T>.MaxCapacity);
319319
}

src/Microsoft.Data.Analysis/StringDataFrameColumn.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ private int GetBufferIndexContainingRowIndex(long rowIndex)
8282
{
8383
if (rowIndex >= Length)
8484
{
85-
throw new ArgumentOutOfRangeException(Strings.RowIndexOutOfRange, nameof(rowIndex));
85+
throw new ArgumentOutOfRangeException(Strings.IndexIsGreaterThanColumnLength, nameof(rowIndex));
8686
}
8787
return (int)(rowIndex / MaxCapacity);
8888
}

src/Microsoft.Data.Analysis/Strings.Designer.cs

Lines changed: 9 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Microsoft.Data.Analysis/Strings.resx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,9 @@
183183
<data name="InconsistentNullBitMapAndNullCount" xml:space="preserve">
184184
<value>Inconsistent null bitmaps and NullCounts</value>
185185
</data>
186+
<data name="IndexIsGreaterThanColumnLength" xml:space="preserve">
187+
<value>Index cannot be greater than the Column's Length</value>
188+
</data>
186189
<data name="InvalidColumnName" xml:space="preserve">
187190
<value>Column '{0}' does not exist</value>
188191
</data>
@@ -234,9 +237,6 @@
234237
<data name="PositiveNumberOfCharacters" xml:space="preserve">
235238
<value>{0} must be greater than 0</value>
236239
</data>
237-
<data name="RowIndexOutOfRange" xml:space="preserve">
238-
<value>Index cannot be greater than the Column's Length</value>
239-
</data>
240240
<data name="SpansMultipleBuffers" xml:space="preserve">
241241
<value>Cannot span multiple buffers</value>
242242
</data>

src/Microsoft.Data.Analysis/VBufferDataFrameColumn.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ private int GetBufferIndexContainingRowIndex(long rowIndex)
8484
{
8585
if (rowIndex >= Length)
8686
{
87-
throw new ArgumentOutOfRangeException(Strings.RowIndexOutOfRange, nameof(rowIndex));
87+
throw new ArgumentOutOfRangeException(Strings.IndexIsGreaterThanColumnLength, nameof(rowIndex));
8888
}
8989

9090
return (int)(rowIndex / MaxCapacity);

0 commit comments

Comments
 (0)