Move tracking of builds to unit-test solution crawler code (#78905)

Author: CyrusNajmabadi

src/EditorFeatures/Core/Remote/SolutionChecksumUpdater.cs

@@ -25,12 +25,6 @@ internal sealed class SolutionChecksumUpdater
 {
     private readonly Workspace _workspace;
 
-    /// <summary>
-    /// We're not at a layer where we are guaranteed to have an IGlobalOperationNotificationService.  So allow for
-    /// it being null.
-    /// </summary>
-    private readonly IGlobalOperationNotificationService? _globalOperationService;
-
     private readonly IDocumentTrackingService _documentTrackingService;
 
     /// <summary>
@@ -54,17 +48,13 @@ internal sealed class SolutionChecksumUpdater
     private const string SynchronizeTextChangesStatusSucceededKeyName = nameof(SolutionChecksumUpdater) + "." + SynchronizeTextChangesStatusSucceededMetricName;
     private const string SynchronizeTextChangesStatusFailedKeyName = nameof(SolutionChecksumUpdater) + "." + SynchronizeTextChangesStatusFailedMetricName;
 
-    private bool _isSynchronizeWorkspacePaused;
-
     public SolutionChecksumUpdater(
         Workspace workspace,
         IAsynchronousOperationListenerProvider listenerProvider,
         CancellationToken shutdownToken)
     {
         var listener = listenerProvider.GetListener(FeatureAttribute.SolutionChecksumUpdater);
 
-        _globalOperationService = workspace.Services.SolutionServices.ExportProvider.GetExports<IGlobalOperationNotificationService>().FirstOrDefault()?.Value;
-
         _workspace = workspace;
         _documentTrackingService = workspace.Services.GetRequiredService<IDocumentTrackingService>();
 
@@ -87,12 +77,6 @@ public SolutionChecksumUpdater(
         _workspaceChangedImmediateDisposer = _workspace.RegisterWorkspaceChangedImmediateHandler(OnWorkspaceChangedImmediate);
         _documentTrackingService.ActiveDocumentChanged += OnActiveDocumentChanged;
 
-        if (_globalOperationService != null)
-        {
-            _globalOperationService.Started += OnGlobalOperationStarted;
-            _globalOperationService.Stopped += OnGlobalOperationStopped;
-        }
-
         // Enqueue the work to sync the initial data over.
         _synchronizeActiveDocumentQueue.AddWork();
         _synchronizeWorkspaceQueue.AddWork();
@@ -101,53 +85,21 @@ public SolutionChecksumUpdater(
     public void Shutdown()
     {
         // Try to stop any work that is in progress.
-        PauseSynchronizingPrimaryWorkspace();
-
-        _documentTrackingService.ActiveDocumentChanged -= OnActiveDocumentChanged;
-        _workspaceChangedDisposer.Dispose();
-        _workspaceChangedImmediateDisposer.Dispose();
-
-        if (_globalOperationService != null)
-        {
-            _globalOperationService.Started -= OnGlobalOperationStarted;
-            _globalOperationService.Stopped -= OnGlobalOperationStopped;
-        }
-    }
-
-    private void OnGlobalOperationStarted(object? sender, EventArgs e)
-        => PauseSynchronizingPrimaryWorkspace();
-
-    private void OnGlobalOperationStopped(object? sender, EventArgs e)
-        => ResumeSynchronizingPrimaryWorkspace();
-
-    private void PauseSynchronizingPrimaryWorkspace()
-    {
-        // An expensive global operation started (like a build).  Pause ourselves and cancel any outstanding work in
-        // progress to synchronize the solution.
         lock (_gate)
         {
             _synchronizeWorkspaceQueue.CancelExistingWork();
-            _isSynchronizeWorkspacePaused = true;
         }
-    }
 
-    private void ResumeSynchronizingPrimaryWorkspace()
-    {
-        lock (_gate)
-        {
-            _isSynchronizeWorkspacePaused = false;
-            _synchronizeWorkspaceQueue.AddWork();
-        }
+        _documentTrackingService.ActiveDocumentChanged -= OnActiveDocumentChanged;
+        _workspaceChangedDisposer.Dispose();
+        _workspaceChangedImmediateDisposer.Dispose();
     }
 
     private void OnWorkspaceChanged(WorkspaceChangeEventArgs _)
     {
-        // Check if we're currently paused.  If so ignore this notification.  We don't want to any work in response
-        // to whatever the workspace is doing.
         lock (_gate)
         {
-            if (!_isSynchronizeWorkspacePaused)
-                _synchronizeWorkspaceQueue.AddWork();
+            _synchronizeWorkspaceQueue.AddWork();
         }
     }
 

src/EditorFeatures/TestUtilities/EditorTestCompositions.cs

@@ -7,7 +7,6 @@
 using Microsoft.CodeAnalysis.Editor.Implementation.Notification;
 using Microsoft.CodeAnalysis.LanguageServer;
 using Microsoft.CodeAnalysis.Test.Utilities;
-using Microsoft.CodeAnalysis.Test.Utilities.Notification;
 using Microsoft.CodeAnalysis.Text;
 using Microsoft.CodeAnalysis.UnitTests.Fakes;
 using Microsoft.CodeAnalysis.UnitTests.Remote;
@@ -57,7 +56,6 @@ public static class EditorTestCompositions
             typeof(TestObscuringTipManager));         // TODO: https://devdiv.visualstudio.com/DevDiv/_workitems?id=544569
 
     public static readonly TestComposition EditorFeatures = FeaturesTestCompositions.Features
-        .AddParts(typeof(TestGlobalOperationNotificationService))
         .Add(Editor)
         .AddAssemblies(
             typeof(TextEditorResources).Assembly,

src/EditorFeatures/TestUtilities/Notification/TestGlobalOperationNotificationService.cs

@@ -4,7 +4,7 @@
 
 using System;
 
-namespace Microsoft.CodeAnalysis.Notification;
+namespace Microsoft.CodeAnalysis.ExternalAccess.UnitTesting.Notification;
 
 internal partial class AbstractGlobalOperationNotificationService
 {

src/Workspaces/Core/Portable/Notification/AbstractGlobalOperationNotificationService.GlobalOperationRegistration.cs renamed to src/Features/Core/Portable/ExternalAccess/UnitTesting/Notification/AbstractGlobalOperationNotificationService.GlobalOperationRegistration.cs

@@ -11,7 +11,7 @@
 using Microsoft.CodeAnalysis.Threading;
 using Roslyn.Utilities;
 
-namespace Microsoft.CodeAnalysis.Notification;
+namespace Microsoft.CodeAnalysis.ExternalAccess.UnitTesting.Notification;
 
 internal abstract partial class AbstractGlobalOperationNotificationService : IGlobalOperationNotificationService
 {

src/Workspaces/Core/Portable/Notification/AbstractGlobalOperationNotificationService.cs renamed to src/Features/Core/Portable/ExternalAccess/UnitTesting/Notification/AbstractGlobalOperationNotificationService.cs

@@ -4,7 +4,7 @@
 
 using System;
 
-namespace Microsoft.CodeAnalysis.Notification;
+namespace Microsoft.CodeAnalysis.ExternalAccess.UnitTesting.Notification;
 
 /// <summary>
 /// Optional interface that can be used to hear about when expensive global operations (like a 'build') occur in the

src/Workspaces/Core/Portable/Notification/IGlobalOperationNotificationService.cs renamed to src/Features/Core/Portable/ExternalAccess/UnitTesting/Notification/IGlobalOperationNotificationService.cs

@@ -4,7 +4,7 @@
 
 using System;
 using System.Threading;
-using Microsoft.CodeAnalysis.Notification;
+using Microsoft.CodeAnalysis.ExternalAccess.UnitTesting.Notification;
 using Microsoft.CodeAnalysis.Shared.TestHooks;
 
 namespace Microsoft.CodeAnalysis.ExternalAccess.UnitTesting.SolutionCrawler;

src/Features/Core/Portable/ExternalAccess/UnitTesting/SolutionCrawler/UnitTestingGlobalOperationAwareIdleProcessor.cs

@@ -6,8 +6,8 @@
 using System.Collections.Immutable;
 using System.Threading;
 using System.Threading.Tasks;
+using Microsoft.CodeAnalysis.ExternalAccess.UnitTesting.Notification;
 using Microsoft.CodeAnalysis.Internal.Log;
-using Microsoft.CodeAnalysis.Notification;
 using Microsoft.CodeAnalysis.Shared.TestHooks;
 
 namespace Microsoft.CodeAnalysis.ExternalAccess.UnitTesting.SolutionCrawler;

src/Features/Core/Portable/ExternalAccess/UnitTesting/SolutionCrawler/UnitTestingWorkCoordinator.AbstractUnitTestingPriorityProcessor.cs

@@ -10,6 +10,7 @@
 using System.Threading.Tasks;
 using Microsoft.CodeAnalysis.ErrorReporting;
 using Microsoft.CodeAnalysis.ExternalAccess.UnitTesting.Api;
+using Microsoft.CodeAnalysis.ExternalAccess.UnitTesting.Notification;
 using Microsoft.CodeAnalysis.Host;
 using Microsoft.CodeAnalysis.Internal.Log;
 using Microsoft.CodeAnalysis.LanguageService;

src/Features/Core/Portable/ExternalAccess/UnitTesting/SolutionCrawler/UnitTestingWorkCoordinator.UnitTestingIncrementalAnalyzerProcessor.cs

@@ -8,8 +8,8 @@
 using System.Threading;
 using System.Threading.Tasks;
 using Microsoft.CodeAnalysis.ErrorReporting;
+using Microsoft.CodeAnalysis.ExternalAccess.UnitTesting.Notification;
 using Microsoft.CodeAnalysis.Internal.Log;
-using Microsoft.CodeAnalysis.Notification;
 using Microsoft.CodeAnalysis.Shared.TestHooks;
 
 namespace Microsoft.CodeAnalysis.ExternalAccess.UnitTesting.SolutionCrawler;