[automated] Merge branch 'main' => 'main-vs-deps' (#79433)

I detected changes in the main branch which have not been merged yet to
main-vs-deps. I'm a robot and am configured to help you automatically
keep main-vs-deps up to date, so I've opened this PR.

This PR merges commits made on main by the following committers:

* CyrusNajmabadi
* jcouv
* AlekseyTs
* 333fred

## Instructions for merging from UI

This PR will not be auto-merged. When pull request checks pass, complete
this PR by creating a merge commit, *not* a squash or rebase commit.

<img alt="merge button instructions"
src="https://i.imgur.com/GepcNJV.png" width="300" />

If this repo does not allow creating merge commits from the GitHub UI,
use command line instructions.

## Instructions for merging via command line

Run these commands to merge this pull request from the command line.

``` sh
git fetch
git checkout main
git pull --ff-only
git checkout main-vs-deps
git pull --ff-only
git merge --no-ff main

# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet/roslyn HEAD:merge/main-to-main-vs-deps
```

<details>
<summary>or if you are using SSH</summary>

```
git push [email protected]:dotnet/roslyn HEAD:merge/main-to-main-vs-deps
```

</details>


After PR checks are complete push the branch
```
git push
```

## Instructions for resolving conflicts

:warning: If there are merge conflicts, you will need to resolve them
manually before merging. You can do this [using GitHub][resolve-github]
or using the [command line][resolve-cli].

[resolve-github]:
https://help.github.com/articles/resolving-a-merge-conflict-on-github/
[resolve-cli]:
https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/

## Instructions for updating this pull request

Contributors to this repo have permission update this pull request by
pushing to the branch 'merge/main-to-main-vs-deps'. This can be done to
resolve conflicts or make other changes to this pull request before it
is merged.
The provided examples assume that the remote is named 'origin'. If you
have a different remote name, please replace 'origin' with the name of
your remote.

```
git fetch
git checkout -b merge/main-to-main-vs-deps origin/main-vs-deps
git pull https://github.com/dotnet/roslyn merge/main-to-main-vs-deps
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet/roslyn HEAD:merge/main-to-main-vs-deps
```

<details>
    <summary>or if you are using SSH</summary>

```
git fetch
git checkout -b merge/main-to-main-vs-deps origin/main-vs-deps
git pull [email protected]:dotnet/roslyn merge/main-to-main-vs-deps
(make changes)
git commit -m "Updated PR with my changes"
git push [email protected]:dotnet/roslyn HEAD:merge/main-to-main-vs-deps
```

</details>

Contact .NET Core Engineering (dotnet/dnceng) if you have questions or
issues.
Also, if this PR was generated incorrectly, help us fix it. See
https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.

Author: dotnet-policy-service[bot]

docs/contributing/Compiler Test Plan.md

@@ -55,7 +55,7 @@ This document provides guidance for thinking about language interactions and tes
   - Compiler-recognized attributes should not have any effect in earlier LangVersions,
     except a LangVersion error should be reported when functionality depending on the attribute is used
     (for example, InlineArray conversion to Span).
-- Generics (type arguments, variance, constraints including `class`, `struct`, `new()`, `unmanaged`, `notnull`, types and interfaces with nullability)
+- Generics (type arguments, variance, constraints including `class`, `struct`, `new()`, `unmanaged`, `notnull`, `allows ref struct`, types and interfaces with nullability)
 - Default and constant values
 - Partial classes
 - Literals

src/Analyzers/CSharp/Analyzers/MakeStructMemberReadOnly/CSharpMakeStructMemberReadOnlyAnalyzer.cs

@@ -14,7 +14,6 @@
 using Microsoft.CodeAnalysis.Operations;
 using Microsoft.CodeAnalysis.PooledObjects;
 using Microsoft.CodeAnalysis.Shared.Extensions;
-using Roslyn.Utilities;
 
 namespace Microsoft.CodeAnalysis.CSharp.MakeStructMemberReadOnly;
 
@@ -331,6 +330,10 @@ private static bool OperationPotentiallyMutatesThis(
 
             if (operation is IInlineArrayAccessOperation)
             {
+                // to determine if this is safe to make into a ReadOnlySpan or not.
+                if (operation.Type.IsSpan())
+                    return true;
+
                 // If we're writing into an inline-array off of 'this'.  Then we can't make this `readonly`.
                 if (CSharpSemanticFacts.Instance.IsWrittenTo(semanticModel, operation.Syntax, cancellationToken))
                     return true;

src/Analyzers/CSharp/Analyzers/UseExpressionBody/Helpers/UseExpressionBodyForPropertiesHelper.cs

@@ -5,12 +5,15 @@
 #nullable disable
 
 using System;
+using System.Linq;
 using System.Threading;
 using Microsoft.CodeAnalysis.CodeStyle;
 using Microsoft.CodeAnalysis.CSharp.CodeGeneration;
 using Microsoft.CodeAnalysis.CSharp.CodeStyle;
+using Microsoft.CodeAnalysis.CSharp.Extensions;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
+using Microsoft.CodeAnalysis.Shared.Extensions;
 
 namespace Microsoft.CodeAnalysis.CSharp.UseExpressionBody;
 

src/Analyzers/CSharp/Analyzers/UseExpressionBody/Helpers/UseExpressionBodyHelper`1.cs

@@ -242,22 +242,48 @@ public TDeclaration Update(SemanticModel semanticModel, TDeclaration declaration
                                                .Concat(declaration.GetTrailingTrivia());
             semicolonToken = semicolonToken.WithTrailingTrivia(trailingTrivia);
 
-            return WithSemicolonToken(
-                       WithExpressionBody(
-                           WithBody(declaration, body: null),
-                           expressionBody),
-                       semicolonToken);
+            var updateDeclaration = WithSemicolonToken(
+                WithExpressionBody(
+                    WithBody(declaration, body: null),
+                    expressionBody),
+                semicolonToken);
+
+            return TransferTrailingCommentsToAfterExpressionBody(updateDeclaration);
         }
         else
         {
             return WithSemicolonToken(
-                       WithExpressionBody(
-                           WithGenerateBody(semanticModel, declaration),
-                           expressionBody: null),
-                       default);
+                WithExpressionBody(
+                    WithGenerateBody(semanticModel, declaration),
+                    expressionBody: null),
+                default);
         }
     }
 
+    private TDeclaration TransferTrailingCommentsToAfterExpressionBody(TDeclaration declaration)
+    {
+        var expressionBody = GetExpressionBody(declaration);
+
+        // Don't need to transfer if we don't have an expression body, or it already has leading trivia (like comments).
+        // Those will already be formatted and placed properly.   We only want to transfer comments that were conceptually
+        // at the end of the property/method/etc. header before and should stay that way after becoming single line.
+        if (expressionBody == null)
+            return declaration;
+
+        if (expressionBody.GetLeadingTrivia().Any(t => t.IsRegularComment()))
+            return declaration;
+
+        var previousToken = expressionBody.GetFirstToken().GetPreviousToken();
+        var trailingTrivia = previousToken.TrailingTrivia;
+        var lastComment = trailingTrivia.LastOrDefault(t => t.IsRegularComment());
+        if (lastComment == default)
+            return declaration;
+
+        return declaration
+            .ReplaceToken(previousToken, previousToken.WithTrailingTrivia(Space))
+            .WithTrailingTrivia(trailingTrivia.Take(trailingTrivia.IndexOf(lastComment) + 1).Concat(declaration.GetTrailingTrivia()));
+    }
+
     protected abstract BlockSyntax? GetBody(TDeclaration declaration);
 
     protected abstract ArrowExpressionClauseSyntax? GetExpressionBody(TDeclaration declaration);

src/Analyzers/CSharp/Tests/GenerateMethod/GenerateConversionTests.cs

@@ -125,7 +125,7 @@ class C
                 public static implicit operator C(int v) => throw new NotImplementedException();
             }
             """,
-options: Option(CSharpCodeStyleOptions.PreferExpressionBodiedOperators, CSharpCodeStyleOptions.WhenPossibleWithSilentEnforcement));
+            options: Option(CSharpCodeStyleOptions.PreferExpressionBodiedOperators, CSharpCodeStyleOptions.WhenPossibleWithSilentEnforcement));
 
     [Fact, WorkItem("http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/774321")]
     public Task TestGenerateImplicitConversionAwaitExpression()

src/Analyzers/CSharp/Tests/MakeLocalFunctionStatic/MakeLocalFunctionStaticTests.cs

@@ -290,25 +290,25 @@ bool otherFunction()
                 }
             }
             """,
-$$"""
-using System;
+            $$"""
+            using System;
 
-class C
-{
-    void M()
-    {
-        bool otherFunction()
-        {
-            return true;
-        }{{leadingTrivia}}
-        static int fibonacci(int n)
-        {
-            return n <= 1 ? n : fibonacci(n - 1) + fibonacci(n - 2);
-        }
-    }
-}
-""",
-parseOptions: CSharp8ParseOptions);
+            class C
+            {
+                void M()
+                {
+                    bool otherFunction()
+                    {
+                        return true;
+                    }{{leadingTrivia}}
+                    static int fibonacci(int n)
+                    {
+                        return n <= 1 ? n : fibonacci(n - 1) + fibonacci(n - 2);
+                    }
+                }
+            }
+            """,
+            parseOptions: CSharp8ParseOptions);
 
     [Theory, Trait(Traits.Feature, Traits.Features.CodeActionsMakeLocalFunctionStatic)]
     [InlineData("")]
@@ -328,19 +328,19 @@ void M()
                 }
             }
             """,
-$$"""
-using System;
+            $$"""
+            using System;
 
-class C
-{
-    void M()
-    {
-        bool otherFunction() => true;{{leadingTrivia}}
-        static int fibonacci(int n) => n <= 1 ? n : fibonacci(n - 1) + fibonacci(n - 2);
-    }
-}
-""",
-parseOptions: CSharp8ParseOptions);
+            class C
+            {
+                void M()
+                {
+                    bool otherFunction() => true;{{leadingTrivia}}
+                    static int fibonacci(int n) => n <= 1 ? n : fibonacci(n - 1) + fibonacci(n - 2);
+                }
+            }
+            """,
+            parseOptions: CSharp8ParseOptions);
 
     [Theory, Trait(Traits.Feature, Traits.Features.CodeActionsMakeLocalFunctionStatic)]
     [InlineData("")]
@@ -378,7 +378,7 @@ static int fibonacci(int n)
                 }
             }
             """,
-parseOptions: CSharp8ParseOptions);
+            parseOptions: CSharp8ParseOptions);
 
     [Theory, Trait(Traits.Feature, Traits.Features.CodeActionsMakeLocalFunctionStatic)]
     [InlineData("\r\n")]
@@ -415,7 +415,7 @@ static int fibonacci(int n)
                 }
             }
             """,
-parseOptions: CSharp8ParseOptions);
+            parseOptions: CSharp8ParseOptions);
 
     [Fact, Trait(Traits.Feature, Traits.Features.CodeActionsMakeLocalFunctionStatic)]
     [WorkItem("https://github.com/dotnet/roslyn/issues/46858")]

src/Analyzers/CSharp/Tests/MakeStructMemberReadOnly/MakeStructMemberReadOnlyTests.cs

@@ -2345,4 +2345,33 @@ public int Z
             LanguageVersion = LanguageVersion.CSharp12,
             ReferenceAssemblies = ReferenceAssemblies.Net.Net80,
         }.RunAsync();
+
+    [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/79384")]
+    public Task TestSpanFromInlineArray()
+        => new VerifyCS.Test
+        {
+            TestCode = """
+                using System.Runtime.CompilerServices;
+
+                public struct Example
+                {
+                    private Buffer _buffer;
+
+                    public void Set(int index, int value)
+                    {
+                        var bufferSpan = _buffer[..0];
+
+                        bufferSpan[0] = value;
+                    }
+                }
+
+                [InlineArray(1)]
+                public struct Buffer
+                {
+                    private int _element0;
+                }
+                """,
+            LanguageVersion = LanguageVersion.CSharp13,
+            ReferenceAssemblies = ReferenceAssemblies.Net.Net90,
+        }.RunAsync();
 }

src/Analyzers/CSharp/Tests/RemoveUnusedParametersAndValues/RemoveUnusedValueAssignmentTests.cs

@@ -5819,26 +5819,26 @@ int M(bool flag)
                 int M3() => 0;
             }
             """,
-    $$"""
-    class C
-    {
-        int M(bool flag)
-        {
-            int x;
-            if ({{condition}})
-            {
-            }
-            else
-            {
-            }
+            $$"""
+                class C
+                {
+                    int M(bool flag)
+                    {
+                        int x;
+                        if ({{condition}})
+                        {
+                        }
+                        else
+                        {
+                        }
 
-            return x;
-        }
+                        return x;
+                    }
 
-        bool M2(out int x) { x = 0; return true; }
-        int M3() => 0;
-    }
-    """);
+                    bool M2(out int x) { x = 0; return true; }
+                    int M3() => 0;
+                }
+                """);
 
     [Theory]
     [InlineData(nameof(PreferDiscard))]

src/Analyzers/CSharp/Tests/UseAutoProperty/UseAutoPropertyTests.cs

@@ -102,6 +102,32 @@ record Class
             }
             """, new TestParameters(TestOptions.RegularPreview));
 
+    [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/76813")]
+    public Task TestSingleGetterFromField_CommentBeforeField()
+        => TestInRegularAndScript1Async(
+            """
+            class Class
+            {
+                // Comment to preserve
+                [|int i|];
+
+                int P
+                {
+                    get
+                    {
+                        return i;
+                    }
+                }
+            }
+            """,
+            """
+            class Class
+            {
+                // Comment to preserve
+                int P { get; }
+            }
+            """);
+
     [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/28511")]
     public Task TestNullable1()
         => TestMissingInRegularAndScriptAsync(
@@ -215,6 +241,39 @@ class Class
             struct MutableInt { public int Value; }
             """);
 
+    [Theory, WorkItem("https://github.com/dotnet/roslyn/issues/76815")]
+    [InlineData("DateTime")]
+    [InlineData("ArraySegment<int>")]
+    [InlineData("DateTimeOffset")]
+    [InlineData("Guid")]
+    [InlineData("Index")]
+    [InlineData("Range")]
+    [InlineData("ReadOnlyMemory<int>")]
+    [InlineData("ReadOnlySpan<int>")]
+    [InlineData("TimeSpan")]
+    public Task TestWellKnownImmutableValueType1(string typeName)
+        => TestInRegularAndScript1Async(
+            $$"""
+            class Class
+            {
+                [|System.{{typeName}} i|];
+
+                System.{{typeName}} P
+                {
+                    get
+                    {
+                        return i;
+                    }
+                }
+            }
+            """,
+            $$"""
+            class Class
+            {
+                System.{{typeName}} P { get; }
+            }
+            """);
+
     [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/28511")]
     public Task TestMutableValueType1()
         => TestMissingInRegularAndScriptAsync(