Move to .NET 10 Preview 5 (#78906)

* Move to .NET 10 Preview 5

* Lint response

* Lint response

* Lint response

* Lint response

* Lint response

* remove unused method

* Lint response

* Lint response

* fix compiler side

* more

---------

Co-authored-by: Cyrus Najmabadi <[email protected]>

Author: jaredpar

eng/targets/Settings.props

@@ -15,7 +15,7 @@
     <NoWarn>$(NoWarn);VSIXCompatibility1001</NoWarn>
 
     <!-- TODO: https://github.com/dotnet/roslyn/issues/71667 -->
-    <NoWarn>$(NoWarn);NU1507</NoWarn>
+    <NoWarn>$(NoWarn);NU1507;NU1510</NoWarn>
 
     <CommonExtensionInstallationRoot>CommonExtensions</CommonExtensionInstallationRoot>
     <LanguageServicesExtensionInstallationFolder>Microsoft\VBCSharp\LanguageServices</LanguageServicesExtensionInstallationFolder>

global.json

@@ -1,13 +1,13 @@
 {
   "sdk": {
-    "version": "9.0.106",
+    "version": "10.0.100-preview.5.25277.114",
     "allowPrerelease": false,
     "rollForward": "patch"
   },
   "tools": {
-    "dotnet": "9.0.106",
+    "dotnet": "10.0.100-preview.5.25277.114",
     "vs": {
-      "version": "17.8.0"
+      "version": "17.14.0"
     },
     "vswhere": "3.1.7"
   },

src/Analyzers/Core/Analyzers/Helpers/HashCodeAnalyzer/HashCodeAnalyzer.cs

@@ -16,17 +16,15 @@ namespace Microsoft.CodeAnalysis.Shared.Utilities;
 /// </summary>
 internal readonly partial struct HashCodeAnalyzer
 {
-    private readonly Compilation _compilation;
     private readonly IMethodSymbol _objectGetHashCodeMethod;
     private readonly INamedTypeSymbol? _equalityComparerType;
 
     public readonly INamedTypeSymbol SystemHashCodeType;
 
     private HashCodeAnalyzer(
-        Compilation compilation, IMethodSymbol objectGetHashCodeMethod,
+        IMethodSymbol objectGetHashCodeMethod,
         INamedTypeSymbol? equalityComparerType, INamedTypeSymbol systemHashCodeType)
     {
-        _compilation = compilation;
         _objectGetHashCodeMethod = objectGetHashCodeMethod;
         _equalityComparerType = equalityComparerType;
         SystemHashCodeType = systemHashCodeType;
@@ -47,7 +45,7 @@ public static bool TryGetAnalyzer(Compilation compilation, [NotNullWhen(true)] o
         if (systemHashCodeType == null)
             return false;
 
-        analyzer = new HashCodeAnalyzer(compilation, objectGetHashCodeMethod, equalityComparerType, systemHashCodeType);
+        analyzer = new HashCodeAnalyzer(objectGetHashCodeMethod, equalityComparerType, systemHashCodeType);
         return true;
     }
 

src/Compilers/.editorconfig

@@ -12,6 +12,9 @@ dotnet_diagnostic.RS0100.severity = none
 # RS0102: Braces must not have blank lines between them
 dotnet_diagnostic.RS0102.severity = none
 
+# IDE0051: Unused member
+dotnet_diagnostic.IDE0051.severity = none
+
 # IDE0170: Prefer extended property pattern
 dotnet_diagnostic.IDE0170.severity = suggestion
 

src/Compilers/CSharp/Portable/Parser/LanguageParser_Patterns.cs

@@ -47,7 +47,7 @@ when ConvertExpressionToType(expr, out var leftType):
                 default:
                     type = null;
                     return false;
-            };
+            }
         }
 
         private PatternSyntax ParsePattern(Precedence precedence, bool afterIs = false, bool inSwitchArmPattern = false)

src/Compilers/CSharp/Portable/Parser/Lexer_RawStringLiteral.cs

@@ -117,7 +117,7 @@ private void ScanRawStringLiteral(ref TokenInfo info, bool inDirective)
 
                     default:
                         throw ExceptionUtilities.UnexpectedValue(info.Kind);
-                };
+                }
             }
 
             info.Text = TextWindow.GetText(intern: true);

src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenOverridingAndHiding.cs

@@ -4126,7 +4126,7 @@ static void Main()
                 if (isFromMetadata)
                 {
                     VerifyParamArrayAttribute(parameterB);
-                };
+                }
             };
 
             var verifier = CompileAndVerify(source, symbolValidator: validator(true), sourceSymbolValidator: validator(false), expectedOutput: @"System.Int32[]");

src/Compilers/CSharp/Test/Emit/CodeGen/WinMdDelegateTests.cs

@@ -41,7 +41,7 @@ public void SimpleDelegateMembersTest(string ob, string cb)
                         GetMember<NamedTypeSymbol>("voidDelegate").GetMembers().ToArray();
 
                     AssertEx.SetEqual(actualMembers.Select(s => s.Name), expectedMembers);
-                };
+                }
             };
 
             VerifyType verify = (winmd, expected) =>

src/Compilers/CSharp/Test/Emit3/Attributes/AttributeTests_IsByRefLike.cs

@@ -683,7 +683,7 @@ void validate(ModuleSymbol module)
                     AssertDeclaresType(peModule, WellKnownType.System_Runtime_CompilerServices_IsByRefLikeAttribute, Accessibility.Public);
                     AssertHasCompilerFeatureRequired(includeCompilerFeatureRequired, peType, peModule, new MetadataDecoder(peModule));
                 }
-            };
+            }
 
             CompileAndVerify(new[] { text, GetCompilerFeatureRequiredAttributeText(includeCompilerFeatureRequired) }, verify: Verification.Passes, symbolValidator: validate, sourceSymbolValidator: validate);
         }

src/Compilers/CSharp/Test/Emit3/Attributes/AttributeTests_WellKnownAttributes.cs

@@ -5752,7 +5752,7 @@ void metadataValidator(ModuleSymbol module)
 
                 Assert.Equal(new[] { "CompilerGeneratedAttribute" }, GetAttributeNames(method.GetAttributes()));
                 Assert.True(method.RequiresSecurityObject);
-            };
+            }
 
             var verifier = CompileAndVerify(
                 source,