True fire-and-forget

Author: davidwengier

src/EditorFeatures/Core/LanguageServer/AlwaysActiveLanguageClientEventListener.cs

@@ -73,7 +73,6 @@ private void Load()
 
         async Task LoadAsync()
         {
-
             // Explicitly switch to the bg so that if this causes any expensive work (like mef loads) it 
             // doesn't block the UI thread. Note, we always yield because sometimes our caller starts
             // on the threadpool thread but is indirectly blocked on by the UI thread.
@@ -90,13 +89,10 @@ await _languageClientBroker.Value.LoadAsync(new LanguageClientMetadata(
 
     private void Unload()
     {
-        using var token = _asynchronousOperationListener.BeginAsyncOperation(nameof(Unload));
-        UnloadAsync().ReportNonFatalErrorAsync().CompletesAsyncOperation(token);
-
-        async Task UnloadAsync()
-        {
-            await _languageClient.StopServerAsync().ConfigureAwait(false);
-        }
+        // We just want to signal that an unload should happen, in case the above call to Load comes in quick.
+        // We don't want to wait for it to complete, not do we care about errors that may occur during the unload.
+        // The language client/server does its own error reporting as necessary.
+        _languageClient.StopServerAsync().Forget();
     }
 
     /// <summary>