Skip to content

Commit 088f162

Browse files
authored
[wasm] Fix performance-setup.sh to track change in BDN (#92067)
* [wasm] Fix performance-setup.sh to track change in BDN `dotnet/performance` got an update for `dotnet/BenchmarkDotNet` via dotnet/performance#3331 . And that bdn update includes dotnet/BenchmarkDotNet#2375, which subtly changes how the arguments get parsed, and breaks the existing scripts: ``` $ pushd "/home/helixbot/work/B807097D/w/AED609DF/e/performance/artifacts/bin/for-running/MicroBenchmarks" $ dotnet exec MicroBenchmarks.dll --wasmArgs "--experimental-wasm-eh --expose_wasm --module" ... MicroBenchmarks 1.0.0-dev © Microsoft Corporation. All rights reserved. ERROR(S): Option 'experimental-wasm-eh --expose_wasm --module' is unknown. ``` Fixes #92066 . * fix command line
1 parent 650eec9 commit 088f162

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

eng/testing/performance/performance-setup.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -430,7 +430,7 @@ if [[ -n "$wasm_bundle_directory" ]]; then
430430
fi
431431

432432
# Workaround: escaping the quotes around `--wasmArgs=..` so they get retained for the actual command line
433-
extra_benchmark_dotnet_arguments="$extra_benchmark_dotnet_arguments --wasmEngine $javascript_engine_path --wasmArgs \\\"$wasm_args\\\" --cli \$HELIX_CORRELATION_PAYLOAD/dotnet/dotnet --wasmDataDir \$HELIX_CORRELATION_PAYLOAD/wasm-data"
433+
extra_benchmark_dotnet_arguments="$extra_benchmark_dotnet_arguments --wasmEngine $javascript_engine_path \\\"--wasmArgs=$wasm_args\\\" --cli \$HELIX_CORRELATION_PAYLOAD/dotnet/dotnet --wasmDataDir \$HELIX_CORRELATION_PAYLOAD/wasm-data"
434434
if [[ "$wasmaot" == "true" ]]; then
435435
extra_benchmark_dotnet_arguments="$extra_benchmark_dotnet_arguments --aotcompilermode wasm --buildTimeout 3600"
436436
fi

0 commit comments

Comments
 (0)