Allow the Roslyn client to log messages from Razor #8201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
force-pushed
the
CohostLogging
branch
from
87bef33 to
b34da5f
Compare
dibarbet
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a custom endpoint for Razor logging within the VS Code extension, called from https://github.com/dotnet/razor/pull/11748/files#diff-21aece6ecf41ca0eb514d9afac87294819df187e10f9b04f9d58d0fc577b9e8cR52, so that Razor logs end up in the "Razor Log" output pane like they should.
Wanted to put this up separately because a) we're going to need to add a lot more endpoints over time, so getting sign-off and set up on the method (ie, the razorEndpoints file) and b) passing the razor logger everywhere doesn't feel great so hoping someone will tell me "use a lazy singleton for this like <foo.ts>" :)