Skip to content

Commit 9596404

Browse files
mshymonfacebook-github-bot
authored andcommitted
Remove UI of a checkbox that controls enablement of the new style feed generation. (#3056)
Summary: ## Description As of now there is a switch in UI that controls enablement of the new style feed generation. The plan is to remove this from the UI, while we will still respect the value that was set. We are planning for the new style of feed generation to be additionally tested and then rolled out via a Gatekeeper to insure consistent feed generation across all sellers. We are removing this from the UI since this is exposing an internal infra change and there will be no need for seller to be aware or have a control over it. The control was removed from both old and new plugin page UX. ### Type of change Please delete options that are not relevant. - New feature (non-breaking change which adds functionality) ## Checklist - [] I have commented my code, particularly in hard-to-understand areas. - [] I have confirmed that my changes do not introduce any new PHPCS warnings or errors. - [] I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors. - [] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)). - [] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes. - [] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. - [] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this [wiki]([url](https://fburl.com/wiki/nhx73tgs)). ## Changelog entry One liner entry to be surfaced in changelog.txt Pull Request resolved: #3056 Test Plan: Was manually tested, screenshots provided below. ## Screenshots Please provide screenshots or snapshots of the system/state both before and after implementing the changes, if appropriate ### Before <img width="1277" alt="Screenshot 2025-04-14 at 15 37 02" src="https://github.com/user-attachments/assets/6f00e56c-1313-432f-9a2e-41adef32a39f" /> ### After The UI control has been removed: <img width="1481" alt="Screenshot 2025-04-14 at 15 32 03" src="https://github.com/user-attachments/assets/284c138a-dce8-4c8a-95ae-c9b257c1601b" /> Reviewed By: ajello-meta, vinkmeta Differential Revision: D72970938 Pulled By: mshymon fbshipit-source-id: 3ada315d22168a0cd0c8ff3723351898052a97e0
1 parent f13b86f commit 9596404

File tree

4 files changed

+0
-29
lines changed

4 files changed

+0
-29
lines changed

includes/Admin/Settings_Screens/Connection.php

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -467,15 +467,6 @@ public function get_settings() {
467467
'default' => 'no',
468468
),
469469

470-
array(
471-
'id' => \WC_Facebookcommerce_Integration::SETTING_ENABLE_NEW_STYLE_FEED_GENERATOR,
472-
'title' => __( 'Experimental! Enable new style feed generation', 'facebook-for-woocommerce' ),
473-
'type' => 'checkbox',
474-
'desc' => __( 'Use new, memory improved, feed generation process.', 'facebook-for-woocommerce' ),
475-
/* translators: %s URL to the documentation page. */
476-
'desc_tip' => sprintf( __( 'This is an experimental feature in testing phase. Only enable this if you are experiencing problems with feed generation. <a href="%s" target="_blank">Learn more</a>.', 'facebook-for-woocommerce' ), 'https://woocommerce.com/document/facebook-for-woocommerce/#feed-generation' ),
477-
'default' => 'no',
478-
),
479470
array( 'type' => 'sectionend' ),
480471
);
481472
}

includes/Admin/Settings_Screens/Shops.php

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -299,16 +299,6 @@ public function get_settings() {
299299
'default' => 'no',
300300
),
301301

302-
array(
303-
'id' => \WC_Facebookcommerce_Integration::SETTING_ENABLE_NEW_STYLE_FEED_GENERATOR,
304-
'title' => __( '[Experimental] Use new, memory improved, feed generation process', 'facebook-for-woocommerce' ),
305-
'type' => 'checkbox',
306-
'desc' => __( 'Enable', 'facebook-for-woocommerce' ),
307-
/* translators: %s URL to the documentation page. */
308-
'desc_tip' => sprintf( __( 'This is an experimental feature in testing phase. Only enable this if you are experiencing problems with feed generation. <a href="%s" target="_blank">Learn more</a>.', 'facebook-for-woocommerce' ), 'https://woocommerce.com/document/facebook-for-woocommerce/#feed-generation' ),
309-
'default' => 'no',
310-
),
311-
312302
array( 'type' => 'sectionend' ),
313303
);
314304
}

tests/Unit/Admin/Settings/ConnectionTest.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,5 @@ public function testGetSettings(): void {
4747
$debug_setting = $settings[2];
4848
$this->assertEquals('checkbox', $debug_setting['type']);
4949
$this->assertEquals('no', $debug_setting['default']);
50-
51-
// Check feed generator setting
52-
$feed_setting = $settings[3];
53-
$this->assertEquals('checkbox', $feed_setting['type']);
54-
$this->assertEquals('no', $feed_setting['default']);
5550
}
5651
}

tests/Unit/Admin/Settings/ShopsTest.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,5 @@ public function testGetSettings(): void {
6161
$debug_setting = $settings[2];
6262
$this->assertEquals('checkbox', $debug_setting['type']);
6363
$this->assertEquals('no', $debug_setting['default']);
64-
65-
// Check feed generator setting
66-
$feed_setting = $settings[3];
67-
$this->assertEquals('checkbox', $feed_setting['type']);
68-
$this->assertEquals('no', $feed_setting['default']);
6964
}
7065
}

0 commit comments

Comments
 (0)