Skip to content

Commit ff9c8cd

Browse files
JoshuaGrossfacebook-github-bot
authored andcommitted
Downgrade warning about non-clippable views being clipped to no-crash exception
Summary: This is crashing too much in debug, which is good signal but making it harder to test, and test unrelated features. We have some good data about this internally and validated that it's useful; we can follow up on the logged soft exceptions without actually crashing now. Changelog: [Internal] Differential Revision: D29698447 fbshipit-source-id: 61387c18f17f76e5de60baa1fd3c94028229c0f6
1 parent f00e348 commit ff9c8cd

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import com.facebook.common.logging.FLog;
3030
import com.facebook.infer.annotation.Assertions;
3131
import com.facebook.react.bridge.ReactContext;
32+
import com.facebook.react.bridge.ReactNoCrashSoftException;
3233
import com.facebook.react.bridge.ReactSoftException;
3334
import com.facebook.react.bridge.UiThreadUtil;
3435
import com.facebook.react.common.annotations.VisibleForTesting;
@@ -575,7 +576,7 @@ public void run() {
575576
if (!child.isShown()) {
576577
ReactSoftException.logSoftException(
577578
TAG,
578-
new IllegalViewOperationException(
579+
new ReactNoCrashSoftException(
579580
"Child view has been added to Parent view in which it is clipped and not visible."
580581
+ " This is not legal for this particular child view. Child: ["
581582
+ child.getId()

0 commit comments

Comments
 (0)