Add enableRefAsProp feature flag

Adding a flag for this so it can be rolled out incrementally at Meta.

Author: acdlite

packages/shared/ReactFeatureFlags.js

@@ -178,6 +178,13 @@ export const enableServerComponentKeys = __NEXT_MAJOR__;
  */
 export const enableInfiniteRenderLoopDetection = true;
 
+// Subtle breaking changes to JSX runtime to make it faster, like passing `ref`
+// as a normal prop instead of stripping it from the props object.
+
+// Passes `ref` as a normal prop instead of stripping it from the props object
+// during element creation.
+export const enableRefAsProp = __NEXT_MAJOR__;
+
 // -----------------------------------------------------------------------------
 // Chopping Block
 //

packages/shared/forks/ReactFeatureFlags.native-fb.js

@@ -97,5 +97,9 @@ export const disableClientCache = true;
 export const enableServerComponentKeys = true;
 export const enableInfiniteRenderLoopDetection = false;
 
+// TODO: Roll out with GK. Don't keep as dynamic flag for too long, though,
+// because JSX is an extremely hot path.
+export const enableRefAsProp = false;
+
 // Flow magic to verify the exports of this file match the original version.
 ((((null: any): ExportsType): FeatureFlagsType): ExportsType);

packages/shared/forks/ReactFeatureFlags.native-oss.js

@@ -89,5 +89,8 @@ export const disableClientCache = true;
 
 export const enableServerComponentKeys = true;
 
+// TODO: Should turn this on in next "major" RN release.
+export const enableRefAsProp = false;
+
 // Flow magic to verify the exports of this file match the original version.
 ((((null: any): ExportsType): FeatureFlagsType): ExportsType);

packages/shared/forks/ReactFeatureFlags.test-renderer.js

@@ -89,5 +89,14 @@ export const disableClientCache = true;
 export const enableServerComponentKeys = true;
 export const enableInfiniteRenderLoopDetection = false;
 
+// TODO: This must be in sync with the main ReactFeatureFlags file because
+// the Test Renderer's value must be the same as the one used by the
+// react package.
+//
+// We really need to get rid of this whole module. Any test renderer specific
+// flags should be handled by the Fiber config.
+const __NEXT_MAJOR__ = __EXPERIMENTAL__;
+export const enableRefAsProp = __NEXT_MAJOR__;
+
 // Flow magic to verify the exports of this file match the original version.
 ((((null: any): ExportsType): FeatureFlagsType): ExportsType);

packages/shared/forks/ReactFeatureFlags.test-renderer.native.js

@@ -86,5 +86,7 @@ export const disableClientCache = true;
 
 export const enableServerComponentKeys = true;
 
+export const enableRefAsProp = false;
+
 // Flow magic to verify the exports of this file match the original version.
 ((((null: any): ExportsType): FeatureFlagsType): ExportsType);

packages/shared/forks/ReactFeatureFlags.test-renderer.www.js

@@ -89,5 +89,7 @@ export const disableClientCache = true;
 export const enableServerComponentKeys = true;
 export const enableInfiniteRenderLoopDetection = false;
 
+export const enableRefAsProp = false;
+
 // Flow magic to verify the exports of this file match the original version.
 ((((null: any): ExportsType): FeatureFlagsType): ExportsType);

packages/shared/forks/ReactFeatureFlags.www.js

@@ -116,5 +116,9 @@ export const disableClientCache = true;
 
 export const enableServerComponentKeys = true;
 
+// TODO: Roll out with GK. Don't keep as dynamic flag for too long, though,
+// because JSX is an extremely hot path.
+export const enableRefAsProp = false;
+
 // Flow magic to verify the exports of this file match the original version.
 ((((null: any): ExportsType): FeatureFlagsType): ExportsType);