Skip to content

Commit 8aa59d1

Browse files
committed
[Fizz] Don't handle errors in completeBoundary instruction (#33073)
Stacked on #33066 and #33068. Currently we're passing `errorDigest` to `completeBoundary` if there is a client side error (only CSS loading atm). This only exists because of `completeBoundaryWithStyles`. Normally if there's a server-side error we'd emit the `clientRenderBoundary` instruction instead. This adds unnecessary code to the common case where all styles are in the head. This is about to get worse with batching because client render shouldn't be throttled but complete should be. The first commit moves the client render logic inline into `completeBoundaryWithStyles` so we only pay for it when styles are used. However, the approach I went with in the second commit is to reuse the `$RX` instruction instead (`clientRenderBoundary`). That way if you have both it ends up being amortized. However, it does mean we have to emit the `$RX` (along with the `$RC` helper if any `completeBoundaryWithStyles` instruction is needed. DiffTrain build for [ee077b6](ee077b6)
1 parent bef10cc commit 8aa59d1

37 files changed

+249
-227
lines changed

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
bb57fa7351776a86448c1a094bea8108fd6b34ff
1+
ee077b6ccddd916440bb7570ba6f53673d920700
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
bb57fa7351776a86448c1a094bea8108fd6b34ff
1+
ee077b6ccddd916440bb7570ba6f53673d920700

compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1538,7 +1538,7 @@ __DEV__ &&
15381538
exports.useTransition = function () {
15391539
return resolveDispatcher().useTransition();
15401540
};
1541-
exports.version = "19.2.0-www-classic-bb57fa73-20250501";
1541+
exports.version = "19.2.0-www-classic-ee077b6c-20250501";
15421542
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
15431543
"function" ===
15441544
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1538,7 +1538,7 @@ __DEV__ &&
15381538
exports.useTransition = function () {
15391539
return resolveDispatcher().useTransition();
15401540
};
1541-
exports.version = "19.2.0-www-modern-bb57fa73-20250501";
1541+
exports.version = "19.2.0-www-modern-ee077b6c-20250501";
15421542
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
15431543
"function" ===
15441544
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -636,4 +636,4 @@ exports.useSyncExternalStore = function (
636636
exports.useTransition = function () {
637637
return ReactSharedInternals.H.useTransition();
638638
};
639-
exports.version = "19.2.0-www-classic-bb57fa73-20250501";
639+
exports.version = "19.2.0-www-classic-ee077b6c-20250501";

compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -636,4 +636,4 @@ exports.useSyncExternalStore = function (
636636
exports.useTransition = function () {
637637
return ReactSharedInternals.H.useTransition();
638638
};
639-
exports.version = "19.2.0-www-modern-bb57fa73-20250501";
639+
exports.version = "19.2.0-www-modern-ee077b6c-20250501";

compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -640,7 +640,7 @@ exports.useSyncExternalStore = function (
640640
exports.useTransition = function () {
641641
return ReactSharedInternals.H.useTransition();
642642
};
643-
exports.version = "19.2.0-www-classic-bb57fa73-20250501";
643+
exports.version = "19.2.0-www-classic-ee077b6c-20250501";
644644
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
645645
"function" ===
646646
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -640,7 +640,7 @@ exports.useSyncExternalStore = function (
640640
exports.useTransition = function () {
641641
return ReactSharedInternals.H.useTransition();
642642
};
643-
exports.version = "19.2.0-www-modern-bb57fa73-20250501";
643+
exports.version = "19.2.0-www-modern-ee077b6c-20250501";
644644
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
645645
"function" ===
646646
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19014,10 +19014,10 @@ __DEV__ &&
1901419014
(function () {
1901519015
var internals = {
1901619016
bundleType: 1,
19017-
version: "19.2.0-www-classic-bb57fa73-20250501",
19017+
version: "19.2.0-www-classic-ee077b6c-20250501",
1901819018
rendererPackageName: "react-art",
1901919019
currentDispatcherRef: ReactSharedInternals,
19020-
reconcilerVersion: "19.2.0-www-classic-bb57fa73-20250501"
19020+
reconcilerVersion: "19.2.0-www-classic-ee077b6c-20250501"
1902119021
};
1902219022
internals.overrideHookState = overrideHookState;
1902319023
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -19051,7 +19051,7 @@ __DEV__ &&
1905119051
exports.Shape = Shape;
1905219052
exports.Surface = Surface;
1905319053
exports.Text = Text;
19054-
exports.version = "19.2.0-www-classic-bb57fa73-20250501";
19054+
exports.version = "19.2.0-www-classic-ee077b6c-20250501";
1905519055
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1905619056
"function" ===
1905719057
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18786,10 +18786,10 @@ __DEV__ &&
1878618786
(function () {
1878718787
var internals = {
1878818788
bundleType: 1,
18789-
version: "19.2.0-www-modern-bb57fa73-20250501",
18789+
version: "19.2.0-www-modern-ee077b6c-20250501",
1879018790
rendererPackageName: "react-art",
1879118791
currentDispatcherRef: ReactSharedInternals,
18792-
reconcilerVersion: "19.2.0-www-modern-bb57fa73-20250501"
18792+
reconcilerVersion: "19.2.0-www-modern-ee077b6c-20250501"
1879318793
};
1879418794
internals.overrideHookState = overrideHookState;
1879518795
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -18823,7 +18823,7 @@ __DEV__ &&
1882318823
exports.Shape = Shape;
1882418824
exports.Surface = Surface;
1882518825
exports.Text = Text;
18826-
exports.version = "19.2.0-www-modern-bb57fa73-20250501";
18826+
exports.version = "19.2.0-www-modern-ee077b6c-20250501";
1882718827
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1882818828
"function" ===
1882918829
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)