Skip to content

Commit de6b3f9

Browse files
author
Varun Rathore
committed
fix lint
1 parent 6964acb commit de6b3f9

File tree

4 files changed

+17
-19
lines changed

4 files changed

+17
-19
lines changed

src/commands/remoteconfig-rollouts-delete.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,20 @@ import { Command } from "../command";
22
import { Options } from "../options";
33
import { requireAuth } from "../requireAuth";
44
import { requirePermissions } from "../requirePermissions";
5-
import * as clc from "colorette";
65
import { logger } from "../logger";
76
import { needProjectNumber } from "../projectUtils";
87
import { NAMESPACE_FIREBASE } from "../remoteconfig/interfaces";
98
import * as rcRollout from "../remoteconfig/deleteRollout";
109
import { getRollout, parseRolloutIntoTable } from "../remoteconfig/getRollout";
11-
import { FirebaseError } from "../error";
1210
import { confirm } from "../prompt";
1311

1412
export const command = new Command("remoteconfig:rollouts:delete [rolloutId]")
1513
.description("delete a Remote Config rollout.")
1614
.before(requireAuth)
17-
.before(requirePermissions, ["cloudconfigs.config.update", "firebaseanalytics.resources.googleAnalyticsEdit"])
15+
.before(requirePermissions, [
16+
"cloud.configs.update",
17+
"firebaseanalytics.resources.googleAnalyticsEdit",
18+
])
1819
.action(async (rolloutId: string, options: Options) => {
1920
const projectNumber: string = await needProjectNumber(options);
2021
const rollout = await getRollout(projectNumber, NAMESPACE_FIREBASE, rolloutId);

src/commands/remoteconfig-rollouts-get.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import { logger } from "../logger";
66
import { needProjectNumber } from "../projectUtils";
77
import { RemoteConfigRollout, NAMESPACE_FIREBASE } from "../remoteconfig/interfaces";
88
import * as rcRollout from "../remoteconfig/getRollout";
9-
import { FirebaseError } from "../error";
109

1110
export const command = new Command("remoteconfig:rollouts:get [rolloutId]")
1211
.description("get a Remote Config rollout")

src/commands/remoteconfig-rollouts-list.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import {
1111
DEFAULT_PAGE_SIZE,
1212
} from "../remoteconfig/interfaces";
1313
import * as rcRollout from "../remoteconfig/listRollouts";
14-
import { FirebaseError } from "../error";
1514

1615
export const command = new Command("remoteconfig:rollouts:list")
1716
.description("get a list of Remote Config rollouts.")

src/remoteconfig/deleteRollout.spec.ts

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -26,22 +26,21 @@ describe("Remote Config Rollout Delete", () => {
2626
});
2727

2828
it("should throw FirebaseError if rollout is running", async () => {
29-
const errorMessage = `Rollout ${ROLLOUT_ID} is currently running and cannot be deleted. If you want to delete this rollout, stop it at https://console.firebase.google.com/project/${PROJECT_ID}/config/env/firebase/rollout/${ROLLOUT_ID}`;
30-
nock(remoteConfigApiOrigin())
31-
.delete(
32-
`/v1/projects/${PROJECT_ID}/namespaces/${NAMESPACE_FIREBASE}/rollouts/${ROLLOUT_ID}`,
33-
)
34-
.reply(400, {
35-
error: {
36-
message: errorMessage,
37-
},
38-
});
39-
40-
await expect(
41-
deleteRollout(PROJECT_ID, NAMESPACE_FIREBASE, ROLLOUT_ID),
42-
).to.be.rejectedWith(FirebaseError, errorMessage);
29+
const errorMessage = `Rollout ${ROLLOUT_ID} is currently running and cannot be deleted. If you want to delete this rollout, stop it at https://console.firebase.google.com/project/${PROJECT_ID}/config/env/firebase/rollout/${ROLLOUT_ID}`;
30+
nock(remoteConfigApiOrigin())
31+
.delete(`/v1/projects/${PROJECT_ID}/namespaces/${NAMESPACE_FIREBASE}/rollouts/${ROLLOUT_ID}`)
32+
.reply(400, {
33+
error: {
34+
message: errorMessage,
35+
},
4336
});
4437

38+
await expect(deleteRollout(PROJECT_ID, NAMESPACE_FIREBASE, ROLLOUT_ID)).to.be.rejectedWith(
39+
FirebaseError,
40+
errorMessage,
41+
);
42+
});
43+
4544
it("should throw FirebaseError if an internal error occurred", async () => {
4645
nock(remoteConfigApiOrigin())
4746
.delete(`/v1/projects/${PROJECT_ID}/namespaces/${NAMESPACE_FIREBASE}/rollouts/${ROLLOUT_ID}`)

0 commit comments

Comments
 (0)