quic_trace: full client support #6352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhinvasara-jumptrading
requested review from
nbridge-jump and
ripatel-fd
as code owners
akhinvasara-jumptrading
force-pushed
the
akhin/quic_trace_send
branch
from
a34728e to
5cae487
Compare
| @@ -355,11 +348,11 @@ fd_quic_trace_1rtt( fd_quic_trace_ctx_t * trace_ctx, | |||
| "\"flow\": \"%s\", " | |||
| "\"trace_time\": \"%s\", " | |||
| "\"src_ip_addr\": \"" FD_IP4_ADDR_FMT "\", " | |||
| "\"src_udp_port\": %u, " | |||
| "\"src_udp_port\": \"%u\", " | |||
There was a problem hiding this comment.
These are numbers. Why wrap them in quotes?
There was a problem hiding this comment.
to make this lowly err msg consistent with the presumably 'correct' version in fd_quic_pretty_print_quic_pkt
do you think I should change them both to leave off the quotes?
There was a problem hiding this comment.
I didn't realize another was different. This is fine. I might take a look to make everything follow the same policy. But for now, at least this makes them consistent.
nbridge-jump
requested changes
Sep 15, 2025
akhinvasara-jumptrading
force-pushed
the
akhin/quic_trace_send
branch
from
5cae487 to
cc894a3
Compare
nbridge-jump
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends quic_trace for the full client (particularly send_tile). It simplifies the rebasing logic and fixes various quic_trace bugs.