Skip to content

Commit 0bec9cc

Browse files
authored
ref(metrics): Disable span metrics (#4931)
We migrated all parts of the frontend using span metrics to querying the EAP. We do not need to collect them anymore.
1 parent b790bc2 commit 0bec9cc

15 files changed

+929
-20082
lines changed

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
# Changelog
22

3+
4+
## Unreleased
5+
6+
**Internal**:
7+
8+
- Disable span metrics. ([#4931](https://github.com/getsentry/relay/pull/4931))
9+
310
## 25.7.0
411

512
**Features**:

relay-dynamic-config/src/defaults.rs

Lines changed: 196 additions & 1108 deletions
Large diffs are not rendered by default.

relay-dynamic-config/src/feature.rs

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -80,16 +80,6 @@ pub enum Feature {
8080
/// Serialized as `organizations:continuous-profiling-beta-ingest`.
8181
#[serde(rename = "organizations:continuous-profiling-beta-ingest")]
8282
ContinuousProfilingBetaIngest,
83-
/// Enables metric extraction from spans for common modules.
84-
///
85-
/// Serialized as `projects:span-metrics-extraction`.
86-
#[serde(rename = "projects:span-metrics-extraction")]
87-
ExtractCommonSpanMetricsFromEvent,
88-
/// Enables metric extraction from spans for addon modules.
89-
///
90-
/// Serialized as `projects:span-metrics-extraction-addons`.
91-
#[serde(rename = "projects:span-metrics-extraction-addons")]
92-
ExtractAddonsSpanMetricsFromEvent,
9383
/// When enabled, spans will be extracted from a transaction.
9484
///
9585
/// Serialized as `organizations:indexed-spans-extraction`.
@@ -124,6 +114,14 @@ pub enum Feature {
124114
/// Detect performance issues in the new standalone spans pipeline instead of on transactions.
125115
#[serde(rename = "organizations:performance-issues-spans")]
126116
PerformanceIssuesSpans,
117+
/// This feature has deprecated and is kept for external Relays.
118+
#[doc(hidden)]
119+
#[serde(rename = "projects:span-metrics-extraction")]
120+
DeprecatedExtractCommonSpanMetricsFromEvent,
121+
/// This feature has been deprecated and is kept for external Relays.
122+
#[doc(hidden)]
123+
#[serde(rename = "projects:span-metrics-extraction-addons")]
124+
DeprecatedExtractAddonsSpanMetricsFromEvent,
127125
/// Forward compatibility.
128126
#[doc(hidden)]
129127
#[serde(other)]
@@ -147,9 +145,7 @@ impl FeatureSet {
147145

148146
/// Returns `true` if any spans are produced for this project.
149147
pub fn produces_spans(&self) -> bool {
150-
self.has(Feature::ExtractSpansFromEvent)
151-
|| self.has(Feature::StandaloneSpanIngestion)
152-
|| self.has(Feature::ExtractCommonSpanMetricsFromEvent)
148+
self.has(Feature::ExtractSpansFromEvent) || self.has(Feature::StandaloneSpanIngestion)
153149
}
154150
}
155151

relay-dynamic-config/src/global.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,8 +161,7 @@ pub struct Options {
161161
/// Overall sampling of span extraction.
162162
///
163163
/// This number represents the fraction of transactions for which
164-
/// spans are extracted. It applies on top of [`crate::Feature::ExtractCommonSpanMetricsFromEvent`],
165-
/// so both feature flag and sample rate need to be enabled to get any spans extracted.
164+
/// spans are extracted.
166165
///
167166
/// `None` is the default and interpreted as a value of 1.0 (extract everything).
168167
///

0 commit comments

Comments
 (0)