Skip to content

Commit 1cd32b5

Browse files
committed
ref(ourlogs): Stop ingesting sentry.trace_flags
1 parent 6dc8511 commit 1cd32b5

File tree

4 files changed

+1
-24
lines changed

4 files changed

+1
-24
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
- Deprecate old AI monitoring attributes. ([#4960](https://github.com/getsentry/relay/pull/4960))
1515
- Normalize legacy `ai.*` attributes to `gen_ai.*` names. ([#4924](https://github.com/getsentry/relay/pull/4924))
1616
- Force the routing key to be random instead of letting Kafka handle the randomization. ([#4974](https://github.com/getsentry/relay/pull/4974))
17+
- Stop extracting the `sentry.trace_flags` attribute for logs. ([#4988](https://github.com/getsentry/relay/pull/4988))
1718
- Add Jwm to the supported image types. ([#4975](https://github.com/getsentry/relay/pull/4975))
1819

1920
## 25.7.0

relay-event-schema/src/protocol/ourlog.rs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -171,10 +171,6 @@ mod tests {
171171
"sentry.observed_timestamp_nanos": {
172172
"value": "1544712660300000000",
173173
"type": "integer"
174-
},
175-
"sentry.trace_flags": {
176-
"value": "10",
177-
"type": "integer"
178174
}
179175
}
180176
}"#;
@@ -209,10 +205,6 @@ mod tests {
209205
"type": "string",
210206
"value": "info"
211207
},
212-
"sentry.trace_flags": {
213-
"type": "integer",
214-
"value": "10"
215-
},
216208
"string.attribute": {
217209
"type": "string",
218210
"value": "some string"

relay-ourlogs/src/ourlog.rs

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ pub fn otel_to_sentry_log(otel_log: OtelLog, received_at: DateTime<Utc>) -> Resu
6363
"sentry.observed_timestamp_nanos".to_owned(),
6464
received_at_nanos.to_string(),
6565
);
66-
attribute_data.insert("sentry.trace_flags".to_owned(), 0);
6766
attribute_data.insert("sentry.body".to_owned(), body.clone());
6867
attribute_data.insert("sentry.span_id".to_owned(), span_id.to_string());
6968

@@ -150,7 +149,6 @@ pub fn ourlog_merge_otel(ourlog: &mut Annotated<OurLog>, received_at: DateTime<U
150149
"sentry.observed_timestamp_nanos".to_owned(),
151150
received_at_nanos.to_string(),
152151
);
153-
attributes.insert("sentry.trace_flags".to_owned(), 0);
154152
attributes.insert(
155153
"sentry.body".to_owned(),
156154
ourlog_value.body.value().cloned().unwrap_or_default(),
@@ -468,10 +466,6 @@ mod tests {
468466
"sentry.timestamp_precise": {
469467
"type": "integer",
470468
"value": 946684800000000000
471-
},
472-
"sentry.trace_flags": {
473-
"type": "integer",
474-
"value": 0
475469
}
476470
}
477471
}
@@ -561,10 +555,6 @@ mod tests {
561555
"sentry.timestamp_precise": {
562556
"type": "integer",
563557
"value": 1638144000000000000
564-
},
565-
"sentry.trace_flags": {
566-
"type": "integer",
567-
"value": 0
568558
}
569559
}
570560
}

tests/integration/test_ourlogs.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,6 @@ def test_ourlog_extraction_with_otel_logs(
117117
"sentry.severity_number": {"intValue": "10"},
118118
"sentry.severity_text": {"stringValue": "Information"},
119119
"sentry.span_id": {"stringValue": "eee19b7ec3c1b174"},
120-
"sentry.trace_flags": {"intValue": "0"},
121120
"string.attribute": {"stringValue": "some string"},
122121
**timestamps(ts),
123122
},
@@ -248,7 +247,6 @@ def test_ourlog_meta_attributes(
248247
"sentry.severity_number": {"intValue": "17"},
249248
"sentry.severity_text": {"stringValue": "error"},
250249
"sentry.span_id": {"stringValue": "eee19b7ec3c1b175"},
251-
"sentry.trace_flags": {"intValue": "0"},
252250
**timestamps(ts),
253251
**(
254252
{
@@ -338,7 +336,6 @@ def test_ourlog_extraction_with_sentry_logs(
338336
"sentry.severity_number": {"intValue": "17"},
339337
"sentry.severity_text": {"stringValue": "error"},
340338
"sentry.span_id": {"stringValue": "eee19b7ec3c1b175"},
341-
"sentry.trace_flags": {"intValue": "0"},
342339
**timestamps(ts),
343340
},
344341
"clientSampleRate": 1.0,
@@ -366,7 +363,6 @@ def test_ourlog_extraction_with_sentry_logs(
366363
"sentry.severity_number": {"intValue": "9"},
367364
"sentry.severity_text": {"stringValue": "info"},
368365
"sentry.span_id": {"stringValue": "eee19b7ec3c1b174"},
369-
"sentry.trace_flags": {"intValue": "0"},
370366
"string.attribute": {"stringValue": "some string"},
371367
"valid_string_with_other": {"stringValue": "test"},
372368
**timestamps(ts),
@@ -439,7 +435,6 @@ def test_ourlog_extraction_with_sentry_logs_with_missing_fields(
439435
"sentry.browser.version": {"stringValue": "2.32"},
440436
"sentry.severity_number": {"intValue": "13"},
441437
"sentry.severity_text": {"stringValue": "warn"},
442-
"sentry.trace_flags": {"intValue": "0"},
443438
**timestamps(ts),
444439
},
445440
"clientSampleRate": 1.0,
@@ -567,7 +562,6 @@ def test_browser_name_version_extraction(
567562
"sentry.severity_number": {"intValue": "17"},
568563
"sentry.severity_text": {"stringValue": "error"},
569564
"sentry.span_id": {"stringValue": "eee19b7ec3c1b175"},
570-
"sentry.trace_flags": {"intValue": "0"},
571565
**timestamps(ts),
572566
},
573567
"clientSampleRate": 1.0,

0 commit comments

Comments
 (0)