Skip to content

Commit e07ac0b

Browse files
authored
feat(eap): Push to snuba-items by default (#5055)
1 parent 7958273 commit e07ac0b

File tree

4 files changed

+17
-3
lines changed

4 files changed

+17
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
- Process logs in all non-proxy Relays. ([#4973](https://github.com/getsentry/relay/pull/4973))
3434
- Add support for pre-hashed signatures. ([#5012](https://github.com/getsentry/relay/pull/5012))
3535
- Add producer_name tag, and more rdkafka stats. ([#5031](https://github.com/getsentry/relay/pull/5031))
36+
- Change the default configuration to produce to `snuba-items`. ([#5055](https://github.com/getsentry/relay/pull/5055))
3637

3738
## 25.7.0
3839

relay-config/src/config.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1223,8 +1223,8 @@ pub struct SpanProducers {
12231223
impl Default for SpanProducers {
12241224
fn default() -> Self {
12251225
Self {
1226-
produce_json: true,
1227-
produce_protobuf: false,
1226+
produce_json: false,
1227+
produce_protobuf: true,
12281228
}
12291229
}
12301230
}

tests/integration/fixtures/processing.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,12 @@ def inner(options=None):
7878
f"relay-test-relayconfig-{uuid.uuid4()}"
7979
)
8080

81+
if processing.get("span_producers") is None:
82+
processing["span_producers"] = {
83+
"produce_json": True,
84+
"produce_protobuf": False,
85+
}
86+
8187
return options
8288

8389
return inner

tests/integration/test_spans.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,16 @@
2020
from .consts import (
2121
TRANSACTION_EXTRACT_MIN_SUPPORTED_VERSION,
2222
)
23-
from .test_metrics import TEST_CONFIG
2423
from .test_store import make_transaction
2524

25+
TEST_CONFIG = {
26+
"aggregator": {
27+
"bucket_interval": 1,
28+
"initial_delay": 0,
29+
"shift_key": "none",
30+
}
31+
}
32+
2633

2734
@pytest.mark.parametrize("performance_issues_spans", [False, True])
2835
@pytest.mark.parametrize("discard_transaction", [False, True])

0 commit comments

Comments
 (0)