Java: Address review comment. Improve getAnImportedType definition

IdrissRio · IdrissRio · commit ed9ed439237b · 2025-09-06T12:38:44.000+02:00
diff --git a/java/ql/lib/semmle/code/java/Import.qll b/java/ql/lib/semmle/code/java/Import.qll
@@ -179,13 +179,8 @@ class ModuleImportDeclaration extends Import {
     )
   }
 
-  /** Gets a type that is imported from the module. */
-  RefType getAnImportedType() {
-    exists(Package pkg |
-      pkg = this.getAnImportedPackage() and
-      result.getPackage() = pkg
-    )
-  }
+  /** Gets a type from a package that is accessible through this module import. */
+  RefType getAnImportedType() { result.getPackage() = this.getAnImportedPackage() }
 
   override string toString() { result = "import module " + this.getModuleName() }
 

Original file line number	Diff line number	Diff line change
`@@ -179,13 +179,8 @@ class ModuleImportDeclaration extends Import {`
`179`	`179`	`)`
`180`	`180`	`}`
`181`	`181`
`182`		`- /** Gets a type that is imported from the module. */`
`183`		`- RefType getAnImportedType() {`
`184`		`- exists(Package pkg \|`
`185`		`- pkg = this.getAnImportedPackage() and`
`186`		`- result.getPackage() = pkg`
`187`		`- )`
`188`		`- }`
	`182`	`+ /** Gets a type from a package that is accessible through this module import. */`
	`183`	`+ RefType getAnImportedType() { result.getPackage() = this.getAnImportedPackage() }`
`189`	`184`
`190`	`185`	`override string toString() { result = "import module " + this.getModuleName() }`
`191`	`186`