From 5c90b908cdace044b84e7dd45099c67ec028a057 Mon Sep 17 00:00:00 2001 From: Geoffrey White <40627776+geoffw0@users.noreply.github.com> Date: Thu, 28 Aug 2025 13:55:20 +0100 Subject: [PATCH 1/2] Rust: Lower the thresholds in rust/diagnostic/database-quality to more pragmatic numbers. --- rust/ql/src/queries/telemetry/DatabaseQualityDiagnostics.ql | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/rust/ql/src/queries/telemetry/DatabaseQualityDiagnostics.ql b/rust/ql/src/queries/telemetry/DatabaseQualityDiagnostics.ql index c5e3645e993e..18e7445939f9 100644 --- a/rust/ql/src/queries/telemetry/DatabaseQualityDiagnostics.ql +++ b/rust/ql/src/queries/telemetry/DatabaseQualityDiagnostics.ql @@ -12,11 +12,9 @@ import codeql.util.Unit class DbQualityDiagnostic extends Unit { DbQualityDiagnostic() { exists(float percentageGood | - CallTargetStatsReport::percentageOfOk(_, percentageGood) + CallTargetStatsReport::percentageOfOk(_, percentageGood) and percentageGood < 50 or - MacroCallTargetStatsReport::percentageOfOk(_, percentageGood) - | - percentageGood < 95 + MacroCallTargetStatsReport::percentageOfOk(_, percentageGood) and percentageGood < 50 ) } From 9e0a31cafcb7aefd843eb5ce0126d15d969cecc0 Mon Sep 17 00:00:00 2001 From: Geoffrey White <40627776+geoffw0@users.noreply.github.com> Date: Thu, 28 Aug 2025 14:00:45 +0100 Subject: [PATCH 2/2] Rust: Change note. --- .../change-notes/2025-08-28-diagnostic-database-quality.md | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 rust/ql/src/change-notes/2025-08-28-diagnostic-database-quality.md diff --git a/rust/ql/src/change-notes/2025-08-28-diagnostic-database-quality.md b/rust/ql/src/change-notes/2025-08-28-diagnostic-database-quality.md new file mode 100644 index 000000000000..0aeb9d52d273 --- /dev/null +++ b/rust/ql/src/change-notes/2025-08-28-diagnostic-database-quality.md @@ -0,0 +1,4 @@ +--- +category: fix +--- +* The "Low Rust analysis quality" query (`rust/diagnostic/database-quality`) has been tuned so that it won't trigger on databases that have extracted normally. This will remove spurious messages of "Low Rust analysis quality" on the CodeQL status page.