test cleanup

Author: timvaillancourt

go/logic/migrator.go

@@ -902,38 +902,13 @@ func (this *Migrator) printMigrationStatusHint(writers ...io.Writer) {
 	}
 }
 
-// shouldPrintStatus returns true when the migrator is due to print status info.
-func (this *Migrator) shouldPrintStatus(rule PrintStatusRule, elapsedSeconds int64, etaDuration time.Duration) (shouldPrint bool) {
-	if rule != HeuristicPrintStatusRule {
-		return true
-	}
-
-	etaSeconds := etaDuration.Seconds()
-	if elapsedSeconds <= 60 {
-		shouldPrint = true
-	} else if etaSeconds <= 60 {
-		shouldPrint = true
-	} else if etaSeconds <= 180 {
-		shouldPrint = (elapsedSeconds%5 == 0)
-	} else if elapsedSeconds <= 180 {
-		shouldPrint = (elapsedSeconds%5 == 0)
-	} else if this.migrationContext.TimeSincePointOfInterest().Seconds() <= 60 {
-		shouldPrint = (elapsedSeconds%5 == 0)
-	} else {
-		shouldPrint = (elapsedSeconds%30 == 0)
-	}
-
-	return shouldPrint
-}
-
-// shouldPrintMigrationStatus returns true when the migrator is due to print the migration status hint
-func (this *Migrator) shouldPrintMigrationStatusHint(rule PrintStatusRule, elapsedSeconds int64) (shouldPrint bool) {
-	if elapsedSeconds%600 == 0 {
-		shouldPrint = true
-	} else if rule == ForcePrintStatusAndHintRule {
-		shouldPrint = true
+// getProgressPercent returns an estimate of migration progess as a percent.
+func (this *Migrator) getProgressPercent(rowsEstimate int64) (progressPct float64) {
+	progressPct = 100.0
+	if rowsEstimate > 0 {
+		progressPct *= float64(this.migrationContext.GetTotalRowsCopied()) / float64(rowsEstimate)
 	}
-	return shouldPrint
+	return progressPct
 }
 
 // getMigrationETA returns the estimated duration of the migration
@@ -981,13 +956,38 @@ func (this *Migrator) getMigrationStateAndETA(rowsEstimate int64) (state, eta st
 	return state, eta, etaDuration
 }
 
-// getProgressPercent returns an estimate of migration progess as a percent.
-func (this *Migrator) getProgressPercent(rowsEstimate int64) (progressPct float64) {
-	progressPct = 100.0
-	if rowsEstimate > 0 {
-		progressPct *= float64(this.migrationContext.GetTotalRowsCopied()) / float64(rowsEstimate)
+// shouldPrintStatus returns true when the migrator is due to print status info.
+func (this *Migrator) shouldPrintStatus(rule PrintStatusRule, elapsedSeconds int64, etaDuration time.Duration) (shouldPrint bool) {
+	if rule != HeuristicPrintStatusRule {
+		return true
 	}
-	return progressPct
+
+	etaSeconds := etaDuration.Seconds()
+	if elapsedSeconds <= 60 {
+		shouldPrint = true
+	} else if etaSeconds <= 60 {
+		shouldPrint = true
+	} else if etaSeconds <= 180 {
+		shouldPrint = (elapsedSeconds%5 == 0)
+	} else if elapsedSeconds <= 180 {
+		shouldPrint = (elapsedSeconds%5 == 0)
+	} else if this.migrationContext.TimeSincePointOfInterest().Seconds() <= 60 {
+		shouldPrint = (elapsedSeconds%5 == 0)
+	} else {
+		shouldPrint = (elapsedSeconds%30 == 0)
+	}
+
+	return shouldPrint
+}
+
+// shouldPrintMigrationStatus returns true when the migrator is due to print the migration status hint
+func (this *Migrator) shouldPrintMigrationStatusHint(rule PrintStatusRule, elapsedSeconds int64) (shouldPrint bool) {
+	if elapsedSeconds%600 == 0 {
+		shouldPrint = true
+	} else if rule == ForcePrintStatusAndHintRule {
+		shouldPrint = true
+	}
+	return shouldPrint
 }
 
 // printStatus prints the progress status, and optionally additionally detailed