modify ColumnList creation

meiji163 · meiji163 · commit c0cbfd15e8e4 · 2024-12-18T15:39:33.000-08:00
diff --git a/go/sql/types.go b/go/sql/types.go
@@ -246,16 +246,13 @@ func (this *ColumnList) IsSubsetOf(other *ColumnList) bool {
 }
 
 func (this *ColumnList) FilterBy(f func(Column) bool) *ColumnList {
-	filteredList := &ColumnList{}
-	filteredList.Ordinals = this.Ordinals
-	filteredCols := []Column{}
+	filteredCols := make([]Column, 0, len(this.columns))
 	for _, column := range this.columns {
 		if f(column) {
 			filteredCols = append(filteredCols, column)
 		}
 	}
-	filteredList.columns = filteredCols
-	return filteredList
+	return &ColumnList{Ordinals: this.Ordinals, columns: filteredCols}
 }
 
 func (this *ColumnList) Len() int {

Original file line number	Diff line number	Diff line change
`@@ -246,16 +246,13 @@ func (this ColumnList) IsSubsetOf(other ColumnList) bool {`
`246`	`246`	`}`
`247`	`247`
`248`	`248`	`func (this ColumnList) FilterBy(f func(Column) bool) ColumnList {`
`249`		`- filteredList := &ColumnList{}`
`250`		`- filteredList.Ordinals = this.Ordinals`
`251`		`- filteredCols := []Column{}`
	`249`	`+ filteredCols := make([]Column, 0, len(this.columns))`
`252`	`250`	`for _, column := range this.columns {`
`253`	`251`	`if f(column) {`
`254`	`252`	`filteredCols = append(filteredCols, column)`
`255`	`253`	`}`
`256`	`254`	`}`
`257`		`- filteredList.columns = filteredCols`
`258`		`- return filteredList`
	`255`	`+ return &ColumnList{Ordinals: this.Ordinals, columns: filteredCols}`
`259`	`256`	`}`
`260`	`257`
`261`	`258`	`func (this *ColumnList) Len() int {`