Fix string matching for PanicOnWarnings to correctly suppress warnings when renaming unique keys

grodowski · grodowski · commit fe68db42f147 · 2025-03-25T09:30:58.000+01:00
Error message formats are different across mysql distributions and versions
diff --git a/go/logic/applier.go b/go/logic/applier.go
@@ -778,7 +778,7 @@ func (this *Applier) ApplyIterationInsertQuery() (chunkSize int64, rowsAffected
 					continue
 				}
 				migrationUniqueKeySuffix := fmt.Sprintf("for key '%s.%s'", this.migrationContext.GetGhostTableName(), this.migrationContext.UniqueKey.NameInGhostTable)
-				if strings.HasPrefix(message, "Duplicate entry") && strings.HasSuffix(message, migrationUniqueKeySuffix) {
+				if strings.Contains(message, "Duplicate entry") && strings.Contains(message, migrationUniqueKeySuffix) {
 					continue
 				}
 				sqlWarnings = append(sqlWarnings, fmt.Sprintf("%s: %s (%d)", level, message, code))

Original file line number	Diff line number	Diff line change
`@@ -778,7 +778,7 @@ func (this *Applier) ApplyIterationInsertQuery() (chunkSize int64, rowsAffected`
`778`	`778`	`continue`
`779`	`779`	`}`
`780`	`780`	`migrationUniqueKeySuffix := fmt.Sprintf("for key '%s.%s'", this.migrationContext.GetGhostTableName(), this.migrationContext.UniqueKey.NameInGhostTable)`
`781`		`- if strings.HasPrefix(message, "Duplicate entry") && strings.HasSuffix(message, migrationUniqueKeySuffix) {`
	`781`	`+ if strings.Contains(message, "Duplicate entry") && strings.Contains(message, migrationUniqueKeySuffix) {`
`782`	`782`	`continue`
`783`	`783`	`}`
`784`	`784`	`sqlWarnings = append(sqlWarnings, fmt.Sprintf("%s: %s (%d)", level, message, code))`