Skip to content

Commit 79c26b4

Browse files
authored
Remove support for CodeQL CLI versions older than v2.19.4 (#4108)
1 parent abdf905 commit 79c26b4

File tree

4 files changed

+2
-8
lines changed

4 files changed

+2
-8
lines changed

extensions/ql-vscode/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## [UNRELEASED]
44

55
- Add new command "CodeQL: Trim Overlay Base Cache" that returns a database to the state prior to overlay evaluation, leaving only base predicates and types that may later be referenced during overlay evaluation. [#4082](https://github.com/github/vscode-codeql/pull/4082)
6+
- Remove support for CodeQL CLI versions older than 2.19.4. [#4108](https://github.com/github/vscode-codeql/pull/4108)
67

78
## 1.17.4 - 10 July 2025
89

extensions/ql-vscode/src/codeql-cli/cli.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1902,7 +1902,7 @@ function shouldDebugCliServer() {
19021902
export class CliVersionConstraint {
19031903
// The oldest version of the CLI that we support. This is used to determine
19041904
// whether to show a warning about the CLI being too old on startup.
1905-
public static OLDEST_SUPPORTED_CLI_VERSION = new SemVer("2.18.4");
1905+
public static OLDEST_SUPPORTED_CLI_VERSION = new SemVer("2.19.4");
19061906

19071907
constructor(private readonly cli: CodeQLCliServer) {
19081908
/**/

extensions/ql-vscode/supported_cli_versions.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,5 @@
33
"v2.21.4",
44
"v2.20.7",
55
"v2.19.4",
6-
"v2.18.4",
76
"nightly"
87
]

extensions/ql-vscode/test/vscode-tests/cli-integration/debugger/debugger.test.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -157,12 +157,6 @@ describeWithCodeQL()("Debugger", () => {
157157

158158
it("should run a quick evaluation with a bigint-valued result column", async () => {
159159
await withDebugController(appCommands, async (controller) => {
160-
const semver = await cli.getVersion();
161-
if (semver.compare("2.18.4") < 0) {
162-
// Skip this test if the CLI version is too old to support BigInt
163-
return;
164-
}
165-
166160
await selectForQuickEval(quickEvalBigIntQueryPath, 4, 23, 4, 37);
167161

168162
// Don't specify a query path, so we'll default to the active document ("QuickEvalBigIntQuery.ql")

0 commit comments

Comments
 (0)