selectelv2: some of the required options are not set #2638
Description
Welcome
- Yes, I'm using a binary release within 2 latest releases.
- Yes, I've searched similar issues on GitHub and didn't find any.
- Yes, I've included all information below (version, config, etc).
What did you expect to see?
When I run DNS challenge with Select v2 provider I expect to see somthing like this:
l[some.example.domain] acme: Obtaining bundled SAN certificate
[some.example.domain] AuthURL: https://acme-v02.api.letsencrypt.org/acme/authz/2645193031/580043416161
[some.example.domain] acme: use dns-01 solver
[some.example.domain] acme: Preparing to solve DNS-01
acme: Trying to solve DNS-01
[some.example.domain]acme: Checking DNS record propagation. [nameservers=127.0.0.11:53]
Wait for propagation [timeout: 1h0m0s, interval: 10m0s]
[some.example.domain] The server validated our request
[some.example.domain] acme: Cleaning DNS-01 challenge
[some.example.domain] acme: Validations succeeded; requesting certificates
[some.example.domain] Server responded with a certificate.
What did you see instead?
After PR #2523 in v4.24 I suppose the DNS challenge for Selectel v2 provider was broken (see logs).
I suppose the reason in this commit in the go-selvpcclient: they made this options required, but they are not passed in ClientOptions() func in this file.
How do you use lego?
Docker image
Reproduction steps
- Install lego goacme/lego:v4.24 or higer.
- Run command lego --dns=selectelv2 --domains=some.example.domain --accept-tos run
Effective version of lego
lego version 4.23.1 linux/amd64Logs
11:00:18 [INFO] [*.some.example.domain.com] acme: Obtaining bundled SAN certificate
11:00:19 [INFO] [*.some.example.domain.com] AuthURL: https://acme-v02.api.letsencrypt.org/acme/authz/2645170821/580042096151
11:00:19 [INFO] [*.some.example.domain.com] acme: use dns-01 solver
11:00:19 [INFO] [*.some.example.domain.com] acme: Preparing to solve DNS-01
11:00:19 [INFO] [*.some.example.domain.com] acme: Cleaning DNS-01 challenge
11:00:19 [WARN] [*.some.example.domain.com] acme: cleaning up failed: selectelv2: authorize: new VPC client: validation error: some of the required options are not set: DomainName, AuthURL, AuthRegion
11:00:19 [INFO] Deactivating auth: https://acme-v02.api.letsencrypt.org/acme/authz/2645170821/580042096151
11:00:20 Could not obtain certificates:
error: one or more domains had a problem:
| [*.some.example.domain.com] [*.some.example.domain.com] acme: error presenting token: selectelv2: authorize: new VPC client: validation error: some of the required options are not set: DomainName, AuthURL, AuthRegionGo environment (if applicable)
$ go version && go env
# paste output here