clean up project metadata for tag retention policy after deletion

Signed-off-by: my036811 <[email protected]>

Author: MinerYang

src/controller/retention/controller.go

@@ -29,6 +29,7 @@ import (
 	"github.com/goharbor/harbor/src/lib/retry"
 	"github.com/goharbor/harbor/src/pkg"
 	"github.com/goharbor/harbor/src/pkg/project"
+	"github.com/goharbor/harbor/src/pkg/project/metadata"
 	"github.com/goharbor/harbor/src/pkg/repository"
 	"github.com/goharbor/harbor/src/pkg/retention"
 	"github.com/goharbor/harbor/src/pkg/retention/policy"
@@ -80,14 +81,16 @@ type defaultController struct {
 	launcher       retention.Launcher
 	projectManager project.Manager
 	repositoryMgr  repository.Manager
+	projectMetaMgr metadata.Manager
 	scheduler      scheduler.Scheduler
 	wp             *lib.WorkerPool
 }
 
 const (
 	// SchedulerCallback ...
-	SchedulerCallback   = "RETENTION"
-	schedulerVendorType = job.RetentionVendorType
+	SchedulerCallback      = "RETENTION"
+	schedulerVendorType    = job.RetentionVendorType
+	retentionPolicyMetaKey = "retention_id"
 )
 
 // TriggerParam ...
@@ -214,6 +217,7 @@ func (r *defaultController) DeleteRetention(ctx context.Context, id int64) error
 	if err != nil {
 		return err
 	}
+
 	return r.manager.DeletePolicy(ctx, id)
 }
 
@@ -459,6 +463,7 @@ func NewController() Controller {
 		launcher:       retentionLauncher,
 		projectManager: pkg.ProjectMgr,
 		repositoryMgr:  pkg.RepositoryMgr,
+		projectMetaMgr: pkg.ProjectMetaMgr,
 		scheduler:      scheduler.Sched,
 		wp:             lib.NewWorkerPool(10),
 	}

src/server/v2.0/handler/retention.go

@@ -260,6 +260,10 @@ func (r *retentionAPI) DeleteRetention(ctx context.Context, params operation.Del
 	if err = r.retentionCtl.DeleteRetention(ctx, params.ID); err != nil {
 		return r.SendError(ctx, err)
 	}
+	// delete retention data in project_metadata
+	if err := r.proMetaMgr.Delete(ctx, p.Scope.Reference, "retention_id"); err != nil {
+		return r.SendError(ctx, err)
+	}
 	return operation.NewDeleteRetentionOK()
 }