gotip: fix panic for no arguments

dvrkps · odeke-em · commit 2d68e8288cc0 · 2020-05-18T05:49:59.000Z
Fixes: golang/go#39099 Change-Id: If89740a3913f489b058af177b340dde82c0738e9 Reviewed-on: https://go-review.googlesource.com/c/dl/+/234158 Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
diff --git a/gotip/main.go b/gotip/main.go
@@ -37,7 +37,7 @@ func main() {
 		log.Fatalf("gotip: %v", err)
 	}
 
-	if os.Args[1] == "download" {
+	if len(os.Args) > 1 && os.Args[1] == "download" {
 		switch len(os.Args) {
 		case 2:
 			if err := installTip(root, ""); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ func main() {`
`37`	`37`	`log.Fatalf("gotip: %v", err)`
`38`	`38`	`}`
`39`	`39`
`40`		`- if os.Args[1] == "download" {`
	`40`	`+ if len(os.Args) > 1 && os.Args[1] == "download" {`
`41`	`41`	`switch len(os.Args) {`
`42`	`42`	`case 2:`
`43`	`43`	`if err := installTip(root, ""); err != nil {`