sound-open-firmware: restore build, semantic fix and enable UBSAN (#12607)

Signed-off-by: Curtis Malainey <[email protected]>
Co-authored-by: Vitor Guidi <[email protected]>

Author: cujomalainey

projects/sound-open-firmware/Dockerfile

@@ -23,7 +23,20 @@ FROM gcr.io/oss-fuzz-base/base-builder
 # Base packages
 RUN apt-get -y update && apt-get -y install \
       gettext git libc6-dev-i386 libglib2.0-dev libncurses5-dev \
-      libtool ninja-build python3-pip
+      libtool ninja-build software-properties-common
+
+# Installing Python3.10 and using it instead of the default Python taken from the base-builder image
+# as Zephyr requires >=3.10 and base has 3.8
+RUN add-apt-repository ppa:deadsnakes/ppa && \
+    apt-get update && \
+    apt-get install -y python3.10 python3.10-distutils python3.10-venv && \
+    ln --force -s /usr/bin/python3.10 /usr/bin/python3
+
+# Ensure python that was just installed gets precedence over
+# the one already installed in /usr/local/bin
+ENV PATH="/usr/bin/:${PATH}"
+
+RUN python3 -m ensurepip --upgrade
 RUN python3 -m pip install --upgrade pip
 RUN pip3 install west
 
@@ -68,6 +81,6 @@ RUN cd $SRC; touch empty.c; gcc -m32 -c empty.c; ar rs /usr/lib32/libstdc++.a em
 # If a user is mounting their local source directory for debugging
 # then we need to tell git to chill out and just take the repo. If we
 # don't west fails with bogus error messages.
-RUN git config --global --add safe.directory /src/sof_workspace/zephyr
+RUN git config --global --add safe.directory $SRC/sof_workspace/zephyr
 
 COPY build.sh $SRC/

projects/sound-open-firmware/build.sh

@@ -32,8 +32,8 @@ unset CXXFLAGS
 
 cd $SRC/sof_workspace
 
-sof/scripts/fuzz.sh -b -- -DEXTRA_CONF_FILE=stub_build_all_ipc3.conf
+sof/scripts/fuzz.sh -b -s $SANITIZER -a $ARCHITECTURE -- -DEXTRA_CONF_FILE=stub_build_all_ipc3.conf -DEXTRA_CFLAGS="-fno-sanitize-recover=all"
 cp build-fuzz/zephyr/zephyr.exe $OUT/sof-ipc3
 
-sof/scripts/fuzz.sh -b -- -DEXTRA_CONF_FILE=stub_build_all_ipc4.conf
+sof/scripts/fuzz.sh -b -s $SANITIZER -a $ARCHITECTURE -- -DEXTRA_CONF_FILE=stub_build_all_ipc4.conf -DEXTRA_CFLAGS="-fno-sanitize-recover=all"
 cp build-fuzz/zephyr/zephyr.exe $OUT/sof-ipc4

projects/sound-open-firmware/fetch-sdk.sh

@@ -15,20 +15,13 @@
 #
 ################################################################################
 
-# Zephyr doesn't provide a "latest" link, so clone the source tree
-# that produces the SDK (much smaller than the tarball itself, so
-# minimal overhead) and find the latest version tag as a proxy.  Will
-# likely break if the script is run in the moments between tagging a
-# release and the tarball appearing on github, but the risk is low and
-# it will recover with a retry.
+# use the github API to fetch the latest stable SDK with assets
 
-git clone --filter=tree:0 https://github.com/zephyrproject-rtos/sdk-ng
+RELEASES=$(curl -L  -H "Accept: application/vnd.github+json"  -H "X-GitHub-Api-Version: 2022-11-28"  https://api.github.com/repos/zephyrproject-rtos/sdk-ng/releases)
+SDK=$(jq '[.[] | select(.prerelease == false) | {tag: .tag_name, assets: .assets[] | select(.name | contains("linux-x86_64_minimal.tar.xz"))}] | .[0]' <<< $RELEASES)
 
-VER=$(git -C sdk-ng tag -l 'v*' | sort -rV | head -1 | sed 's/v//')
-URL="https://github.com/zephyrproject-rtos/sdk-ng/releases/download/v$VER/zephyr-sdk-${VER}_linux-x86_64_minimal.tar.xz"
-
-curl -L -o sdk.tar.xz "$URL"
+curl -L -o sdk.tar.xz $(jq -r '.assets.browser_download_url' <<< $SDK)
 tar xf sdk.tar.xz
 rm sdk.tar.xz
 
-zephyr-sdk-$VER/setup.sh -h
+zephyr-sdk-$(jq -r ".tag" <<< $SDK | tr -d 'v')/setup.sh -h

projects/sound-open-firmware/project.yaml

@@ -15,6 +15,7 @@ fuzzing_engines:
   - libfuzzer
 sanitizers:
   - address
+  - undefined
 architectures:
   - i386
 main_repo: "https://github.com/thesofproject/sof"