Skip to content

fix: out-of-bounds datetime.date raises OutOfBoundsDatetime #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2023
Merged

fix: out-of-bounds datetime.date raises OutOfBoundsDatetime #180

merged 1 commit into from
Mar 30, 2023

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Mar 30, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes googleapis/python-bigquery-pandas#623
Fixes googleapis/python-bigquery-pandas#624
Fixes googleapis/python-bigquery-pandas#625
Fixes googleapis/python-bigquery-pandas#626
🦕

@tswast tswast requested review from a team as code owners March 30, 2023 17:47
@tswast tswast requested a review from jainsahab March 30, 2023 17:47
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. labels Mar 30, 2023
chalmerlowe
chalmerlowe approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswast tswast merged commit 4f3399e into main Mar 30, 2023
@tswast tswast deleted the issue623-626-pandas-2.0-flaky branch March 30, 2023 18:32
@release-please release-please bot mentioned this pull request Mar 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

@jainsahab jainsahab Awaiting requested review from jainsahab jainsahab is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
2 participants
@tswast @chalmerlowe