Skip to content

Commit 95ec94d

Browse files
committed
Add TODOs in Gulpfile
1 parent 71d62c6 commit 95ec94d

File tree

1 file changed

+14
-6
lines changed

1 file changed

+14
-6
lines changed

Gulpfile.js

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ const cmdLineOptions = require("./scripts/build/options");
2020
const copyright = "CopyrightNotice.txt";
2121
const cleanTasks = [];
2222

23+
const testRunner = "./built/local/testRunner/_namespaces/Harness.js"
24+
2325
const buildScripts = () => buildProject("scripts");
2426
task("scripts", buildScripts);
2527
task("scripts").description = "Builds files in the 'scripts' folder.";
@@ -125,6 +127,9 @@ const localPreBuild = parallel(generateLibs, series(buildScripts, generateDiagno
125127
const preBuild = cmdLineOptions.lkg ? lkgPreBuild : localPreBuild;
126128

127129
const buildServices = (() => {
130+
// TODO(jakebailey): fix this for modules
131+
return cb => { console.log("!!!TODO!!! buildServices"); cb(); };
132+
128133
// build typescriptServices.out.js
129134
const buildTypescriptServicesOut = () => buildProject("src/typescriptServices/tsconfig.json", cmdLineOptions);
130135

@@ -249,6 +254,9 @@ task("watch-min").flags = {
249254
};
250255

251256
const buildLssl = (() => {
257+
// TODO(jakebailey): fix this for modules
258+
return cb => { console.log("!!!TODO!!! buildLssl"); cb(); };
259+
252260
// build tsserverlibrary.out.js
253261
const buildServerLibraryOut = () => buildProject("src/tsserverlibrary/tsconfig.json", cmdLineOptions);
254262

@@ -442,8 +450,8 @@ preTest.displayName = "preTest";
442450

443451
const postTest = (done) => cmdLineOptions.lint ? lint(done) : done();
444452

445-
const runTests = () => runConsoleTests("built/local/run.js", "mocha-fivemat-progress-reporter", /*runInParallel*/ false, /*watchMode*/ false);
446-
task("runtests", series(preBuild, preTest, runTests, postTest));
453+
const runTests = () => runConsoleTests(testRunner, "mocha-fivemat-progress-reporter", /*runInParallel*/ false, /*watchMode*/ false);
454+
task("runtests", series(/*preBuild, preTest,*/ runTests /*, postTest*/)); // TODO(jakebailey): fix this for modules
447455
task("runtests").description = "Runs the tests using the built run.js file.";
448456
task("runtests").flags = {
449457
"-t --tests=<regex>": "Pattern for tests to run.",
@@ -462,8 +470,8 @@ task("runtests").flags = {
462470
" --shardId": "1-based ID of this shard (default: 1)",
463471
};
464472

465-
const runTestsParallel = () => runConsoleTests("built/local/run.js", "min", /*runInParallel*/ cmdLineOptions.workers > 1, /*watchMode*/ false);
466-
task("runtests-parallel", series(preBuild, preTest, runTestsParallel, postTest));
473+
const runTestsParallel = () => runConsoleTests(testRunner, "min", /*runInParallel*/ cmdLineOptions.workers > 1, /*watchMode*/ false);
474+
task("runtests-parallel", series(/*preBuild, preTest,*/ runTestsParallel /*, postTest*/)); // TODO(jakebailey): fix this for modules
467475
task("runtests-parallel").description = "Runs all the tests in parallel using the built run.js file.";
468476
task("runtests-parallel").flags = {
469477
" --no-lint": "disables lint.",
@@ -611,10 +619,10 @@ task("publish-nightly").description = "Runs `npm publish --tag next` to create a
611619
// write some kind of trigger file that indicates build completion that we could listen for instead.
612620
const watchRuntests = () => watch(["built/local/*.js", "tests/cases/**/*.ts", "tests/cases/**/tsconfig.json"], { delay: 5000 }, async () => {
613621
if (cmdLineOptions.tests || cmdLineOptions.failed) {
614-
await runConsoleTests("built/local/run.js", "mocha-fivemat-progress-reporter", /*runInParallel*/ false, /*watchMode*/ true);
622+
await runConsoleTests(testRunner, "mocha-fivemat-progress-reporter", /*runInParallel*/ false, /*watchMode*/ true);
615623
}
616624
else {
617-
await runConsoleTests("built/local/run.js", "min", /*runInParallel*/ true, /*watchMode*/ true);
625+
await runConsoleTests(testRunner, "min", /*runInParallel*/ true, /*watchMode*/ true);
618626
}
619627
});
620628
task("watch", series(preBuild, preTest, parallel(watchLib, watchDiagnostics, watchServices, watchLssl, watchTests, watchRuntests)));

0 commit comments

Comments
 (0)