Connector Sanity tests in CI/CD (#732)

Co-authored-by: Arjun Karthik <[email protected]>
Co-authored-by: Sanchith Hegde <[email protected]>

Author: 3 people

.github/secrets/connector_auth.toml.gpg

@@ -356,11 +356,7 @@ jobs:
       - name: Cargo hack storage_models
         if: env.storage_models_changes_exist == 'true'
         run: cargo hack check --each-feature --no-dev-deps -p storage_models
-
-      # - name: Run tests
-      #   shell: bash
-      #   run: cargo nextest run --all-features
-
+  
   typos:
     name: Spell check
     runs-on: ubuntu-latest

.github/workflows/CI.yml

@@ -0,0 +1,101 @@
+name: Connector Sanity Tests
+
+on:
+  push:
+    branches:
+      - main
+
+  pull_request:
+
+  schedule:
+    - cron: '5 0 * * *'
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+env:
+  # Disable incremental compilation.
+  #
+  # Incremental compilation is useful as part of an edit-build-test-edit cycle,
+  # as it lets the compiler avoid recompiling code that hasn't changed. However,
+  # on CI, we're not making small edits; we're almost always building the entire
+  # project from scratch. Thus, incremental compilation on CI actually
+  # introduces *additional* overhead to support making future builds
+  # faster...but no future builds will ever occur in any given CI environment.
+  #
+  # See https://matklad.github.io/2021/09/04/fast-rust-builds.html#ci-workflow
+  # for details.
+  CARGO_INCREMENTAL: 0
+  # Allow more retries for network requests in cargo (downloading crates) and
+  # rustup (installing toolchains). This should help to reduce flaky CI failures
+  # from transient network timeouts or other issues.
+  CARGO_NET_RETRY: 10
+  RUSTUP_MAX_RETRIES: 10
+  # Don't emit giant backtraces in the CI logs.
+  RUST_BACKTRACE: short
+  # Use cargo's sparse index protocol
+  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
+
+jobs:
+  test_connectors:
+    name: Run tests on stable toolchain for connectors
+    runs-on: ubuntu-latest
+    
+    services:
+      redis:
+        image: redis
+        options: >-
+          --health-cmd "redis-cli ping"
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 5
+        ports:
+          - 6379:6379
+
+    strategy:
+      fail-fast: false
+      matrix:
+        connector:
+          - stripe
+          - aci
+          - adyen
+          #- authorizedotnet 
+          #- checkout
+          #- cybersource
+          - shift4
+          #- worldpay
+          #- payu
+          #- globalpay
+          #- rapyd
+          #- fiserv
+          - worldline
+          #- multisafepay
+          - dlocal
+          #- bambora
+          #- nuvei
+
+    steps:
+      - name: Checkout repository
+        uses: actions/[email protected]
+      
+      - name: Install Rust
+        uses: dtolnay/rust-toolchain@master
+        with:
+          toolchain: stable
+
+      - uses: Swatinem/[email protected]
+
+      - name: Decrypt connector auth file
+        run: ./scripts/decrypt_connector_auth.sh
+        env:
+          CONNECTOR_AUTH_PASSPHRASE: ${{ secrets.CONNECTOR_AUTH_PASSPHRASE }}
+
+      - name: Set connector auth file path in env
+        run: echo "CONNECTOR_AUTH_FILE_PATH=$HOME/target/test/connector_auth.toml" >> $GITHUB_ENV
+
+      - name: Run connector tests
+        uses: actions-rs/cargo@v1
+        with:
+          command: test
+          args: --package router --test connectors -- ${{ matrix.connector }} --test-threads=1

.github/workflows/connector-sanity-tests.yml

@@ -1,3 +1,5 @@
+use std::env;
+
 use router::types::ConnectorAuthType;
 use serde::Deserialize;
 
@@ -27,11 +29,12 @@ pub(crate) struct ConnectorAuthentication {
 }
 
 impl ConnectorAuthentication {
+    #[allow(clippy::expect_used)]
     pub(crate) fn new() -> Self {
-        #[allow(clippy::expect_used)]
+        let path = env::var("CONNECTOR_AUTH_FILE_PATH")
+            .expect("connector authentication file path not set");
         toml::from_str(
-            &std::fs::read_to_string("tests/connectors/auth.toml")
-                .expect("connector authentication config file not found"),
+            &std::fs::read_to_string(path).expect("connector authentication config file not found"),
         )
         .expect("Failed to read connector authentication config file")
     }

crates/router/tests/connectors/connector_auth.rs

@@ -138,9 +138,9 @@ async fn should_throw_not_implemented_for_unsupported_issuer() {
     assert_eq!(
         *response.unwrap_err().current_context(),
         errors::ConnectorError::NotSupported {
-            payment_method: "Maestro".to_string(),
+            payment_method: "card".to_string(),
             connector: "worldline",
-            payment_experience: "redirect_to_url".to_string(),
+            payment_experience: "RedirectToUrl".to_string(),
         }
     )
 }

crates/router/tests/connectors/worldline.rs

@@ -0,0 +1,10 @@
+#! /usr/bin/env bash
+
+mkdir -p $HOME/target/test
+
+
+# Decrypt the file
+# --batch to prevent interactive command
+# --yes to assume "yes" for questions
+gpg --quiet --batch --yes --decrypt --passphrase="$CONNECTOR_AUTH_PASSPHRASE" \
+--output $HOME/target/test/connector_auth.toml .github/secrets/connector_auth.toml.gpg