Skip to content

feat(connector): [Nuvei] add support for bank redirect Eps, Sofort, Giropay, Ideal #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Apr 21, 2023
Merged

feat(connector): [Nuvei] add support for bank redirect Eps, Sofort, Giropay, Ideal #870

merged 28 commits into from
Apr 21, 2023

Conversation

jagan-jaya
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

  1. Add support for bank redirect Eps, Sofort, Giropay, Ideal
  2. Add UI tests for redirection flow using selenium

Additional Changes

  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Add support for card mandates and add tests

How did you test it?

Screen Shot 2023-04-13 at 4 04 18 AM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

jagan-jaya and others added 17 commits March 29, 2023 15:43
@jagan-jaya jagan-jaya added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement labels Apr 13, 2023
@jagan-jaya jagan-jaya self-assigned this Apr 13, 2023
@jagan-jaya jagan-jaya requested review from a team, jarnura and ashokkjag as code owners April 13, 2023 00:09
@jagan-jaya jagan-jaya changed the base branch from nuvei-v4 to main April 13, 2023 00:13
@jagan-jaya jagan-jaya changed the base branch from main to nuvei-v4 April 13, 2023 00:13
@jarnura jarnura added this to the April'23 release milestone Apr 14, 2023
@jarnura jarnura added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Apr 19, 2023
@jagan-jaya jagan-jaya dismissed stale reviews from Narayanbhat166 and ArjunKarthik via 4917b34 April 19, 2023 12:48
@jagan-jaya jagan-jaya linked an issue Apr 19, 2023 that may be closed by this pull request
[FEATURE] add unit tests for non 3DS, wallets & webhooks in connector tests #478
Closed
2 tasks
@jagan-jaya jagan-jaya added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Apr 19, 2023
@jagan-jaya jagan-jaya linked an issue Apr 19, 2023 that may be closed by this pull request
[FEATURE] Nuvei support for bank redirects #915
Closed
3 tasks
jarnura
jarnura previously approved these changes Apr 19, 2023
View reviewed changes
@jarnura jarnura added the S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners label Apr 19, 2023
ArjunKarthik
ArjunKarthik previously approved these changes Apr 19, 2023
View reviewed changes
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners labels Apr 20, 2023
@jarnura jarnura added this pull request to the merge queue Apr 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Apr 20, 2023
@jagan-jaya jagan-jaya dismissed stale reviews from ArjunKarthik and jarnura via af38622 April 21, 2023 04:30
@jarnura jarnura enabled auto-merge April 21, 2023 07:02
@jarnura jarnura added the S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners label Apr 21, 2023
@jarnura jarnura added this pull request to the merge queue Apr 21, 2023
Merged via the queue into main with commit c1a25b3 Apr 21, 2023
@jagan-jaya jagan-jaya removed the S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners label Apr 21, 2023
@Gnanasundari24 Gnanasundari24 mentioned this pull request Apr 21, 2023
Merged
@SanchithHegde SanchithHegde deleted the nuvei-bank-redirects branch April 21, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnura jarnura jarnura approved these changes

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

+2 more reviewers

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@jagan-jaya jagan-jaya

Labels
A-connector-integration Area: Connector integration A-framework Area: Framework C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
April 2023 Release
Development

Successfully merging this pull request may close these issues.

[FEATURE] Nuvei support for bank redirects [FEATURE] add unit tests for non 3DS, wallets & webhooks in connector tests
5 participants
@jagan-jaya @ArjunKarthik @jarnura @Narayanbhat166 @SanchithHegde