feat(Core): gracefully shutdown router/scheduler if Redis is unavailable #891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prajjwalkumar17
added
A-core
prajjwalkumar17
requested review from
SanchithHegde,
dracarys18 and
NishantJoshi00
prajjwalkumar17
requested review from
a team,
jarnura and
ashokkjag
as code owners
NishantJoshi00
added
the
S-waiting-on-review
|
Hey @prajjwalkumar17, please setup commit verification and enforce it through github |
NishantJoshi00
suggested changes
Apr 17, 2023
This was referenced Apr 17, 2023
Closed
This was
linked to
issues
Apr 17, 2023
Closed
SanchithHegde
changed the title
dracarys18
suggested changes
Apr 17, 2023
dracarys18
suggested changes
Apr 17, 2023
dracarys18
reviewed
Apr 17, 2023
SanchithHegde
added
C-feature
dracarys18
previously approved these changes
Apr 20, 2023
NishantJoshi00
previously approved these changes
Apr 20, 2023
jarnura
previously approved these changes
Apr 20, 2023
jarnura
added
S-ready-for-merge
and removed
S-waiting-on-review
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
jarnura
added
S-waiting-on-author
…t/gracefullShutdown
prajjwalkumar17
dismissed stale reviews from jarnura, NishantJoshi00, and dracarys18
via
f72b2e6
prajjwalkumar17
requested review from
SanchithHegde,
NishantJoshi00,
dracarys18 and
jarnura
prajjwalkumar17
added
S-waiting-on-review
SanchithHegde
approved these changes
Apr 21, 2023
jarnura
removed
the
S-waiting-on-review
jarnura
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
The change will from now allow the server to gracefully shutdown once the redis goes down. We are passing the tx and rx using a Oneshot::channel() for redis . It has a suitable receiver to stop the server once the tx is received.
Additional Changes
Motivation and Context
As the core Server wasn't shutting down whenever redis goes down and rather that going down with it. Server stayed there throwing health is good and then sending errors when hitting other routes.
Now the server gracefully goes down too once the redis goes down
How did you test it?
Tested it manually as we just need to check whether or not the server is shutting down on redis stopping
Checklist
cargo +nightly fmt --allcargo clippy