Skip to content

Commit ccfa435

Browse files
committed
kubelet: Use --config for default config
Signed-off-by: Boleyn Su <[email protected]>
1 parent c01cd8c commit ccfa435

File tree

5 files changed

+7
-6
lines changed

5 files changed

+7
-6
lines changed

pkg/agent/config/config.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -601,6 +601,7 @@ func get(ctx context.Context, envInfo *cmds.Agent, proxy proxy.Proxy) (*config.N
601601
return nil, err
602602
}
603603

604+
kubeletConfig := filepath.Join(envInfo.DataDir, "agent", "etc", "kubelet.conf")
604605
// Ensure kubelet config dir exists
605606
kubeletConfigDir := filepath.Join(envInfo.DataDir, "agent", "etc", "kubelet.conf.d")
606607
if err := os.MkdirAll(kubeletConfigDir, 0700); err != nil {
@@ -635,6 +636,7 @@ func get(ctx context.Context, envInfo *cmds.Agent, proxy proxy.Proxy) (*config.N
635636
nodeConfig.AgentConfig.ClusterDomain = controlConfig.ClusterDomain
636637
nodeConfig.AgentConfig.ResolvConf = locateOrGenerateResolvConf(envInfo)
637638
nodeConfig.AgentConfig.ClientCA = clientCAFile
639+
nodeConfig.AgentConfig.KubeletConfig = kubeletConfig
638640
nodeConfig.AgentConfig.KubeletConfigDir = kubeletConfigDir
639641
nodeConfig.AgentConfig.KubeConfigKubelet = kubeconfigKubelet
640642
nodeConfig.AgentConfig.KubeConfigKubeProxy = kubeconfigKubeproxy

pkg/daemons/agent/agent.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ func startKubelet(ctx context.Context, cfg *daemonconfig.Agent) error {
7272
return pkgerrors.WithMessage(err, "prepare user configuration drop-ins")
7373
}
7474

75-
if err := writeKubeletConfig(cfg.KubeletConfigDir, defaultConfig); err != nil {
75+
if err := writeKubeletConfig(cfg.KubeletConfig, defaultConfig); err != nil {
7676
return pkgerrors.WithMessage(err, "generate default kubelet configuration drop-in")
7777
}
7878

@@ -158,7 +158,7 @@ func writeKubeletConfig(path string, config *kubeletconfig.KubeletConfiguration)
158158
if err != nil {
159159
return err
160160
}
161-
return os.WriteFile(filepath.Join(path, "00-"+version.Program+"-defaults.conf"), b, 0600)
161+
return os.WriteFile(path, b, 0600)
162162
}
163163

164164
func defaultKubeletConfig(cfg *daemonconfig.Agent) (*kubeletconfig.KubeletConfiguration, error) {

pkg/daemons/agent/agent_linux.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import (
1313
"github.com/k3s-io/k3s/pkg/cgroups"
1414
"github.com/k3s-io/k3s/pkg/daemons/config"
1515
"github.com/k3s-io/k3s/pkg/util"
16-
"github.com/k3s-io/k3s/pkg/version"
1716
"github.com/sirupsen/logrus"
1817
"golang.org/x/sys/unix"
1918
kubeletconfig "k8s.io/kubelet/config/v1beta1"
@@ -76,7 +75,7 @@ func kubeletArgsAndConfig(cfg *config.Agent) (map[string]string, *kubeletconfig.
7675
return nil, nil, err
7776
}
7877
argsMap := map[string]string{
79-
"config": filepath.Join(cfg.KubeletConfigDir, "00-"+version.Program+"-defaults.conf"),
78+
"config": cfg.kubeletConfig,
8079
"config-dir": cfg.KubeletConfigDir,
8180
"kubeconfig": cfg.KubeConfigKubelet,
8281
}

pkg/daemons/agent/agent_windows.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import (
1010

1111
"github.com/k3s-io/k3s/pkg/daemons/config"
1212
"github.com/k3s-io/k3s/pkg/util"
13-
"github.com/k3s-io/k3s/pkg/version"
1413
"github.com/sirupsen/logrus"
1514
kubeletconfig "k8s.io/kubelet/config/v1beta1"
1615
utilsnet "k8s.io/utils/net"
@@ -49,7 +48,7 @@ func kubeletArgsAndConfig(cfg *config.Agent) (map[string]string, *kubeletconfig.
4948
return nil, nil, err
5049
}
5150
argsMap := map[string]string{
52-
"config": filepath.Join(cfg.KubeletConfigDir, "00-"+version.Program+"-defaults.conf"),
51+
"config": cfg.KubeletConfig,
5352
"config-dir": cfg.KubeletConfigDir,
5453
"kubeconfig": cfg.KubeConfigKubelet,
5554
}

pkg/daemons/config/types.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@ type Agent struct {
119119
ClusterDomain string
120120
ResolvConf string
121121
RootDir string
122+
KubeletConfig string
122123
KubeletConfigDir string
123124
KubeConfigKubelet string
124125
KubeConfigKubeProxy string

0 commit comments

Comments
 (0)