Skip to content

Commit 77b6863

Browse files
committed
Revert "fixed pybind11 problem"
This reverts commit db76d09.
1 parent 173f67e commit 77b6863

File tree

4 files changed

+6
-3
lines changed

4 files changed

+6
-3
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ jobs:
362362
clang-format --version
363363
clang-format-20 --version
364364
# skip cachelib_memory_allocator
365-
find . -type f \( -name "*.h" -o -name "*.cpp" \) | grep -v cachelib_memory_allocator | xargs clang-format-20 -style=file -i
365+
find . -type f \( -name "*.h" -o -name "*.cpp" \) | grep -v "extern/" | grep -v "cachelib_memory_allocator" | xargs clang-format-20 -style=file -i
366366
if ! git diff --exit-code; then
367367
echo "Please follow the .clang-format code style, try clang-format -i FILENAME"
368368
exit 1

mooncake-transfer-engine/src/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ endif()
1919

2020
SET(CMAKE_INSTALL_RPATH_USE_LINK_PATH TRUE)
2121

22-
add_library(transfer_engine ${ENGINE_SOURCES} $<TARGET_OBJECTS:transport> $<TARGET_OBJECTS:rdma_transport> $<TARGET_OBJECTS:coro_rpc_connector>)
22+
add_library(transfer_engine ${ENGINE_SOURCES} $<TARGET_OBJECTS:transport>)
2323
if (BUILD_SHARED_LIBS)
2424
install(TARGETS transfer_engine DESTINATION lib)
2525
endif()

mooncake-transfer-engine/src/transport/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ find_package(Python3 COMPONENTS Interpreter Development REQUIRED)
66
add_subdirectory(rdma_transport)
77
add_subdirectory(coro_rpc_connector)
88

9-
add_library(transport OBJECT ${XPORT_SOURCES})
9+
add_library(transport OBJECT ${XPORT_SOURCES} $<TARGET_OBJECTS:rdma_transport> $<TARGET_OBJECTS:coro_rpc_connector>)
1010
target_link_libraries(transport PRIVATE JsonCpp::JsonCpp yalantinglibs::yalantinglibs glog::glog pthread ${Python3_LIBRARIES})
1111
target_include_directories(transport PRIVATE ${Python3_INCLUDE_DIRS})
1212

mooncake-transfer-engine/src/transport/coro_rpc_connector/CMakeLists.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
file(GLOB CORO_RPC_SOURCES "*.cpp")
22

3+
# Find Python for pybind11 support
4+
find_package(Python3 COMPONENTS Interpreter Development REQUIRED)
5+
36
add_library(coro_rpc_connector OBJECT ${CORO_RPC_SOURCES})
47
add_library(yalantinglibs STATIC IMPORTED)
58
set_target_properties(yalantinglibs PROPERTIES

0 commit comments

Comments
 (0)