fix: improves handling of invalid contexts and adds SSE Client logging. #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanderson-ld
commented
Aug 29, 2025
kinyoklion
reviewed
Aug 29, 2025
packages/common_client/lib/src/context_modifiers/anonymous_context_modifier.dart
Outdated
Show resolved
Hide resolved
kinyoklion
reviewed
Aug 29, 2025
kinyoklion
reviewed
Aug 29, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
kinyoklion
approved these changes
Sep 2, 2025
tanderson-ld
deleted the
ta/SDK-1413/invalid-context-handling-and-logging
branch
This was referenced Sep 2, 2025
tanderson-ld
pushed a commit
that referenced
this pull request
Sep 3, 2025
🤖 I have created a release *beep* *boop* --- ## [1.2.1](launchdarkly_event_source_client-v1.2.0...launchdarkly_event_source_client-v1.2.1) (2025-09-02) ### Bug Fixes * improves handling of invalid contexts and adds SSE Client logging. ([#207](#207)) ([fcab81f](fcab81f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
tanderson-ld
pushed a commit
that referenced
this pull request
Sep 3, 2025
🤖 I have created a release *beep* *boop* --- ## [1.6.1](launchdarkly_dart_common-v1.6.0...launchdarkly_dart_common-v1.6.1) (2025-09-03) ### Bug Fixes * improves handling of invalid contexts and adds SSE Client logging. ([#207](#207)) ([fcab81f](fcab81f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
tanderson-ld
added a commit
that referenced
this pull request
Sep 3, 2025
🤖 I have created a release *beep* *boop* --- ## [1.6.2](launchdarkly_common_client-v1.6.1...launchdarkly_common_client-v1.6.2) (2025-09-03) ### Bug Fixes * improves handling of invalid contexts and adds SSE Client logging. ([#207](#207)) ([fcab81f](fcab81f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Todd Anderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
I have added test coverage for new or changed functionality
I have followed the repository's pull request submission guidelines
I have validated my changes against all supported platform versions
Related issues
SDK-1413
Describe the solution you've provided
Adds context validity checks to start and identify that prevents state change if invalid context is provided.
Adds logging to SSE client and necessary adapter to use LDLogger.