LPS-144248 make the list once

Author: brianchandotcom

modules/dxp/apps/portal-workflow/portal-workflow-kaleo-forms-web/src/main/java/com/liferay/portal/workflow/kaleo/forms/web/internal/portlet/KaleoFormsAdminPortlet.java

@@ -69,8 +69,6 @@
 
 import java.io.IOException;
 
-import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.List;
 import java.util.Locale;
 import java.util.Map;
@@ -128,6 +126,21 @@
 )
 public class KaleoFormsAdminPortlet extends MVCPortlet {
 
+	public KaleoFormsAdminPortlet() {
+		_parameterNames = ListUtil.fromArray(
+			"backURL", "ddmStructureId", "ddmStructureName", "ddmTemplateId",
+			"historyKey", "kaleoProcessId", "kaleoTaskFormPairsData", "mvcPath",
+			"redirect", "translatedLanguagesDescription",
+			"translatedLanguagesName", "workflowDefinition");
+
+		for (Locale availableLocale : LanguageUtil.getAvailableLocales()) {
+			_parameterNames.add(
+				"description" + LocaleUtil.toLanguageId(availableLocale));
+			_parameterNames.add(
+				"name" + LocaleUtil.toLanguageId(availableLocale));
+		}
+	}
+
 	/**
 	 * Deletes the <code>KaleoDraftDefinition</code> (in the
 	 * <code>com.liferay.portal.workflow.kaleo.designer.api</code> module) by
@@ -391,10 +404,7 @@ protected void saveInPortletSession(
 
 		PortletSession portletSession = resourceRequest.getPortletSession();
 
-		for (String parameterName :
-				ListUtil.concat(
-					_getLocalizedParameterNames(), _parameterNames)) {
-
+		for (String parameterName : _parameterNames) {
 			if (!parameterMap.containsKey(parameterName)) {
 				continue;
 			}
@@ -524,28 +534,9 @@ protected void setDisplayContext(
 	@Reference
 	protected StorageEngine storageEngine;
 
-	private List<String> _getLocalizedParameterNames() {
-		List<String> localizedParameters = new ArrayList<>();
-
-		for (Locale availableLocale : LanguageUtil.getAvailableLocales()) {
-			localizedParameters.add(
-				"description" + LocaleUtil.toLanguageId(availableLocale));
-			localizedParameters.add(
-				"name" + LocaleUtil.toLanguageId(availableLocale));
-		}
-
-		return localizedParameters;
-	}
-
 	private static final Log _log = LogFactoryUtil.getLog(
 		KaleoFormsAdminPortlet.class);
 
-	private static final List<String> _parameterNames = Arrays.asList(
-		"backURL", "ddmStructureId", "ddmStructureName", "ddmTemplateId",
-		"historyKey", "kaleoProcessId", "kaleoTaskFormPairsData", "mvcPath",
-		"redirect", "translatedLanguagesDescription", "translatedLanguagesName",
-		"workflowDefinition");
-
 	@Reference
 	private DDLExporterFactory _ddlExporterFactory;
 
@@ -567,6 +558,8 @@ private List<String> _getLocalizedParameterNames() {
 	@Reference
 	private KaleoProcessService _kaleoProcessService;
 
+	private final List<String> _parameterNames;
+
 	@Reference
 	private WorkflowInstanceLinkLocalService _workflowInstanceLinkLocalService;