fix(*): incorrect error location and refactor (#304)

This pull request refactors the `textlint-rule-allowed-uris` module by
removing the `theme.js` utility file and relocating its functionality
directly into the main rule file. Additionally, it improves readability
and simplifies error handling in related files. Below are the key
changes grouped by theme:

### Refactoring and Code Simplification:
- Removed the `theme.js` file entirely, and its `error` and
`strikethrough` functions were re-implemented directly in
`src/textlint-rule-allowed-uris.js` under a new "Helpers" section.
(`[[1]](diffhunk://#diff-a2b1e5729a82f074ccb347987a8e0f012306a67763b353dde9875db8b069afa5L1-L13)`,
`[[2]](diffhunk://#diff-7da72e1e0d5c49a43b94f9d928d3157918c0bdcc3121c5ed14e0bc459b3f26f9R22-R43)`)
- Updated the `report` function in `src/textlint-rule-allowed-uris.js`
to use the relocated `error` and `strikethrough` helpers, simplifying
its structure by converting it from an arrow function to a named `async
function`.
(`[[1]](diffhunk://#diff-7da72e1e0d5c49a43b94f9d928d3157918c0bdcc3121c5ed14e0bc459b3f26f9L52-R73)`,
`[[2]](diffhunk://#diff-7da72e1e0d5c49a43b94f9d928d3157918c0bdcc3121c5ed14e0bc459b3f26f9L67-R92)`)

### Dependency Cleanup:
- Removed the `error` import from
`src/utils/get-definition-node-uri-type/get-definition-node-uri-type.js`,
as it is no longer needed due to the removal of `theme.js`.
(`[src/utils/get-definition-node-uri-type/get-definition-node-uri-type.jsL11](diffhunk://#diff-7facb9d42bcc13857fefafc7c89f3bc71f7aea27042c5251c4d534b101628c8eL11)`)
- Simplified error handling in `getMimeType` by removing the usage of
the `error` helper and directly throwing plain error messages.
(`[src/utils/get-definition-node-uri-type/get-definition-node-uri-type.jsL32-L34](diffhunk://#diff-7facb9d42bcc13857fefafc7c89f3bc71f7aea27042c5251c4d534b101628c8eL32-L34)`)

### Test Updates:
- Modified the test cases in `tests/textlint-rule-allowed-uris.test.js`
to replace the `createErrors` function with explicit error objects for
improved clarity and flexibility.
(`[tests/textlint-rule-allowed-uris.test.jsL168-R178](diffhunk://#diff-89b20226c99b6337f60cfce86fa424eded9dcce3e51d2231af14c9ca52614ae1L168-R178)`)

Author: lumirlumir

src/textlint-rule-allowed-uris.js

@@ -7,7 +7,6 @@
 // Import
 // --------------------------------------------------------------------------------
 
-import { error, strikethrough } from './utils/theme.js';
 import { getUriTypesDefinition, getUriTypesHtml } from './utils/get-uri-types/index.js';
 
 // --------------------------------------------------------------------------------
@@ -20,6 +19,28 @@ import { getUriTypesDefinition, getUriTypesHtml } from './utils/get-uri-types/in
  * @import { UriType, Options } from './utils/types.js';
  */
 
+// --------------------------------------------------------------------------------
+// Helpers
+// --------------------------------------------------------------------------------
+
+/**
+ * Console error theme.
+ * @param {string} str
+ * @return {string}
+ */
+function error(str) {
+  return `\u001b[31m${str}\u001b[0m`;
+}
+
+/**
+ * Console strikethrough theme.
+ * @param {string} str
+ * @return {string}
+ */
+function strikethrough(str) {
+  return `\u001b[9m${str}\u001b[0m`;
+}
+
 // --------------------------------------------------------------------------------
 // Export
 // --------------------------------------------------------------------------------
@@ -49,7 +70,7 @@ export default function textlintRuleAllowedUris(context, rawOptions) {
    * @returns {Promise<void>}
    * @async
    */
-  const report = async (node, uriTypes) => {
+  async function report(node, uriTypes) {
     uriTypes.forEach(({ uri, type }) => {
       Object.keys(options).forEach(key => {
         // The `some` method returns `true` if any element in the array satisfies the given condition.
@@ -64,14 +85,11 @@ export default function textlintRuleAllowedUris(context, rawOptions) {
             node,
             new context.RuleError(
               `${error(`${key}.${type}s`)}\n${error('-')} problem: '${strikethrough(uri)}'\n${error('-')} ${key} regular expressions: '${options[key][`${type}s`].join(' or ')}'`,
-              {
-                padding: context.locator.at(0),
-              },
             ),
           );
       });
     });
-  };
+  }
 
   return {
     /** @param {TxtLinkNode} node */

src/utils/get-definition-node-uri-type/get-definition-node-uri-type.js

@@ -8,7 +8,6 @@
 
 import url from 'node:url';
 import mime from 'mime-types';
-import { error } from '../theme.js';
 
 // --------------------------------------------------------------------------------
 // Helpers
@@ -29,9 +28,7 @@ const getMimeType = async uri => {
     // fetch failed. (Internet connection)
     if (err?.cause?.code === 'ENOTFOUND')
       throw new Error(
-        error(
-          'The linting process includes an HTTP request, so an internet connection is required',
-        ),
+        'The linting process includes an HTTP request, so an internet connection is required',
       );
     // fetch failed. (i.e. Local URI links)
     return mime.lookup(url.parse(uri).pathname) || 'application/octet-stream'; // eslint-disable-line -- TODO: Remove this comment.

src/utils/theme.js

@@ -165,9 +165,17 @@ test('textlint-rule-allowed-uris', () => {
             // images: [],
           },
         },
-        errors: createErrors([
-          7, 9, 13, 15, 19, 21, 23, 25, 31, 37, 43, 47, 86, 101, 103, 105,
-        ]),
+        errors: [
+          {
+            line: 7,
+            range: [97, 119],
+          },
+          {
+            line: 9,
+            range: [121, 138],
+          },
+          ...createErrors([13, 15, 19, 21, 23, 25, 31, 37, 43, 47, 86, 101, 103, 105]),
+        ],
       },
       {
         name: 'Pass Empty Array - 2',