Merge pull request #1760 from nanjj/nvramlink

incusd/instance/qemu: Skip to link nvram to itself

Author: stgraber

internal/server/instance/drivers/driver_qemu.go

@@ -2243,11 +2243,18 @@ func (d *qemu) setupNvram() error {
 		return err
 	}
 
+	nvramPath := d.nvramPath()
+
+	// Handle the case where the firmware vars filename matches our internal one.
+	if efiVarsName == filepath.Base(nvramPath) {
+		return nil
+	}
+
 	// Generate a symlink.
 	// This is so qemu.nvram can always be assumed to be the EDK2 vars file.
 	// The real file name is then used to determine what firmware must be selected.
-	_ = os.Remove(d.nvramPath())
-	err = os.Symlink(efiVarsName, d.nvramPath())
+	_ = os.Remove(nvramPath)
+	err = os.Symlink(efiVarsName, nvramPath)
 	if err != nil {
 		return err
 	}