Skip to content

Commit 7c15363

Browse files
authored
Merge pull request #1955 from joecwilson/cli-aliases-full
Add common aliases for add/create remove/delete/rm in the CLI
2 parents 68d4de5 + ca9a07f commit 7c15363

24 files changed

+57
-25
lines changed

cmd/incus/alias.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ type cmdAliasAdd struct {
5858
func (c *cmdAliasAdd) Command() *cobra.Command {
5959
cmd := &cobra.Command{}
6060
cmd.Use = usage("add", i18n.G("<alias> <target>"))
61+
cmd.Aliases = []string{"create"}
6162
cmd.Short = i18n.G("Add new aliases")
6263
cmd.Long = cli.FormatSection(i18n.G("Description"), i18n.G(
6364
`Add new aliases`))
@@ -223,7 +224,7 @@ type cmdAliasRemove struct {
223224
func (c *cmdAliasRemove) Command() *cobra.Command {
224225
cmd := &cobra.Command{}
225226
cmd.Use = usage("remove", i18n.G("<alias>"))
226-
cmd.Aliases = []string{"rm"}
227+
cmd.Aliases = []string{"delete", "rm"}
227228
cmd.Short = i18n.G("Remove aliases")
228229
cmd.Long = cli.FormatSection(i18n.G("Description"), i18n.G(
229230
`Remove aliases`))

cmd/incus/cluster.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -705,7 +705,7 @@ type cmdClusterRemove struct {
705705
func (c *cmdClusterRemove) Command() *cobra.Command {
706706
cmd := &cobra.Command{}
707707
cmd.Use = usage("remove", i18n.G("[<remote>:]<member>"))
708-
cmd.Aliases = []string{"rm"}
708+
cmd.Aliases = []string{"delete", "rm"}
709709
cmd.Short = i18n.G("Remove a member from the cluster")
710710
cmd.Long = cli.FormatSection(i18n.G("Description"), i18n.G(
711711
`Remove a member from the cluster`))

cmd/incus/cluster_role.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ type cmdClusterRoleAdd struct {
4848
func (c *cmdClusterRoleAdd) Command() *cobra.Command {
4949
cmd := &cobra.Command{}
5050
cmd.Use = usage("add", i18n.G("[<remote>:]<member> <role[,role...]>"))
51+
cmd.Aliases = []string{"create"}
5152
cmd.Short = i18n.G("Add roles to a cluster member")
5253
cmd.Long = cli.FormatSection(i18n.G("Description"), i18n.G(
5354
`Add roles to a cluster member`))
@@ -112,6 +113,7 @@ type cmdClusterRoleRemove struct {
112113
func (c *cmdClusterRoleRemove) Command() *cobra.Command {
113114
cmd := &cobra.Command{}
114115
cmd.Use = usage("remove", i18n.G("[<remote>:]<member> <role[,role...]>"))
116+
cmd.Aliases = []string{"delete", "rm"}
115117
cmd.Short = i18n.G("Remove roles from a cluster member")
116118
cmd.Long = cli.FormatSection(i18n.G("Description"), i18n.G(
117119
`Remove roles from a cluster member`))

cmd/incus/config_device.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ type cmdConfigDeviceAdd struct {
7777
// Command returns a cobra.Command for use with (*cobra.Command).AddCommand.
7878
func (c *cmdConfigDeviceAdd) Command() *cobra.Command {
7979
cmd := &cobra.Command{}
80+
cmd.Aliases = []string{"create"}
8081
cmd.Short = i18n.G("Add instance devices")
8182
cmd.Long = cli.FormatSection(i18n.G("Description"), i18n.G(
8283
`Add instance devices`))
@@ -508,7 +509,7 @@ func (c *cmdConfigDeviceRemove) Command() *cobra.Command {
508509
cmd.Use = usage("remove", i18n.G("[<remote>:]<profile> <name>..."))
509510
}
510511

511-
cmd.Aliases = []string{"rm"}
512+
cmd.Aliases = []string{"delete", "rm"}
512513
cmd.Short = i18n.G("Remove instance devices")
513514
cmd.Long = cli.FormatSection(i18n.G("Description"), i18n.G(
514515
`Remove instance devices`))

cmd/incus/config_template.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ type cmdConfigTemplateCreate struct {
6565
func (c *cmdConfigTemplateCreate) Command() *cobra.Command {
6666
cmd := &cobra.Command{}
6767
cmd.Use = usage("create", i18n.G("[<remote>:]<instance> <template>"))
68+
cmd.Aliases = []string{"add"}
6869
cmd.Short = i18n.G("Create new instance file templates")
6970
cmd.Long = cli.FormatSection(i18n.G("Description"), i18n.G(
7071
`Create new instance file templates`))
@@ -134,7 +135,7 @@ type cmdConfigTemplateDelete struct {
134135
func (c *cmdConfigTemplateDelete) Command() *cobra.Command {
135136
cmd := &cobra.Command{}
136137
cmd.Use = usage("delete", i18n.G("[<remote>:]<instance> <template>"))
137-
cmd.Aliases = []string{"rm"}
138+
cmd.Aliases = []string{"rm", "remove"}
138139
cmd.Short = i18n.G("Delete instance file templates")
139140
cmd.Long = cli.FormatSection(i18n.G("Description"), i18n.G(
140141
`Delete instance file templates`))

cmd/incus/config_trust.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -770,7 +770,7 @@ type cmdConfigTrustRemove struct {
770770
func (c *cmdConfigTrustRemove) Command() *cobra.Command {
771771
cmd := &cobra.Command{}
772772
cmd.Use = usage("remove", i18n.G("[<remote>:]<fingerprint>"))
773-
cmd.Aliases = []string{"rm"}
773+
cmd.Aliases = []string{"delete", "rm"}
774774
cmd.Short = i18n.G("Remove trusted client")
775775
cmd.Long = cli.FormatSection(i18n.G("Description"), i18n.G(
776776
`Remove trusted client`))

cmd/incus/file.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,7 @@ type cmdFileDelete struct {
295295
func (c *cmdFileDelete) Command() *cobra.Command {
296296
cmd := &cobra.Command{}
297297
cmd.Use = usage("delete", i18n.G("[<remote>:]<instance>/<path> [[<remote>:]<instance>/<path>...]"))
298-
cmd.Aliases = []string{"rm"}
298+
cmd.Aliases = []string{"rm", "remove"}
299299
cmd.Short = i18n.G("Delete files in instances")
300300
cmd.Long = cli.FormatSection(i18n.G("Description"), i18n.G(
301301
`Delete files in instances`))

cmd/incus/image.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@ type cmdImageDelete struct {
310310
func (c *cmdImageDelete) Command() *cobra.Command {
311311
cmd := &cobra.Command{}
312312
cmd.Use = usage("delete", i18n.G("[<remote>:]<image> [[<remote>:]<image>...]"))
313-
cmd.Aliases = []string{"rm"}
313+
cmd.Aliases = []string{"rm", "remove"}
314314
cmd.Short = i18n.G("Delete images")
315315
cmd.Long = cli.FormatSection(i18n.G("Description"), i18n.G(
316316
`Delete images`))

cmd/incus/image_alias.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ type cmdImageAliasCreate struct {
6767
func (c *cmdImageAliasCreate) Command() *cobra.Command {
6868
cmd := &cobra.Command{}
6969
cmd.Use = usage("create", i18n.G("[<remote>:]<alias> <fingerprint>"))
70+
cmd.Aliases = []string{"add"}
7071
cmd.Short = i18n.G("Create aliases for existing images")
7172
cmd.Long = cli.FormatSection(i18n.G("Description"), i18n.G(
7273
`Create aliases for existing images`))
@@ -135,7 +136,7 @@ type cmdImageAliasDelete struct {
135136
func (c *cmdImageAliasDelete) Command() *cobra.Command {
136137
cmd := &cobra.Command{}
137138
cmd.Use = usage("delete", i18n.G("[<remote>:]<alias>"))
138-
cmd.Aliases = []string{"rm"}
139+
cmd.Aliases = []string{"rm", "remove"}
139140
cmd.Short = i18n.G("Delete image aliases")
140141
cmd.Long = cli.FormatSection(i18n.G("Description"), i18n.G(
141142
`Delete image aliases`))

cmd/incus/network.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -348,6 +348,7 @@ type cmdNetworkCreate struct {
348348
func (c *cmdNetworkCreate) Command() *cobra.Command {
349349
cmd := &cobra.Command{}
350350
cmd.Use = usage("create", i18n.G("[<remote>:]<network> [key=value...]"))
351+
cmd.Aliases = []string{"add"}
351352
cmd.Short = i18n.G("Create new networks")
352353
cmd.Long = cli.FormatSection(i18n.G("Description"), i18n.G(`Create new networks`))
353354
cmd.Example = cli.FormatSection("", i18n.G(`incus network create foo
@@ -465,7 +466,7 @@ type cmdNetworkDelete struct {
465466
func (c *cmdNetworkDelete) Command() *cobra.Command {
466467
cmd := &cobra.Command{}
467468
cmd.Use = usage("delete", i18n.G("[<remote>:]<network>"))
468-
cmd.Aliases = []string{"rm"}
469+
cmd.Aliases = []string{"rm", "remove"}
469470
cmd.Short = i18n.G("Delete networks")
470471
cmd.Long = cli.FormatSection(i18n.G("Description"), i18n.G(
471472
`Delete networks`))

0 commit comments

Comments
 (0)