Merge pull request #14 from mercari/status-check-description-prefix-2

Separate prefix for each state

Author: south-mer

server/handler/eval_context.go

@@ -190,9 +190,23 @@ func (ec *EvalContext) PostStatus(ctx context.Context, state, message string) {
 		context = ec.Options.StatusCheckContext
 	}
 
+	var prefix string
+	switch state {
+	case "success":
+		prefix = ec.Options.StatusCheckDescriptionPrefix.Success
+	case "pending":
+		prefix = ec.Options.StatusCheckDescriptionPrefix.Pending
+	case "failure":
+		prefix = ec.Options.StatusCheckDescriptionPrefix.Failure
+	case "error":
+		prefix = ec.Options.StatusCheckDescriptionPrefix.Error
+	default:
+		logger.Warn().Ctx(ctx).Msgf("Unknown status state: %s, using empty prefix", state)
+	}
+
 	var description string
-	if ec.Options.StatusCheckDescriptionPrefix != "" {
-		description = fmt.Sprintf("%s %s", ec.Options.StatusCheckDescriptionPrefix, message)
+	if prefix != "" {
+		description = fmt.Sprintf("%s %s", prefix, message)
 	} else {
 		description = message
 	}

server/handler/eval_options.go

@@ -26,6 +26,17 @@ const (
 	DefaultStatusCheckContext = "policy-bot"
 )
 
+type DescriptionPrefix struct {
+	// Approved
+	Success string `yaml:"success"`
+	// Pending
+	Pending string `yaml:"pending"`
+	// Disapproved
+	Failure string `yaml:"failure"`
+	// Skipped / Error
+	Error string `yaml:"error"`
+}
+
 type PullEvaluationOptions struct {
 	PolicyPath string `yaml:"policy_path"`
 
@@ -44,7 +55,7 @@ type PullEvaluationOptions struct {
 	StatusCheckContextIgnoreBase bool `yaml:"status_check_context_ignore_base"`
 
 	// StatusCheckDescriptionPrefix will be used to prefix the status check description, with a space inserted.
-	StatusCheckDescriptionPrefix string `yaml:"status_check_description_prefix"`
+	StatusCheckDescriptionPrefix DescriptionPrefix `yaml:"status_check_description_prefix"`
 
 	// ExpandRequiredReviewers enables a UI feature where the details page
 	// shows a list of the users who can approve each rule. Enabling this