Update core dependencies #2146
Merged
Update core dependencies #2146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
| @@ -7440,7 +7440,7 @@ interface RTCRtpScriptTransformer extends EventTarget { | |||
| * | |||
| * [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCRtpScriptTransformer/generateKeyFrame) | |||
| */ | |||
| generateKeyFrame(rid?: string): Promise<number>; | |||
| generateKeyFrame(rid?: string): Promise<void>; | |||
There was a problem hiding this comment.
A Promise that fulfills with the timestamp of the frame, or rejects with an exception value.
There was a problem hiding this comment.
Oh, this is in a webworker. Hmm
There was a problem hiding this comment.
MDN is not the normative reference 😉
typescript-bot
force-pushed
the
update-core-deps
branch
4 times, most recently
from
538245d to
32d5172
Compare
|
Unclear how much the return type change is web compatible, but LGTM |
|
There was an issue merging, maybe try again saschanaz. Details |
typescript-bot
force-pushed
the
update-core-deps
branch
from
32d5172 to
6ac90b9
Compare
jakebailey
approved these changes
Sep 16, 2025
|
LGTM |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action