Selector in Element.matches()
should type narrow
#2147
+24
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds TypeScript overloads for the
matches
method.The overloads leverages the
HTMLElementTagNameMap
similar to how overloads are handled for methods likequerySelector
, but here for type narrowing by making it eg.this is HTMLElementTagNameMap[K]
.Tests have been run locally and are passing.
Changes:
emitMatchesOverloads
to generate overload signatures for thematches
method.emitMatchesOverloads
when processing thematches
method.